Re: syn cache tcp checksum

2023-05-30 Thread Alexander Bluhm
anyone? On Mon, May 22, 2023 at 10:17:31PM +0200, Alexander Bluhm wrote: > Hi, > > I noticed a missing checksum count in netstat tcp packets sent > software-checksummed. Turns out that our syn cache does the checksum > calculation by hand, instead of the established mechanism in ip > output. >

Re: rpki-client: prime file modification times to optimize failover from RRDP to RSYNC

2023-05-30 Thread Claudio Jeker
On Wed, May 24, 2023 at 04:18:30PM +, Job Snijders wrote: > Dear all, > > Claudio made some suggestions to pass the desired modification times > around in a different way, below is an updated patch proposal. > I also added some instrumentation to also adjust GBRs and TAKs. > > RIPE & APNIC

Re: ksh, test: test -t file descriptor isn't optional

2023-05-30 Thread Lucas
Omar Polo wrote: > sorry for the delay, this is another mail that I meant to take a look > earlier... Thanks for the review, Omar! > > > together with a small > > > rewrite in test_eval TO_FILTT case, as it was a bit too difficult for me > > > to read: it seems that, for legacy reason (haven't

Re: rpki-client: prime file modification times to optimize failover from RRDP to RSYNC

2023-05-30 Thread Claudio Jeker
On Tue, May 30, 2023 at 02:38:23PM +0200, Claudio Jeker wrote: > On Wed, May 24, 2023 at 04:18:30PM +, Job Snijders wrote: > > Dear all, > > > > Claudio made some suggestions to pass the desired modification times > > around in a different way, below is an updated patch proposal. > > I also

Re: Bail out on "id -R user"

2023-05-30 Thread Omar Polo
On 2023/05/29 16:37:39 +, Lucas wrote: > Ping. > > > According to both usage() and id.1, "id -R" doesn't accept any > > positional arguments. This diff makes program behave like that. sorry for the delay, i wanted to take a look earlier. fwiw I agree. Although it doesn't makes much sense

Re: ksh, test: test -t file descriptor isn't optional

2023-05-30 Thread Omar Polo
sorry for the delay, this is another mail that I meant to take a look earlier... On 2023/05/29 16:36:45 +, Lucas wrote: > Ping. > > > Hi tech@, > > > > Both test.1 and ksh.1 (under the non-POSIX compatibility flag) state > > that `test -t` will default to test whether fd 1 is a TTY if the

Re: rpki-client: prime file modification times to optimize failover from RRDP to RSYNC

2023-05-30 Thread Job Snijders
On Tue, May 30, 2023 at 03:12:46PM +0200, Claudio Jeker wrote: > On Tue, May 30, 2023 at 02:38:23PM +0200, Claudio Jeker wrote: > > On Wed, May 24, 2023 at 04:18:30PM +, Job Snijders wrote: > > > Dear all, > > > > > > Claudio made some suggestions to pass the desired modification times > > >

Re: Bail out on "id -R user"

2023-05-30 Thread Todd C . Miller
On Tue, 30 May 2023 09:47:08 +0200, Omar Polo wrote: > fwiw I agree. Although it doesn't makes much sense to pass an > argument to id -R, not failing may give the wrong impression. > > ok op@ (i'll wait a bit before commiting this in case someone > disagrees) OK millert@ as well if you want to

Re: rpki-client: prime file modification times to optimize failover from RRDP to RSYNC

2023-05-30 Thread Claudio Jeker
On Tue, May 30, 2023 at 02:10:31PM +, Job Snijders wrote: > On Tue, May 30, 2023 at 03:12:46PM +0200, Claudio Jeker wrote: > > On Tue, May 30, 2023 at 02:38:23PM +0200, Claudio Jeker wrote: > > > On Wed, May 24, 2023 at 04:18:30PM +, Job Snijders wrote: > > > > Dear all, > > > > > > > >

Re: ksh, test: test -t file descriptor isn't optional

2023-05-30 Thread Todd C . Miller
I just checked and it seems that while zsh supports the pre-POSIX behavior of "test -t" using fd 1, both dash and bash treat "-t" as a string by default when there is no fd specified. So I think this change is fine. OK millert@ for your revised dif if you add the missing ';' after the "return

lo(4) checksum offload

2023-05-30 Thread Alexander Bluhm
Hi, Currently packets sent over loopback interface get their checksum calculated twice. In the output path it is set and during TCP/IP input it is calculated again to be compared with the previous value. This can be avoided by claiming that lo(4) supports hardware checksum offloading. For each

Re: lo(4) checksum offload

2023-05-30 Thread David Gwynne
On Tue, May 30, 2023 at 09:08:45PM +0200, Alexander Bluhm wrote: > Hi, > > Currently packets sent over loopback interface get their checksum > calculated twice. In the output path it is set and during TCP/IP > input it is calculated again to be compared with the previous value. > > This can be

Re: ifconfig description for wireguard peers

2023-05-30 Thread Klemens Nanni
On Tue, May 23, 2023 at 07:13:28PM +, Klemens Nanni wrote: > On Sat, Jan 14, 2023 at 02:28:27PM +, Stuart Henderson wrote: > > On 2023/01/12 04:49, Mikolaj Kucharski wrote: > > > Hi, > > > > > > Is there anything else which I can do, to help this diff reviwed and > > > increase the chance