relayd: DIOCXCOMMIT can fail

2013-03-18 Thread Giovanni Bechis
In pfe_filter.c there is a call to DIOCXCOMMIT ioctl to commit pf rules generated by relayd but in pfe_filter.c:551 there is only a warning about the transaction failing. If transaction_commit fails with EBUSY relayd thinks that the pf rules has been committed but they are not; at this moment

Re: relayd: DIOCXCOMMIT can fail

2013-03-18 Thread Stuart Henderson
On 2013/03/18 09:38, Giovanni Bechis wrote: In pfe_filter.c there is a call to DIOCXCOMMIT ioctl to commit pf rules generated by relayd but in pfe_filter.c:551 there is only a warning about the transaction failing. If transaction_commit fails with EBUSY relayd thinks that the pf rules has

Re: relayd: DIOCXCOMMIT can fail

2013-03-18 Thread Giovanni Bechis
On Mon, Mar 18, 2013 at 11:15:55AM +, Stuart Henderson wrote: Retrying EBUSY definitely makes sense to me. Wonder if it's worth having a fixed minimum (i.e. timer = 500 + arc4random_uniform(1) or something)? I'm undecided about s/log_warn/fatalx/, in some ways it's better if it

Re: tedu netatm and ueagle(4)?

2013-03-18 Thread Jonathan Gray
On Mon, Mar 18, 2013 at 02:49:35PM +0100, Martin Pieuchot wrote: On 16/03/13(Sat) 11:51, Jonathan Gray wrote: On Fri, Mar 15, 2013 at 03:30:00PM +0100, Martin Pieuchot wrote: tatus: O Content-Length: 119872 Lines: 4249 ueagle(4) is the only driver requiring netnatm and none of

nc(1) shutdown(2) typo

2013-03-18 Thread Martin Pelikan
Hi! Theo pointed out an issue with nc(1), as mentioned in https://groups.google.com/forum/?hl=enfromgroups=#!topic/muc.lists.freebsd.bugs/0yNFZVHClcI and https://bugs.launchpad.net/ubuntu/+source/netcat-openbsd/+bug/544935 that was causing people headaches. For me, this diff (which seems

Re: nc(1) shutdown(2) typo

2013-03-18 Thread Otto Moerbeek
On Mon, Mar 18, 2013 at 03:14:59PM +0100, Martin Pelikan wrote: Hi! Theo pointed out an issue with nc(1), as mentioned in https://groups.google.com/forum/?hl=enfromgroups=#!topic/muc.lists.freebsd.bugs/0yNFZVHClcI and

sudo documentation purports wrong loginclass functionality

2013-03-18 Thread Andres Perera
There are at least two instances in sudo documentation that lead to believe that `use_loginclass' and `sudo -c` behave differently than they do in the implementation WRT which of the target and calling users' loginclass gets applied. sudoers(5): 831 832 use_loginclassIf set,

[PATCH] changelist: track nginx config files

2013-03-18 Thread Ryan Kavanagh
Seeing that nginx is the web server recommended for new installations as of 5.2[0], nginx's config files should be tracked in changelist(5). This would mirror the current tracking of httpd's config files. The attached patch adds the nginx config files used by the default installation of nginx to

[PATCH] fix lies in netstart comment

2013-03-18 Thread Ryan Kavanagh
The file /etc/netstart contains a particularly misleading comment: # /etc/mygate, if it exists, contains the name of my gateway host # that name must be in /etc/hosts. This is patently false, since mygate(5) claims it must be an address and the code clearly contradicts the comment. This

Re: sudo documentation purports wrong loginclass functionality

2013-03-18 Thread Todd C. Miller
The documentation is correct, that line should be: set_loginclass(runas_pw ? runas_pw : sudo_user.pw); This was fixed some time ago upstream. I'll commit the fix. - todd