Re: traceroute(8): drop to _traceroute user

> It's not *that* expensive to have a dedicated user for this, so we > don't need to think about if it's a problem to share with ping(8) or > not. And we might be able to get rid of it again in the future. I am worried about the trend of creating shared users. And also, less worried about

Re: Modernize regress/libexec/ld.so/constructor

On Tue, Sep 27, 2016 at 12:00:55AM +0200, Mark Kettenis wrote: > > Date: Mon, 26 Sep 2016 23:54:46 +0200 > > From: Alexander Bluhm > > > > On Mon, Sep 26, 2016 at 11:39:29PM +0200, Mark Kettenis wrote: > > > Diff below modernizes the C++ code a bit such that the test

Re: Modernize regress/libexec/ld.so/constructor

> Date: Mon, 26 Sep 2016 23:54:46 +0200 > From: Alexander Bluhm > > On Mon, Sep 26, 2016 at 11:39:29PM +0200, Mark Kettenis wrote: > > Diff below modernizes the C++ code a bit such that the test case > > compiles again without warnings. It also uses CPPFLAGS instead of

Re: Modernize regress/libexec/ld.so/constructor

On Mon, Sep 26, 2016 at 11:39:29PM +0200, Mark Kettenis wrote: > Diff below modernizes the C++ code a bit such that the test case > compiles again without warnings. It also uses CPPFLAGS instead of > CFLAGS such that the c++ compiler actually stands a chance finding the > header files. > > Since

Re: util.c patch res_comp.c patch

On 16-09-26 21:42:09, Peter Hessler wrote: > On 2016 Sep 26 (Mon) at 14:31:04 -0500 (-0500), Edgar Pettijohn wrote: > :On 16-09-26 09:26:04, Gilles Chehade wrote: > :> On Sun, Sep 25, 2016 at 11:20:39AM -0500, Edgar Pettijohn wrote: > :> > In my testing it did not, but I could be wrong. > :> > >

Modernize regress/libexec/ld.so/constructor

Diff below modernizes the C++ code a bit such that the test case compiles again without warnings. It also uses CPPFLAGS instead of CFLAGS such that the c++ compiler actually stands a chance finding the header files. Since the tests succeed on amd64, and should succeed on other architectures, the

Re: send fewer router solicitations

On 2016/09/26 20:14, Florian Obser wrote: > On Wed, Sep 21, 2016 at 01:23:25PM +0100, Stuart Henderson wrote: > > > There's a problem with this: we lose the exponential backoff for the > > quick timer. Say you have v6 at home and enable autoconf on your laptop > > then move to a network without

Re: bgpd: local-as

If we do this, i think the as-path loop detection needs to also check for these additional ASes. Otherwise we create a nice loop when we get our own route from an ebgp neighbor with this as in the path. Peter Hessler(phess...@openbsd.org) on 2016.09.26 20:09:13 +0200: > We already have a local

Re: hide RT_TABLEID_MAX behind __BSD_VISIBLE

> From: Jeremie Courreges-Anglas > Date: Mon, 26 Sep 2016 22:19:54 +0200 > > Mark Kettenis writes: > > >> From: j...@wxcvbn.org (Jeremie Courreges-Anglas) > >> Date: Mon, 26 Sep 2016 21:13:24 +0200 > >> > >> AFAIK this is not a standard define, so it

Re: hide RT_TABLEID_MAX behind __BSD_VISIBLE

Mark Kettenis writes: >> From: j...@wxcvbn.org (Jeremie Courreges-Anglas) >> Date: Mon, 26 Sep 2016 21:13:24 +0200 >> >> AFAIK this is not a standard define, so it should be unconditionally >> reachable. mkr went fine. >> >> Thoughts? > > ok kettenis@, although

Re: send fewer router solicitations

On Wed, Sep 21, 2016 at 01:23:25PM +0100, Stuart Henderson wrote: > There's a problem with this: we lose the exponential backoff for the > quick timer. Say you have v6 at home and enable autoconf on your laptop > then move to a network without v6 - this results in you spamming the > network with

Re: hide RT_TABLEID_MAX behind __BSD_VISIBLE

> From: j...@wxcvbn.org (Jeremie Courreges-Anglas) > Date: Mon, 26 Sep 2016 21:13:24 +0200 > > AFAIK this is not a standard define, so it should be unconditionally > reachable. mkr went fine. > > Thoughts? ok kettenis@, although perhaps it makes sense to move this #define a bit further down

traceroute(8): drop to _traceroute user

It's not *that* expensive to have a dedicated user for this, so we don't need to think about if it's a problem to share with ping(8) or not. And we might be able to get rid of it again in the future. Pointed out by deraadt@ OK? diff --git etc/group etc/group index 7c050ef..e823310 100644 ---

Re: util.c patch res_comp.c patch

On 2016 Sep 26 (Mon) at 14:31:04 -0500 (-0500), Edgar Pettijohn wrote: :On 16-09-26 09:26:04, Gilles Chehade wrote: :> On Sun, Sep 25, 2016 at 11:20:39AM -0500, Edgar Pettijohn wrote: :> > In my testing it did not, but I could be wrong. :> > :> > On 16-09-25 17:56:42, Eric Faurot wrote: :> > > On

Re: splassert: sorwakeup: want 5 have 4

On 2016/09/26 20:30, Alexander Bluhm wrote: > On Mon, Sep 26, 2016 at 01:24:54PM -0400, David Hill wrote: > > On Mon, Sep 26, 2016 at 01:55:01PM +0100, Stuart Henderson wrote: > > > Seen about a dozen times on a box doing ospfd + ospf6d (for internal > > > routes), bgpd (for default route) +

Re: iked recvfromto flags

On Mon, 26 Sep 2016 18:33:43 +0200 j...@wxcvbn.org (Jeremie Courreges-Anglas) wrote: > Don't ignore the "flags" argument passed to recvfromto. Doesn't > matter for now in iked (0 is passed), but this kind of code tends to > be copied. > > ok? > ok vgross@ > > Index: util.c >

traceroute(8): drop to _ping user

like ping(8)... OK? diff --git traceroute.c traceroute.c index 5c53f53..b1fde9d 100644 --- traceroute.c +++ traceroute.c @@ -246,6 +246,7 @@ #include #include #include +#include #include #include #include @@ -303,6 +304,8 @@ int last_tos; void usage(void); +#define

Re: util.c patch res_comp.c patch

On 16-09-26 09:26:04, Gilles Chehade wrote: > On Sun, Sep 25, 2016 at 11:20:39AM -0500, Edgar Pettijohn wrote: > > In my testing it did not, but I could be wrong. > > > > On 16-09-25 17:56:42, Eric Faurot wrote: > > > On Sat, Sep 24, 2016 at 08:42:25PM -0500, Edgar Pettijohn wrote: > > > >

hide RT_TABLEID_MAX behind __BSD_VISIBLE

AFAIK this is not a standard define, so it should be unconditionally reachable. mkr went fine. Thoughts? Index: socket.h === RCS file: /cvs/src/sys/sys/socket.h,v retrieving revision 1.91 diff -u -p -p -u -r1.91 socket.h ---

Re: splassert: sorwakeup: want 5 have 4

On Mon, Sep 26, 2016 at 01:24:54PM -0400, David Hill wrote: > On Mon, Sep 26, 2016 at 01:55:01PM +0100, Stuart Henderson wrote: > > Seen about a dozen times on a box doing ospfd + ospf6d (for internal > > routes), bgpd (for default route) + isakmpd, shortly after startup > > after updating: > > >

bgpd: local-as

We already have a local AS saved per peer. Let's use it. This is very useful when one needs to change their local AS. " neighbor 192.0.2.1 { remote-as 65530 local-as 131000 } " OK? Index: parse.y === RCS file:

Re: read(2) on directories

On Mon, Sep 26, 2016 at 06:14:10PM +0200, Jeremie Courreges-Anglas wrote: > I haven't received a single test report, which is far from sufficient > for such a change. Even though I'm convinced that such a change would > be a benefit, I won't push this further. I am running this diff on my laptop

Re: splassert: sorwakeup: want 5 have 4

On Mon, Sep 26, 2016 at 01:55:01PM +0100, Stuart Henderson wrote: > Seen about a dozen times on a box doing ospfd + ospf6d (for internal > routes), bgpd (for default route) + isakmpd, shortly after startup > after updating: > > splassert: sorwakeup: want 5 have 4

switch(4): don't panic when destroying interfaces

switch(4) is currently not handling device removal when the interface is being destroyed. Example: # ifconfig switch0 up # ifconfig vether0 up # ifconfig switch0 add vether0 # ifconfig vether0 destroy # kernel panic here This diff fixes it by calling the switch port detach on the right time.

iked recvfromto flags

Don't ignore the "flags" argument passed to recvfromto. Doesn't matter for now in iked (0 is passed), but this kind of code tends to be copied. ok? Index: util.c === RCS file: /cvs/src/sbin/iked/util.c,v retrieving revision 1.31

Re: read(2) on directories

j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > >> "Todd C. Miller" writes: >> >>> From source inspection, Net and Free appear to allow read(2) of >>> dirs to succeed. However, since Linux, Mac OS X and Solaris

snmpd(8): teach how to fork+exec

Lets teach snmpd(8) how to fork+exec using the proc.c file from the latest switchd(8) diff. Note 1: I just tested the basic operations: startup and teardown. Note 2: the kill with close will be implemented in another diff with the ps_pid removal. ok? Index: proc.c

Re: snmpd(8): fix compilation warnings with DEBUG

> On 26.09.2016, at 15:37, Stuart Henderson wrote: > > On 2016/09/26 15:20, Rafael Zalamena wrote: >> This diff fixes two compiler warnings when compiling with DEBUG define. >> >> ok? > > I think this would be preferred: > I agree, this is the correct fix. OK reyk@ >

Re: snmpd(8): fix compilation warnings with DEBUG

On 2016/09/26 15:20, Rafael Zalamena wrote: > This diff fixes two compiler warnings when compiling with DEBUG define. > > ok? I think this would be preferred: Index: timer.c === RCS file: /cvs/src/usr.sbin/snmpd/timer.c,v

snmpd(8): fix compilation warnings with DEBUG

This diff fixes two compiler warnings when compiling with DEBUG define. ok? Index: timer.c === RCS file: /home/obsdcvs/src/usr.sbin/snmpd/timer.c,v retrieving revision 1.5 diff -u -p -r1.5 timer.c --- timer.c 27 Aug 2016

splassert: sorwakeup: want 5 have 4

Seen about a dozen times on a box doing ospfd + ospf6d (for internal routes), bgpd (for default route) + isakmpd, shortly after startup after updating: splassert: sorwakeup: want 5 have 4 Starting stack trace... splassert_check() at

Re: etherip alignment issues

On Mon, 26 Sep 2016, YASUOKA Masahiko wrote: > Hi, > > I could repeat the problem on my octeon. Tested the diff on it. > > ok? > > Use a new mbufs for a tunnel header to make sure it is aligned correctly. I have tested this latest diff and can confirm it also works on sparc64. Martin

move pf from RB macros to RBT code

the subject says it all. this is largely mechanical. ok? Index: if_pfsync.c === RCS file: /cvs/src/sys/net/if_pfsync.c,v retrieving revision 1.232 diff -u -p -r1.232 if_pfsync.c --- if_pfsync.c 21 Sep 2016 07:41:49 - 1.232

move nfs to RBT code

this switches nfs from using the RB macros to RBT functions. ok? Index: nfs_node.c === RCS file: /cvs/src/sys/nfs/nfs_node.c,v retrieving revision 1.64 diff -u -p -r1.64 nfs_node.c --- nfs_node.c 19 Mar 2016 12:04:16 -

Re: rasops.c: avoid calculating offset several times

On Mon, Sep 26, 2016 at 11:35:34AM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to avoid calculating offset several times in rasops.c. > This was done for a few functions already, but not all of them. > > Comments? OK? OK, that's more readable. > > Index:

rasops.c: avoid calculating offset several times

Hi tech@, Here is a diff to avoid calculating offset several times in rasops.c. This was done for a few functions already, but not all of them. Comments? OK? Index: sys/dev/rasops/rasops.c === RCS file:

Re: video(1): use _NET_WM_STATE_FULLSCREEN

Joerg Jung wrote: > >Am 26.09.2016 um 00:11 schrieb Dmitrij D. Czarkoff : > >>> The diff below fixes fullscreen mode on window managers that prevent >>> applications from resizing their windows. > >For example, which WM? For example i3. Isn't dwm affected