Re: minor typo in aldap.c comment

2016-10-21 Thread Philip Guenther
Committed. I'm surprised to see that function using strtoumax()...to parse a 2 character hex number. Mosquito, meet pile driver. Anyone using ypldapd who could improve that? Philip Guenther

minor typo in aldap.c comment

2016-10-21 Thread Rob Pierce
Index: aldap.c === RCS file: /cvs/src/usr.sbin/ypldap/aldap.c,v retrieving revision 1.32 diff -u -p -r1.32 aldap.c --- aldap.c 27 Apr 2016 10:53:27 - 1.32 +++ aldap.c 22 Oct 2016 02:42:13 - @@ -1198,7 +1198,7 @@

Re: per cpu mbuf statistics

2016-10-21 Thread David Gwynne
> On 22 Oct 2016, at 3:14 AM, Alexander Bluhm wrote: > > On Fri, Oct 21, 2016 at 05:02:49PM +1000, David Gwynne wrote: >> this uses the recently added percpu counter api as the backend for >> the mbstats collection. >> >> ok? > > OK bluhm@ cheers. > >> +mbstat

typo in the errata

2016-10-21 Thread Sergey Bronnikov
Hi, I believe it was a typo diff --git a/errata58.html b/errata58.html index 9cc93b7..aecabd9 100644 --- a/errata58.html +++ b/errata58.html @@ -176,7 +176,7 @@ A source code patch exists which remedies this problem. 009: RELIABILITY FIX: Dec 3, 2015 All architectures -A NULL pointer

Re: acpiec on acer aspire S7 with CURRENT

2016-10-21 Thread Mark Kettenis
> Date: Fri, 21 Oct 2016 10:37:08 +0300 > From: Paul Irofti > > On Tue, Oct 18, 2016 at 09:01:59PM -0700, Ilya Kaliman wrote: > > Thanks! Now everything seems to work. Minor tweak - maybe need extra > > newline after "acpiec0 at acpi0" > > New diff that fixes the printfs,

Re: log mutex

2016-10-21 Thread Alexander Bluhm
On Thu, Oct 20, 2016 at 09:26:16PM +0200, Mark Kettenis wrote: > I don't think putting a lock in msgbuf_putchar us a good idea. We > deliberately did not put a lock in kprintf() to make sure it can still > be used when we're in ddb without hitting a deadlock. Instead we put > the lock

Re: acpiec on acer aspire S7 with CURRENT

2016-10-21 Thread Ilya Kaliman
Works for me. Ok. acpiprt11 at acpi0: bus -1 (PEG1) acpiprt12 at acpi0: bus -1 (PEG2) acpiec0 at acpi0 acpiec0: Not running on HW-Reduced ACPI type 8 acpiec0: invalid resource #3 type 134 acpicpu0 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS acpicpu1 at

Re: pf_route pf_pdesc

2016-10-21 Thread Alexander Bluhm
On Fri, Oct 21, 2016 at 08:07:21PM +1300, Richard Procter wrote: > On 21/10/2016, at 2:03 AM, Alexander Bluhm wrote: > > On Thu, Oct 20, 2016 at 10:53:17AM +0200, Claudio Jeker wrote: > >>> Unfortunately pf_route() is called from pfsync which has no idea > >>> of packet descriptors. As I do not

Re: per cpu mbuf statistics

2016-10-21 Thread Alexander Bluhm
On Fri, Oct 21, 2016 at 05:02:49PM +1000, David Gwynne wrote: > this uses the recently added percpu counter api as the backend for > the mbstats collection. > > ok? OK bluhm@ > + mbstat = counters_realloc(mbstat, MBSTAT_COUNT, M_DEVBUF); There is no man page entry for counters_realloc()

Re: PF once rule should not trigger removal of parent anchor rule

2016-10-21 Thread Alexandr Nedvedicky
Hello Mike, (I'm putting tech@ back) > Or some other changes if expire has happened with the deferred removal in > the thread. What I saying is basically that the last fix I did for once > rules was tested in the scenario you've described. sorry I've messed up my description well enough to

Re: fix ILP32 switch(4) build

2016-10-21 Thread Jeremie Courreges-Anglas
Jonathan Gray writes: > /usr/src/sys/net/switchofp.c: In function 'swofp_ox_cmp_ether_addr': > /usr/src/sys/net/switchofp.c:1758: warning: integer constant is too large for > 'long' type > /usr/src/sys/net/switchofp.c: In function 'swofp_ox_match_ether_addr': >

fix ILP32 switch(4) build

2016-10-21 Thread Jonathan Gray
/usr/src/sys/net/switchofp.c: In function 'swofp_ox_cmp_ether_addr': /usr/src/sys/net/switchofp.c:1758: warning: integer constant is too large for 'long' type /usr/src/sys/net/switchofp.c: In function 'swofp_ox_match_ether_addr': /usr/src/sys/net/switchofp.c:2746: warning: integer constant is too

Re: snmpd(8): teach how to fork+exec

2016-10-21 Thread Rafael Zalamena
On Fri, Oct 21, 2016 at 01:26:36PM +0200, Jeremie Courreges-Anglas wrote: > Rafael Zalamena writes: > > On Fri, Oct 14, 2016 at 06:47:09PM +0200, Rafael Zalamena wrote: > >> On Mon, Sep 26, 2016 at 03:45:59PM +0200, Rafael Zalamena wrote: > >> ---snip--- > > > > I got

Re: snmpd source address

2016-10-21 Thread Jeremie Courreges-Anglas
Jeremie Courreges-Anglas writes: > Jeremie Courreges-Anglas writes: > >> Jeremie Courreges-Anglas writes: >> >>> j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: >>> SNMP uses UDP and snmpd listens on a single address. This means that

Re: snmpd(8): teach how to fork+exec

2016-10-21 Thread Jeremie Courreges-Anglas
Rafael Zalamena writes: > On Fri, Oct 14, 2016 at 06:47:09PM +0200, Rafael Zalamena wrote: >> On Mon, Sep 26, 2016 at 03:45:59PM +0200, Rafael Zalamena wrote: >> > Lets teach snmpd(8) how to fork+exec using the proc.c file from the latest >> > switchd(8) diff. >> > >> >

Re: snmpd(8): teach how to fork+exec

2016-10-21 Thread Rafael Zalamena
On Fri, Oct 14, 2016 at 06:47:09PM +0200, Rafael Zalamena wrote: > On Mon, Sep 26, 2016 at 03:45:59PM +0200, Rafael Zalamena wrote: > > Lets teach snmpd(8) how to fork+exec using the proc.c file from the latest > > switchd(8) diff. > > > > Note 1: I just tested the basic operations: startup and

Re: acpiec on acer aspire S7 with CURRENT

2016-10-21 Thread Paul Irofti
On Tue, Oct 18, 2016 at 09:01:59PM -0700, Ilya Kaliman wrote: > Thanks! Now everything seems to work. Minor tweak - maybe need extra > newline after "acpiec0 at acpi0" New diff that fixes the printfs, removes dead code (suggested by guenther@) and takes care of some small style(9) nits. OK?