Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Mike Larkin
On Wed, Oct 11, 2017 at 06:46:22AM +0200, Claudio Jeker wrote: > On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: > > Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed > > when creating new bridge and attaching interfaces to it. > > > > Comments? Ok? > > I don't

Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Claudio Jeker
On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: > Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed > when creating new bridge and attaching interfaces to it. > > Comments? Ok? I don't think it is a good idea to destroy and recreate bridge interfaces on every

Httpd support for internal redirects.

2017-10-10 Thread Ori Bernstein
My website generator is a little stupid at times. It generates files with .html suffixes, but urls without them. I worked around this with some redirects, but it never felt quite right doing an extra round trip. Therefore, I added internal redirects, processing the rewrite before responding to an

[PATCH] tests for vmd config parsing

2017-10-10 Thread Carlos Cardenas
This patch adds a set of tests for vmd config parsing. Comments? Ok? diff --git regress/usr.sbin/Makefile regress/usr.sbin/Makefile index 3912e794d4d..f19a656d45e 100644 --- regress/usr.sbin/Makefile +++ regress/usr.sbin/Makefile @@ -12,6 +12,7 @@ SUBDIR += relayd SUBDIR += snmpd SUBDIR +=

files.macppc: fix recursive dependency, parallel build race

2017-10-10 Thread Scott Cheloha
Hi, The attached patch eliminates a recursive dependency for locore.o in the resultant kernel Makefile. Without the patch you get this in the Makefile: locore.o: $S/arch/macppc/macppc/locore.o and these dependencies: # make -p | egrep '^locore.o' | sed 's/.*://' | tr ' ' '\n'

[PATCH] innovations.html - use singular nop instead of plural nops

2017-10-10 Thread Raf Czlonka
Hi all, As per the subject - nops sequences -> nop sequences. Regards, Raf Index: innovations.html === RCS file: /cvs/www/innovations.html,v retrieving revision 1.53 diff -u -p -r1.53 innovations.html --- innovations.html9 Oct

[PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Carlos Cardenas
Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed when creating new bridge and attaching interfaces to it. Comments? Ok? diff --git usr.sbin/vmd/priv.c usr.sbin/vmd/priv.c index ef42549d105..0190c049837 100644 --- usr.sbin/vmd/priv.c +++ usr.sbin/vmd/priv.c @@ -88,6 +88,7 @@

[PATCH 0/2] VMD: handle VM termination error conditions better

2017-10-10 Thread Carlos Cardenas
This patch series handles two error conditions when terminating a VM (via vmctl or from within the VM). Comments? Ok? -- 2.14.2

[PATCH 1/2] VMD: Prevent Disappearing VM from vmctl status

2017-10-10 Thread Carlos Cardenas
Remove terminate_vm/vm_remove logic from vmm_dispatch_parent. This logic is present in vmm_sighdlr when a VM process has signaled SIGCHLD for proper cleanup. diff --git usr.sbin/vmd/vmm.c usr.sbin/vmd/vmm.c index ccd7680b479..8cc1c15157a 100644 --- usr.sbin/vmd/vmm.c +++ usr.sbin/vmd/vmm.c @@

[PATCH 2/2] VMD: Handle vm-induced powerdown better

2017-10-10 Thread Carlos Cardenas
The VMD parent process didn't handle the case of a VM exiting with a non 0 return properly (i.e. EIO). diff --git usr.sbin/vmd/vmd.c usr.sbin/vmd/vmd.c index f1abc54d9a3..dcff6de0c0e 100644 --- usr.sbin/vmd/vmd.c +++ usr.sbin/vmd/vmd.c @@ -394,11 +394,14 @@ vmd_dispatch_vmm(int fd, struct

[Patch] man umb(4) added Sierra Wireless EM7345

2017-10-10 Thread Christoph R. Murauer
Hello ! Sorry if something is missing (to keep things shorter I did not add a dmesg) or wrong, but I am not a coder. Index: umb.4 === RCS file: /cvs/src/share/man/man4/umb.4,v retrieving revision 1.7 diff -u -p -r1.7 umb.4 --- umb.4

inteldrm: reduce i2c busy-wait to 100us

2017-10-10 Thread joshua stein
On my Kaby Lake laptop, running xbacklight or xrandr causes the audio and mouse cursor to pause briefly. This is because those codepaths do DRM operations that have to probe all of the available connectors, even disconnected ones. For HDMI, it does i2c operations that have to timeout. Reducing

Re: rw locks vs memory barriers and adaptive spinning

2017-10-10 Thread Mateusz Guzik
On Tue, Oct 10, 2017 at 10:15:48AM +0200, Martin Pieuchot wrote: > Hello Mateusz, > > On 09/10/17(Mon) 21:43, Mateusz Guzik wrote: > > I was looking at rw lock code out of curiosity and noticed you always do > > membar_enter which on MP-enabled amd64 kernel translates to mfence. > > This makes the

Re: Move 'struct kevent' storage to the stack

2017-10-10 Thread Alexander Bluhm
On Mon, Oct 09, 2017 at 11:48:56AM +0200, Martin Pieuchot wrote: > The diff below move 'struct kevent' storage to the stack. This is > the simplest way to make it mp-safe. > > This has been tested as part of a larger diff by many. I am currently running the regression tests with it. > Ok? OK

Re: kq_count earlier!

2017-10-10 Thread Alexander Bluhm
On Mon, Oct 09, 2017 at 12:15:46PM +0200, Martin Pieuchot wrote: > To prevent an infinite loop, threads looking for events inside > kqueue_scan(), insert a `marker' in the list. Such markers are > not accounted and they are removed from the list as soon as the > thread is finished or goes to

Re: ifioctl() cleanup

2017-10-10 Thread Alexander Bluhm
On Tue, Oct 10, 2017 at 03:55:30PM +0200, Martin Pieuchot wrote: > Similar diff without factorizing privilege checks, deraadt@ pointed out > it is too fragile. > > ok? OK bluhm@ > > Index: net/if.c > === > RCS file:

[patch] fix sys/dev/video.c debug printf formats

2017-10-10 Thread Dave Voutila
Hi tech, I was debugging some webcam issues and received compiler errors when building with the VIDEO_DEBUG option due to printf patterns in the expanded DPRINTF macro. See below patch for updating the formats in the DPRINTF usage. I've tested on i386 and amd64. Index: sys/dev/video.c

Re: pow() returns a negative result on loongson

2017-10-10 Thread Juan Francisco Cantero Hurtado
On Tue, Oct 10, 2017 at 12:08:06PM +, Visa Hankala wrote: > On Mon, Oct 09, 2017 at 10:39:47PM +0200, Juan Francisco Cantero Hurtado > wrote: > > Marc Feeley (Gambit Scheme) has been helping me with a bug on Gambit on > > Loongson. Apparently the bug is on our side. > > > > I've created this

Re: ifioctl() cleanup

2017-10-10 Thread Martin Pieuchot
On 09/10/17(Mon) 16:34, Martin Pieuchot wrote: > Here's a small cleanup to make it easy to push the NET_LOCK() further > down. > > Diff below factorize all ioctl requests need root privileges in one > switch () block. > > It moves SIOCIFAFATTACH/SIOCIFAFDETACH where it belongs, to the block >

Re: pow() returns a negative result on loongson

2017-10-10 Thread Visa Hankala
On Mon, Oct 09, 2017 at 10:39:47PM +0200, Juan Francisco Cantero Hurtado wrote: > Marc Feeley (Gambit Scheme) has been helping me with a bug on Gambit on > Loongson. Apparently the bug is on our side. > > I've created this little test based on his code: > > #include > #include > > int main()

Re: ifioctl() cleanup

2017-10-10 Thread Michele Curti
On Mon, Oct 09, 2017 at 04:34:38PM +0200, Martin Pieuchot wrote: > Here's a small cleanup to make it easy to push the NET_LOCK() further > down. > > Diff below factorize all ioctl requests need root privileges in one > switch () block. > > It moves SIOCIFAFATTACH/SIOCIFAFDETACH where it belongs,

Re: Additional media options for ix(4) [again]

2017-10-10 Thread Martin Pieuchot
On 16/08/17(Wed) 15:55, Mike Belopuhov wrote: > Hi, > > I haven't gotten any feedback on the following diff > but I think there's still hope. Please test. > > Original mail: > > I won't mind some broad testing of the following diff > which adds some additional media options to ix(4) from >

Re: rw locks vs memory barriers and adaptive spinning

2017-10-10 Thread Martin Pieuchot
Hello Mateusz, On 09/10/17(Mon) 21:43, Mateusz Guzik wrote: > I was looking at rw lock code out of curiosity and noticed you always do > membar_enter which on MP-enabled amd64 kernel translates to mfence. > This makes the entire business a little bit slower. > > Interestingly you already have

Re: pow() returns a negative result on loongson

2017-10-10 Thread Miod Vallat
> My first thought would on Loongson would be softfloat bug. > But I am not 100% sure it (still) uses softfloat. Loongson has never used softfloat. But all mips ports embed the softfloat code in order to perform tricky computations the FPU won't perform (mostly edge cases involving denormals and

Re: ctags(1): missing space between tag and line number

2017-10-10 Thread Anton Lindqvist
Ping On Thu, Oct 05, 2017 at 10:41:09AM +0200, Anton Lindqvist wrote: > Hi, > Running `ctags -x` on a file including a tag which satisfies strlen(tag) > >= 16 and line number >= 1000 corrupts the output since there's no space > between the tag and line number. Therefore, add a space between them

Error compiling kernel with SR_DEBUG

2017-10-10 Thread Zé Loff
Dear all While compiling amd64 -current with "option SR_DEBUG" the error below comes up. Steps leading to this were exactly those presented on config(8)'s first example. The only change from GENERIC is adding SR_DEBUG. Apologies in advance for any PEBKAC, it's the first time I'm compiling bsd

Re: armv7/panda usb eth addr wondering

2017-10-10 Thread Mark Kettenis
> Date: Tue, 10 Oct 2017 06:32:58 +0300 > From: Artturi Alm > > Hi, > > i've been bothered by this: > smsc0 at uhub1 port 1 configuration 1 interface 0 "Standard Microsystems > SMSC9512/14" rev 2.00/2.00 addr 3 > smsc0: address ff:ff:ff:ff:ff:ff > > that does happen no

Re: efiboot: Restore GOP mode on SetMode() failure

2017-10-10 Thread Klemens Nanni
On Tue, Oct 10, 2017 at 02:56:26AM +, YASUOKA Masahiko wrote: > On Sat, 7 Oct 2017 09:24:20 +0200 > Klemens Nanni wrote: > > On Sat, Oct 07, 2017 at 01:15:40AM +, YASUOKA Masahiko wrote: > >> > See my updated diff for reusing the gopi struct, please. > >> > >> ok, but