Re: prevent bgpd from starting when control socket already used

2018-11-11 Thread Claudio Jeker
On Sun, Nov 11, 2018 at 04:40:54PM -0700, Theo de Raadt wrote: > Makes sense to me, I suppose. > > Isn't another approach to swap the opening of the sockets? > > Or why does failure to control :179 sockets not stop startup? Because you can change them during reload and if they are incorrect for

Re: /usr/share/calendar/calendar.christian - two entries for "First Sunday of Advent (4th Sunday before Christmas)"

2018-11-11 Thread Jason McIntyre
On Sun, Nov 11, 2018 at 11:03:35PM +, Raf Czlonka wrote: > It's that magical time of the year again :^) > > Anyone? > > R. > morning. i suspect either the intent was to cover all cases, or one was added without the other being removed by mistake. unfortunately calendar doesn;t handle such

Re: Sync calendars.judaic with reality

2018-11-11 Thread Jason McIntyre
On Sun, Nov 11, 2018 at 07:36:55PM -0500, Brian Callahan wrote: > Hi tech -- > > Reminded by the recent email to tech@ about calendar.christian, I > took a look at syncing calendar.judaic. > > This diff does the following: > 1. Sync the holiday days that are not connected to Pesach, which on >

Re: tap(4) minor number too large

2018-11-11 Thread Philip Guenther
On Sun, Nov 11, 2018 at 10:03 PM David Gwynne wrote: ... > so like this? > ... > --- if_tun.c24 Feb 2018 07:20:04 - 1.181 > +++ if_tun.c12 Nov 2018 06:02:51 - > @@ -193,6 +193,9 @@ tun_create(struct if_clone *ifc, int uni > struct tun_softc*tp; >

Re: tap(4) minor number too large

2018-11-11 Thread David Gwynne
On Sun, Nov 11, 2018 at 10:55:06PM -0700, Theo de Raadt wrote: > Philip Guenther wrote: > > > On Sun, Nov 11, 2018 at 9:45 PM David Gwynne wrote: > > > > > If you can trick someone into implementing 64bit device ids you can have > > > more than your 16 millionth tap device. > > > > > > >

Re: tap(4) minor number too large

2018-11-11 Thread Theo de Raadt
Philip Guenther wrote: > On Sun, Nov 11, 2018 at 9:45 PM David Gwynne wrote: > > > If you can trick someone into implementing 64bit device ids you can have > > more than your 16 millionth tap device. > > > > Hhahahahahahahhahahahahah. > > That would involve rolling six syscall numbers, not

Re: tap(4) minor number too large

2018-11-11 Thread Philip Guenther
On Sun, Nov 11, 2018 at 9:45 PM David Gwynne wrote: > If you can trick someone into implementing 64bit device ids you can have > more than your 16 millionth tap device. > Hhahahahahahahhahahahahah. That would involve rolling six syscall numbers, not to mention handling the 64bit padding in one

Re: tap(4) minor number too large

2018-11-11 Thread David Gwynne
On Sun, Nov 11, 2018 at 08:52:39PM -0800, Greg Steuck wrote: > I was playing with `ifconfig tapN create`. It appears some devices can be > created outside the useful range. E.g. > > % for i in {23..25}; do \ >dev=tap$(printf "%d" $((1 << $i))) && \ >doas ifconfig $dev destroy ; \ >

tap(4) minor number too large

2018-11-11 Thread Greg Steuck
I was playing with `ifconfig tapN create`. It appears some devices can be created outside the useful range. E.g. % for i in {23..25}; do \ dev=tap$(printf "%d" $((1 << $i))) && \ doas ifconfig $dev destroy ; \ doas ifconfig $dev create && \ ifconfig $dev && \ (cd /dev && doas

Sync calendars.judaic with reality

2018-11-11 Thread Brian Callahan
Hi tech -- Reminded by the recent email to tech@ about calendar.christian, I took a look at syncing calendar.judaic. This diff does the following: 1. Sync the holiday days that are not connected to Pesach, which on our calendar is Chanukah, Fast of 10 Tevet, and Yom Yerushalayim. 2. Add the

Re: BLAKE2 for libcrypto

2018-11-11 Thread David Gwynne
On Sun, Nov 04, 2018 at 03:05:04AM -0700, Theo Buehler wrote: > On Thu, Oct 18, 2018 at 01:50:36PM +1000, David Gwynne wrote: > > By BLAKE2, I actually mean just BLAKE2s and BLAKE2b. It doesn't > > include BLAKE2sp, BLAKE2bp, or BLAKE2x. > > > > Like other hashes it is exposed via it's own API,

Re: prevent bgpd from starting when control socket already used

2018-11-11 Thread Theo de Raadt
Makes sense to me, I suppose. Isn't another approach to swap the opening of the sockets? Or why does failure to control :179 sockets not stop startup? > I heard from two devs that started a 2nd bgpd by accident (forgot -n for > a config check) which then caused downtime. > > Below diff adds a

Re: /usr/share/calendar/calendar.christian - two entries for "First Sunday of Advent (4th Sunday before Christmas)"

2018-11-11 Thread Raf Czlonka
It's that magical time of the year again :^) Anyone? R. On Sun, Nov 12, 2017 at 08:11:04AM GMT, Raf Czlonka wrote: > Hi all, > > I've just noticed something strange in the > /usr/share/calendar/calendar.christian file, namely: > > 11/SunLast First Sunday of Advent (4th Sunday

Re: pcidevs update for VIA HD Audio device

2018-11-11 Thread Frederic Cambus
On Sun, Nov 11, 2018 at 07:54:12PM +0100, Frederic Cambus wrote: > > Add ID for a VIA HD Audio device found on my HP t5570 Thin Client. > > > > While there, update URL for the vendor ID search engine. > > > > Comments? OK? > > Anyone willing to OK this? Thanks! Please disregard previous mail.

Re: prevent bgpd from starting when control socket already used

2018-11-11 Thread Stuart Henderson
On 2018/11/11 22:45, Job Snijders wrote: > Shouldnt we already bomb out at the following? > > cannot bind to 0.0.0.0:179: Address already in use > cannot bind to [::]:179: Address already in use > > In any regard, I agree with the functionality proposed. No strong opinion > on the diff itself.

Re: prevent bgpd from starting when control socket already used

2018-11-11 Thread Job Snijders
Shouldnt we already bomb out at the following? cannot bind to 0.0.0.0:179: Address already in use cannot bind to [::]:179: Address already in use In any regard, I agree with the functionality proposed. No strong opinion on the diff itself. Kind regards, Job On Sun, Nov 11, 2018 at 22:35 Remi

prevent bgpd from starting when control socket already used

2018-11-11 Thread Remi Locherer
Hi, I heard from two devs that started a 2nd bgpd by accident (forgot -n for a config check) which then caused downtime. Below diff adds a check to bgpd similar to the one we have now in ospfd and ospf6d: if another process is listening on the control socket bgpd exits. The situation is a bit

xenocara tarball

2018-11-11 Thread Robert Urban
Hello, until v6.2, xenocara.tar.gz contained a hierarchy whose top node was "xenocara", which meant that it should be unpacked with CWD=/usr. Since v6.3 the "xenocara" top node is gone, which means, if one follows these FAQ instructions: > $ *cd /usr/src* > $ *tar xzf /tmp/src.tar.gz* > $ *tar

Re: NTPd server using DVB-T as clocksource

2018-11-11 Thread j
Lars Schotte [l...@gustik.eu] wrote: Now, I do not like all this, that's why I ordered vk-172 gmouse g-mouse USB GPS/GLONASS USB over amazon and hope I can use that in combination with some Raspberry PI as NTPd clocksource, as I saw some ppl doing. These usually come with a (usb-) serial

Re: pcidevs update for VIA HD Audio device

2018-11-11 Thread Frederic Cambus
On Thu, Nov 01, 2018 at 11:07:20PM +0100, Frederic Cambus wrote: > Add ID for a VIA HD Audio device found on my HP t5570 Thin Client. > > While there, update URL for the vendor ID search engine. > > Comments? OK? Anyone willing to OK this? Thanks!

Re: kernel page fault in vm_teardown

2018-11-11 Thread Greg Steuck
Hi Mike, > Known issue. And the parameters in the list aren't right (there needs to be > something added to clang/llvm to support reading the params properly). This is happening often enough to create toil for running syzkaller with VMM. Is there a workaround that you know of? As things stand I

Re: [PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Mischa Peters
> On 11 Nov 2018, at 18:43, Claudio Jeker wrote: > >> On Sun, Nov 11, 2018 at 06:32:53PM +0100, Bruno Flueckiger wrote: >>> On 11.11.18 15:29, Florian Obser wrote: On Sun, Nov 11, 2018 at 01:46:06PM +0100, Sebastian Benoit wrote: Bruno Flueckiger(inform...@gmx.net) on 2018.11.11

Re: [PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Claudio Jeker
On Sun, Nov 11, 2018 at 06:32:53PM +0100, Bruno Flueckiger wrote: > On 11.11.18 15:29, Florian Obser wrote: > > On Sun, Nov 11, 2018 at 01:46:06PM +0100, Sebastian Benoit wrote: > > > Bruno Flueckiger(inform...@gmx.net) on 2018.11.11 10:31:34 +0100: > > > > Hi > > > > > > > > When I run httpd(8)

Re: [PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Bruno Flueckiger
On 11.11.18 15:29, Florian Obser wrote: > On Sun, Nov 11, 2018 at 01:46:06PM +0100, Sebastian Benoit wrote: > > Bruno Flueckiger(inform...@gmx.net) on 2018.11.11 10:31:34 +0100: > > > Hi > > > > > > When I run httpd(8) behind relayd(8) the access log of httpd contains > > > the IP address of

xidle: parse options once, simplify code

2018-11-11 Thread Klemens Nanni
There's no point in parsing `-display' separately, just do it once and simplify the code while here. This addresses two of cheloha's comments from my strtonum diff. Feedback? OK? Index: xidle.c === RCS file:

Re: xidle: do not close stdout/err, error on failure, execvp(3)

2018-11-11 Thread Klemens Nanni
On Sat, Nov 03, 2018 at 09:01:33PM +0100, Klemens Nanni wrote: > Closing stdin makes sense, but I still want to see error messages from > the program I'm running. Since arbitrary progams can be run, keep both > stdout and stderr open so users get a chance to actually notice program > failure or

Re: xidle: use strtonum(3), zap NOTREACHED

2018-11-11 Thread Klemens Nanni
On Sun, Nov 11, 2018 at 08:18:38AM -0600, Scott Cheloha wrote: > This should print a warning and then _exit(2), not exit(3). > I know you're "already here" but I might put that in a different > patch. Don't know if it "fits" with the other patch content. > > Choice is yours, though maybe someone

Re: lockf: consistent use of new debug macro

2018-11-11 Thread Todd C. Miller
On Sat, 10 Nov 2018 18:43:11 +0100, Anton Lindqvist wrote: > Make use of the new LFPRINT() debug macro. OK millert@ - todd

Re: ripd.conf: allow interface without { }

2018-11-11 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.11.11 14:57:05 +0100: > On Sun, Nov 11, 2018 at 09:48:38AM +0100, Claudio Jeker wrote: > > On Sat, Nov 10, 2018 at 09:17:57PM +0100, Remi Locherer wrote: > > > Hi, > > > > > > ripd wants curly braces for interface blocks even if no parameters are > > >

Re: [PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Florian Obser
On Sun, Nov 11, 2018 at 01:46:06PM +0100, Sebastian Benoit wrote: > Bruno Flueckiger(inform...@gmx.net) on 2018.11.11 10:31:34 +0100: > > Hi > > > > When I run httpd(8) behind relayd(8) the access log of httpd contains > > the IP address of relayd, but not the IP address of the client. I've > >

Re: xidle: use strtonum(3), zap NOTREACHED

2018-11-11 Thread Scott Cheloha
On Sun, Nov 11, 2018 at 12:24:51PM +0100, Klemens Nanni wrote: > On Sat, Nov 03, 2018 at 08:41:22PM +0100, Klemens Nanni wrote: > > Simpler and without ugly `goto fail'. `value.addr` is typed XPointer > > which is just a char pointer. > > > > Zap linter hints while here. > Bump. Comments

Re: ripd.conf: allow interface without { }

2018-11-11 Thread Remi Locherer
On Sun, Nov 11, 2018 at 09:48:38AM +0100, Claudio Jeker wrote: > On Sat, Nov 10, 2018 at 09:17:57PM +0100, Remi Locherer wrote: > > Hi, > > > > ripd wants curly braces for interface blocks even if no parameters are > > specified. This is inconsistent with other daemons and a bit annoying. > > >

Re: [PATCH] Fix broken bus voltage setting in sdhc

2018-11-11 Thread Ben Pye
On Sat, Nov 10, 2018 at 03:45:41PM +, Ben Pye wrote: > On Sat, Nov 10, 2018 at 06:30:37AM +, Ben Pye wrote: > > On Wed, Nov 07, 2018 at 05:33:13PM +0100, Mark Kettenis wrote: > > > > From: Ben Pye > > > > Content-Type: text/plain; charset="utf-8" > > > > > > > > I have been attempting to

make prio fields in encap protocols configurable

2018-11-11 Thread David Gwynne
a lot of encap protocols have fields to carry a priority or class of service associated with the relevant packet. some concrete examples are the dot1q priority field in vlan(4) headers, the now repurposed exp field in mpls shims, and the tos/traffic class/dscp field in ip headers around gre, gif,

sdmmc(4) support for suspend/resume with eMMC devices

2018-11-11 Thread Ben Pye
Hey all, In my quest for better OpenBSD support on my Chromebook 13 I have found that sdmmc(4)'s current strategy for suspend/resume only really works for removable storage. Upon a suspend it marks the device as dying, and upon resume will detach the card and re-scan the bus. This makes sense for

libpcap: add basic MPLS support

2018-11-11 Thread Denis Fondras
(long line in the previous diff) Add basic MPLS support in libpcap. Index: gencode.c === RCS file: /cvs/src/lib/libpcap/gencode.c,v retrieving revision 1.51 diff -u -p -r1.51 gencode.c --- gencode.c 10 Nov 2018 10:17:37 -

libpcap: add basic MPLS support

2018-11-11 Thread Denis Fondras
Add basic MPLS support in libpcap. Index: gencode.c === RCS file: /cvs/src/lib/libpcap/gencode.c,v retrieving revision 1.51 diff -u -p -r1.51 gencode.c --- gencode.c 10 Nov 2018 10:17:37 - 1.51 +++ gencode.c 11 Nov 2018

Re: [PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Sebastian Benoit
Bruno Flueckiger(inform...@gmx.net) on 2018.11.11 10:31:34 +0100: > Hi > > When I run httpd(8) behind relayd(8) the access log of httpd contains > the IP address of relayd, but not the IP address of the client. I've > tried to match the logs of relayd(8) and httpd(8) using some scripting > and

xidle: do not bzero global zero initialized struct

2018-11-11 Thread Klemens Nanni
OK? Index: xidle.c === RCS file: /cvs/xenocara/app/xidle/xidle.c,v retrieving revision 1.6 diff -u -p -r1.6 xidle.c --- xidle.c 6 Sep 2018 07:21:34 - 1.6 +++ xidle.c 11 Nov 2018 11:29:58 - @@ -344,9 +344,6 @@

Re: xidle: use strtonum(3), zap NOTREACHED

2018-11-11 Thread Klemens Nanni
On Sat, Nov 03, 2018 at 08:41:22PM +0100, Klemens Nanni wrote: > Simpler and without ugly `goto fail'. `value.addr` is typed XPointer > which is just a char pointer. > > Zap linter hints while here. Bump. I have a few small/simple changes that I want to get in before eventually sending an

Re: tcpdump: unbreak VLAN filtering

2018-11-11 Thread Denis Fondras
On Sat, Nov 10, 2018 at 02:01:56PM +0100, Klemens Nanni wrote: > On Sat, Nov 10, 2018 at 10:05:18AM +0100, Denis Fondras wrote: > > 'tcpdump vlan $vlan_number' will not return anything if priority is not 0. > > > > Fix that by not comparing vlan number against priority. > > Also deny usage of

[PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Bruno Flueckiger
Hi When I run httpd(8) behind relayd(8) the access log of httpd contains the IP address of relayd, but not the IP address of the client. I've tried to match the logs of relayd(8) and httpd(8) using some scripting and failed. So I've written a patch for httpd(8). It stores the content of the

Re: ripd.conf: allow interface without { }

2018-11-11 Thread Claudio Jeker
On Sat, Nov 10, 2018 at 09:17:57PM +0100, Remi Locherer wrote: > Hi, > > ripd wants curly braces for interface blocks even if no parameters are > specified. This is inconsistent with other daemons and a bit annoying. > > Below diff makes ripd accepting > interface if0 > without { }