Re: libevent: Protect integer multiplications (min_heap)

2019-04-16 Thread Theo de Raadt
Theo de Raadt wrote: > Reading this min_heap.h code for the first time, I shuddered because it > reminded me of the exploit mitigation mechanism in openssl which prevent > heartbleed from being exploitable in the presence of our fine otto > malloc. Oops, this is more correct: Reading this

Re: libevent: Protect integer multiplications (min_heap)

2019-04-16 Thread Theo de Raadt
Reading this min_heap.h code for the first time, I shuddered because it reminded me of the exploit mitigation mechanism in openssl which prevent heartbleed from being exploitable in the presence of our fine otto malloc. It is a deferred deallocation mechanism *precisely* what prevents bugs from

Re: update to PF pfctl(8) and pf.conf(5) manpages

2019-04-16 Thread Ingo Schwarze
Hi Alexandr, Alexandr Nedvedicky wrote on Wed, Apr 17, 2019 at 12:09:10AM +0200: > my oracle fellow pointed out [1] a PF documentation can be improved > a bit, when it comes to newly introduced 'pfctl -FR' (a reset flush > modifier). I've decided to make manpage changes in separate diff as > I

Re: iked(8): add support for IKEv2 Message Fragmentation

2019-04-16 Thread Tim Stewart
Tim Stewart writes: > On 3/30/19 3:11 PM, Tobias Heider wrote: >> Hi Stuart, >> >> I'm glad to see people are using this. >> There's some smaller fixes that I haven't sent to the list yet, so >> probably I'll send an updated diff on monday. > > I plan to start using this patch this week, likely

libevent: Protect integer multiplications (min_heap)

2019-04-16 Thread Tobias Stoeckmann
I would like to protect min_heap_push against integer overflows, which could either be triggered on a 64 bit system with massive amounts of RAM (to overflow s->n) or on a 32 bit system with tight memory layout (overflowing a * sizeof *p). Both cases are basically not possible to be triggered, but

enable pfctl to flush all rules and tables

2019-04-16 Thread Alexandr Nedvedicky
Hello, this is a fairly large change to pfctl, which allows PF administrator to purge all anchors from PF driver. Consider ruleset as follows: lumpy# pfctl -a '*' -sr pass all flags S/SA anchor "foo" all { anchor "inbound" from any to { match in on any inet from

update to PF pfctl(8) and pf.conf(5) manpages

2019-04-16 Thread Alexandr Nedvedicky
Hello, my oracle fellow pointed out [1] a PF documentation can be improved a bit, when it comes to newly introduced 'pfctl -FR' (a reset flush modifier). I've decided to make manpage changes in separate diff as I expect some discussion on how much detailed the manpage should be. The diff here

Re: fsync(2) and I/O errors

2019-04-16 Thread Ted Unangst
Oh, right, I reworded it slightly, but I think this is something we should note. Index: fsync.2 === RCS file: /home/cvs/src/lib/libc/sys/fsync.2,v retrieving revision 1.14 diff -u -p -r1.14 fsync.2 --- fsync.2 10 Sep 2015

Re: fsync(2) and I/O errors

2019-04-16 Thread Maximilian Lorlacks
Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Saturday, February 16, 2019 7:40 AM, Maximilian Lorlacks wrote: > ‐‐‐ Original Message ‐‐‐ > On Thursday, January 31, 2019 11:31 PM, Alexander Bluhm > alexander.bl...@gmx.net wrote: > > > On Thu, Jan 31, 2019

Re: ppb(4): free dynamically allocated bus

2019-04-16 Thread Mark Kettenis
> Date: Tue, 16 Apr 2019 16:39:42 +0200 > From: Patrick Wildt > > On Tue, Apr 16, 2019 at 03:23:37PM +0200, Mark Kettenis wrote: > > > Date: Mon, 15 Apr 2019 08:50:04 +0200 > > > From: Patrick Wildt > > > Content-Type: text/plain; charset="utf-8" > > > Content-Disposition: inline > > > > > >

Re: ppb(4): free dynamically allocated bus

2019-04-16 Thread Patrick Wildt
On Tue, Apr 16, 2019 at 03:23:37PM +0200, Mark Kettenis wrote: > > Date: Mon, 15 Apr 2019 08:50:04 +0200 > > From: Patrick Wildt > > Content-Type: text/plain; charset="utf-8" > > Content-Disposition: inline > > > > Hi, > > > > with kettenis' change from 2015(?) we are able to configure ppb(4)'s

Re: ppb(4): free dynamically allocated bus

2019-04-16 Thread Mark Kettenis
> Date: Mon, 15 Apr 2019 08:50:04 +0200 > From: Patrick Wildt > Content-Type: text/plain; charset="utf-8" > Content-Disposition: inline > > Hi, > > with kettenis' change from 2015(?) we are able to configure ppb(4)'s > that are hotplugged. I think on detach we should make sure to free the >