Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-02 Thread Andreas Kusalananda Kähäri
On Sun, Apr 02, 2023 at 10:39:00AM +0200, Kusalananda Kähäri wrote: > On Sat, Apr 01, 2023 at 08:18:56AM +0200, Solène Rapenne wrote: > > Le Fri, 31 Mar 2023 19:40:45 -0700, > > Jared Harper a écrit : > > > > > I have put together a patch that adds -executable, -readable, and > > > -writable to

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-02 Thread Andreas Kusalananda Kähäri
On Sat, Apr 01, 2023 at 08:18:56AM +0200, Solène Rapenne wrote: > Le Fri, 31 Mar 2023 19:40:45 -0700, > Jared Harper a écrit : > > > I have put together a patch that adds -executable, -readable, and > > -writable to /usr/bin/find. > > > > When I first started working on this patch, I

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-02 Thread Anthony J. Bentley
Stuart Henderson writes: > On 2023/04/01 11:27, Jared Harper wrote: > > For some reason I haven't received the email from Solène (even after > > requesting it re-sent on lists.openbsd.org; nor is it in spam; I will > > look further into this issue), so I'm adding my reply in-line here: > >

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-02 Thread Stuart Henderson
On 2023/03/31 19:40, Jared Harper wrote: > However, I had some difficulty finding the source of access(2) so I could not > vet by assumptions. see sys_access() in sys/kern/vfs_syscalls.c

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-02 Thread Stuart Henderson
On 2023/04/01 11:27, Jared Harper wrote: > For some reason I haven't received the email from Solène (even after > requesting it re-sent on lists.openbsd.org; nor is it in spam; I will > look further into this issue), so I'm adding my reply in-line here: Solène's domain publishes a DMARC p=reject

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Steffen Nurpmeso
Jared Harper wrote in : |On Sat, Apr 1, 2023 at 12:06 AM Theo Buehler wrote: ... |I'm not sure these are equivalent. My (limited?) understanding is these |examples are checking whether the file's owner has the specified |permissions. | |The intention for my patch is to return true if the

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Jared Harper
On Sat, Apr 1, 2023 at 12:06 AM Theo Buehler wrote: > > While I agree with Solène that we don't necessarily want or need this > patch, I think it is nicely done. I myself don't find the -perm primary > very intuitive and I find its manual hard to decipher, so your patch > would save me a few

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Theo Buehler
On Fri, Mar 31, 2023 at 07:40:45PM -0700, Jared Harper wrote: > I have put together a patch that adds -executable, -readable, and > -writable to /usr/bin/find. While I agree with Solène that we don't necessarily want or need this patch, I think it is nicely done. I myself don't find the -perm

Re: [PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-04-01 Thread Solène Rapenne
Le Fri, 31 Mar 2023 19:40:45 -0700, Jared Harper a écrit : > I have put together a patch that adds -executable, -readable, and > -writable to /usr/bin/find. > > When I first started working on this patch, I implemented the access > check by checking the stat of the file like so: > this

[PATCH] Add -executable, -readable, and -writable options to /usr/bin/find

2023-03-31 Thread Jared Harper
I have put together a patch that adds -executable, -readable, and -writable to /usr/bin/find. When I first started working on this patch, I implemented the access check by checking the stat of the file like so: int is_permission(const FTSENT *entry, mode_t umode, mode_t gmode,