Re: [PATCH| zero a freed pointer passed in a struct, to prevent reuse after free

2014-04-23 Thread Dirk Engling
On 23.04.14 07:42, patrick keshishian wrote: Why not kill the 'if (ret-name != NULL)' check while at it? I am currently working on a patch that removes all superflous NULL checks before every free function throughout libressl. There will be a single commit fixing this. erdgeist

[PATCH| zero a freed pointer passed in a struct, to prevent reuse after free

2014-04-22 Thread Dirk Engling
Index: x_x509.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/x_x509.c,v retrieving revision 1.12 diff -u -r1.12 x_x509.c --- x_x509.c18 Apr 2014 11:20:32 - 1.12 +++ x_x509.c23 Apr 2014 01:54:03 - @@ -125,6

Re: [PATCH| zero a freed pointer passed in a struct, to prevent reuse after free

2014-04-22 Thread Bob Beck
Yes, ok committed On Wed, Apr 23, 2014 at 03:55:19AM +0200, Dirk Engling wrote: Index: x_x509.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/x_x509.c,v retrieving revision 1.12 diff -u -r1.12 x_x509.c --- x_x509.c 18

Re: [PATCH| zero a freed pointer passed in a struct, to prevent reuse after free

2014-04-22 Thread patrick keshishian
On Tue, Apr 22, 2014 at 10:33:55PM -0600, Bob Beck wrote: Yes, ok committed On Wed, Apr 23, 2014 at 03:55:19AM +0200, Dirk Engling wrote: Index: x_x509.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/x_x509.c,v