Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Theo de Raadt
Jimmy Hess wrote: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > > I don't think these are "redundant quotes" but rather ditto marks: > > The ditto mark and the quote character are not the same character, > and the comments are nonsensical since

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Ingo Schwarze
Hi, Jimmy Hess wrote on Fri, Apr 20, 2018 at 06:53:44AM -0500: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: >> I don't think these are "redundant quotes" but rather ditto marks: > The ditto mark and the quote character are not the same character, > and the

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Landry Breuil
On Fri, Apr 20, 2018 at 06:53:44AM -0500, Jimmy Hess wrote: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > > I don't think these are "redundant quotes" but rather ditto marks: > > The ditto mark and the quote character are not the same character, > and the comments

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Jimmy Hess
On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > I don't think these are "redundant quotes" but rather ditto marks: The ditto mark and the quote character are not the same character, and the comments are nonsensical since they used the wrong character. If the writer

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Nan Xiao
Hi Theo, I am very sorry for this wrong modification! Thanks! Best Regards Nan Xiao On Fri, Apr 20, 2018 at 4:57 PM, Theo Buehler wrote: > I don't think these are "redundant quotes" but rather ditto marks: > > https://en.wikipedia.org/wiki/Ditto_mark > > this is quite clear

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Theo Buehler
I don't think these are "redundant quotes" but rather ditto marks: https://en.wikipedia.org/wiki/Ditto_mark this is quite clear here, for example: > u_int64_t p_uru_nvcsw; /* LONG: voluntary context switches. */ > - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */ >

[patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Nan Xiao
Hi tech@, FYI, thanks! Index: resource.h === RCS file: /cvs/src/sys/sys/resource.h,v retrieving revision 1.14 diff -u -p -r1.14 resource.h --- resource.h 25 Oct 2013 04:42:48 - 1.14 +++ resource.h 20 Apr 2018 08:43:10