Re: Fix possible fault in sysctl_file()

2017-06-26 Thread Martin Pieuchot
On 20/06/17(Tue) 13:51, Gerhard Roth wrote: > Hi, > > file pointer may be incompletely initialized after falloc(). For example, > sys_socket() initializes 'f_flag', 'f_type', and 'f_ops' but may sleep > then in socreate() before assigning 'f_data'. > > That is why there is the FIF_LARVAL flag,

Re: Fix possible fault in sysctl_file()

2017-06-20 Thread Alexander Bluhm
On Tue, Jun 20, 2017 at 01:51:07PM +0200, Gerhard Roth wrote: > The fix is rather straightforward. OK bluhm@ > Index: sys/kern/kern_sysctl.c > === > RCS file: /cvs/src/sys/kern/kern_sysctl.c,v > retrieving revision 1.328 > diff -u

Fix possible fault in sysctl_file()

2017-06-20 Thread Gerhard Roth
Hi, file pointer may be incompletely initialized after falloc(). For example, sys_socket() initializes 'f_flag', 'f_type', and 'f_ops' but may sleep then in socreate() before assigning 'f_data'. That is why there is the FIF_LARVAL flag, that is check by the macro FILE_IS_USABLE(). Of the three