Re: Most of the splnet() in /sys/net are wrong

2017-05-15 Thread Alexander Bluhm
On Mon, May 15, 2017 at 03:06:08PM +0200, Martin Pieuchot wrote: > They all need to be audited and possibly changed to a solution that work > with the NET_LOCK(). Just saying, enc(4) is a nightmare. > > Here's a diff fro gre(4). The 'softnet' iterates over ``gre_softc_list'' > so we need to

Most of the splnet() in /sys/net are wrong

2017-05-15 Thread Martin Pieuchot
They all need to be audited and possibly changed to a solution that work with the NET_LOCK(). Just saying, enc(4) is a nightmare. Here's a diff fro gre(4). The 'softnet' iterates over ``gre_softc_list'' so we need to make sure it isn't modified when this happen. We need the NET_LOCK() were