Re: Question and regression test for strftime adn wcsftime

2014-04-29 Thread Vladimir Támara Patiño
On Tue, Apr 22, 2014 at 11:43:21PM +0200, Stefan Sperling wrote: I think a better step forward for LC_TIME support would be to focus on nl_langinfo() first and make it return locale-specific data for LC_TIME. The functions you're looking at are icing on the cake. We should be looking at adding

Question and regression test for strftime adn wcsftime

2014-04-22 Thread Vladimir Támara Patiño
I see a lot of duplication between lib/libc/time/strftime.c and lib/libc/time/wcsftime.c. Since I would like to implement LC_TIME support, I would prefer to change only in one place but before that I prepared a simple regression test for strftime and wcsftime that is attached. Checking NetBSD

Re: Question and regression test for strftime adn wcsftime

2014-04-22 Thread Stefan Sperling
On Thu, Apr 17, 2014 at 11:52:09AM -0500, Vladimir Támara Patiño wrote: I see a lot of duplication between lib/libc/time/strftime.c and lib/libc/time/wcsftime.c. Since I would like to implement LC_TIME support, I would prefer to change only in one place but before that I prepared a simple

Re: Question and regression test for strftime adn wcsftime

2014-04-22 Thread Matthew Dempsky
On Tue, Apr 22, 2014 at 2:43 PM, Stefan Sperling s...@openbsd.org wrote: Your regression test has at least one bug ('bad' is never initialised). It's perhaps bad *style* to not explicitly initialize it, but C99 6.7.8p10 says If an object that has static storage duration is not initialized

Re: Question and regression test for strftime adn wcsftime

2014-04-22 Thread Stefan Sperling
On Tue, Apr 22, 2014 at 02:57:17PM -0700, Matthew Dempsky wrote: On Tue, Apr 22, 2014 at 2:43 PM, Stefan Sperling s...@openbsd.org wrote: Your regression test has at least one bug ('bad' is never initialised). It's perhaps bad *style* to not explicitly initialize it, but C99 6.7.8p10 says