Re: yacc stdc output

2014-02-19 Thread Todd C. Miller
On Tue, 18 Feb 2014 18:49:21 -0700, Theo de Raadt wrote: The *.y file is the source code. the .c and .h files it generates are not the source code, but an intermediate language. To stetch this to the limit, we should be shipping cpp-processed files, for maximum portability. NO WAY! .y

Re: yacc stdc output

2014-02-19 Thread Theo de Raadt
It's basically impossible to support something when the actual code being compiled varies drastically from system to system. It is socially irresponsible to provide something like sudo or ssh for systems that old and fundamentally vulnerable, without any updates or any security at all. You are

Re: yacc stdc output

2014-02-19 Thread Mark Kettenis
From: Todd C. Miller todd.mil...@courtesan.com Date: Tue, 18 Feb 2014 14:50:53 -0700 On Tue, 18 Feb 2014 16:38:07 -0500, Ted Unangst wrote: True, I phrased that poorly. What I'm assuming is that the code will be built by a compiler that supports the const keyword. Or in other words,

Re: yacc stdc output

2014-02-18 Thread Ted Unangst
On Mon, Feb 17, 2014 at 15:57, Todd C. Miller wrote: On Mon, 17 Feb 2014 17:30:41 -0500, Ted Unangst wrote: I don't see how KR compat helps us. None of the headers in /usr/include are KR anymore. How would one compile the generated output? You're assuming that the resulting code will be

Re: yacc stdc output

2014-02-18 Thread Todd C. Miller
On Tue, 18 Feb 2014 16:38:07 -0500, Ted Unangst wrote: True, I phrased that poorly. What I'm assuming is that the code will be built by a compiler that supports the const keyword. Or in other words, if you're using a 25 year old cross compiler, I don't think it's unreasonable to expect you to

Re: yacc stdc output

2014-02-18 Thread Marc Espie
On Tue, Feb 18, 2014 at 02:50:53PM -0700, Todd C. Miller wrote: On Tue, 18 Feb 2014 16:38:07 -0500, Ted Unangst wrote: True, I phrased that poorly. What I'm assuming is that the code will be built by a compiler that supports the const keyword. Or in other words, if you're using a 25 year

Re: yacc stdc output

2014-02-18 Thread Todd C. Miller
On Tue, 18 Feb 2014 23:05:23 +0100, Marc Espie wrote: Come on Jim, it's dead. I'm a doctor, not a programmer! Err, wait... - todd

Re: yacc stdc output

2014-02-18 Thread Theo de Raadt
On Tue, 18 Feb 2014 16:38:07 -0500, Ted Unangst wrote: True, I phrased that poorly. What I'm assuming is that the code will be built by a compiler that supports the const keyword. Or in other words, if you're using a 25 year old cross compiler, I don't think it's unreasonable to expect you to

yacc stdc output

2014-02-17 Thread Ted Unangst
It's only been 25 years. I think we can depend on prototypes and const now. Index: output.c === RCS file: /cvs/src/usr.bin/yacc/output.c,v retrieving revision 1.19 diff -u -p -r1.19 output.c --- output.c8 Jan 2014 22:55:59 -

Re: yacc stdc output

2014-02-17 Thread Todd C. Miller
On Mon, 17 Feb 2014 15:25:12 -0500, Ted Unangst wrote: It's only been 25 years. I think we can depend on prototypes and const now. Is there really a reason to break KR compatibility in the generated code? What problem are you solving? - todd

Re: yacc stdc output

2014-02-17 Thread Todd C. Miller
On Mon, 17 Feb 2014 17:30:41 -0500, Ted Unangst wrote: I don't see how KR compat helps us. None of the headers in /usr/include are KR anymore. How would one compile the generated output? You're assuming that the resulting code will be built on OpenBSD. That's a bad assumption. The code