Re: Unlock IP forwarding paths

On 31/05/17(Wed) 00:20, Alexander Bluhm wrote: > On Tue, May 30, 2017 at 10:12:39PM +0200, Alexander Bluhm wrote: > > On Tue, May 30, 2017 at 10:04:14PM +0200, Alexander Bluhm wrote: > > > On Tue, May 30, 2017 at 11:48:50AM +0200, Martin Pieuchot wrote: > > > > Hrvoje Popovski found that

Re: [patch] rebound.c

Edgar Pettijohn wrote: > Be more consistent with logerr usage. > sure, thanks. can you send future diffs inline please? easier than attachments.

avoid ifq_deq_begin,commit,rollback in sxie(4/armv7)

i wrote this diff blind, so it may not compile or work. the intention is to check for space before attempting to dequeue a packet. the rest is largely cosmetic and makes it look more like a decent driver. could someone test please? Index: sxie.c

Re: remove vlan(4) specific ifconfig output

ok David Gwynne(da...@gwynne.id.au) on 2017.05.31 15:34:53 +1000: > the vlan specific output is redundant because vlan supports the > generic vnetid and parent ioctls now. > > this leaves the code for setting vlan specific stuff because there's > a slight semantic change i want to discuss

Re: ksh(1): vi mode UTF-8 bug

On Tue, May 30, 2017 at 04:16:15PM +0200, Theo Buehler wrote: > On Tue, May 30, 2017 at 03:39:50PM +0200, Ingo Schwarze wrote: > > Hi Anton, > > > > OK schwarze@ for the diff below (which, i think, is sufficient for > > commit in this case). > > I agree. This is good for commit. ok tb Thanks,

make tags

Hi, The `-t` option was passed to ctags(1) in bsd.dep.mk revision 1.9 2010/03/27. However, the same option was later turned into a no-op but kept around for backwards compatibility (usr.bin/ctags/ctags.c revision 1.23 2010/11/03). OK to drop the option from bsd.dep.mk? Index: bsd.dep.mk

Re: kqueue EV_RECEIPT and EV_DISPATCH

Jan Schreiber wrote: > Hi, > > I recently stumbled upon software that relies on EV_RECEIPT and > EV_DISPATCH to be available as flags. It also showed up as dependency > for a Rust crate. > FreeBSD has it since 8.1 and OSX since 10.5. > Patch is below. not sure I see the point, but gotta keep up

Re: [patch] typo smtpd/dns.c

On Tue, May 30, 2017 at 05:26:08PM -0500, Edgar Pettijohn wrote: > fix typo thanks, will commit when sending diffs, please inline them instead of attaching as it is easier for us to work with them that way Gilles > Index: dns.c >

Re: let's add PF_LOCK()

On 30/05/17(Tue) 20:31, Alexandr Nedvedicky wrote: > Hello Martin, > > > > > rw_exit_write(); > > > export_pflow(cur); > > > rw_enter_write(); > > > + rw_enter_write(_lock); > > > } > > > > This is not needed, you're not diffing against the latest version

EV_SET() trouble

I committed the following patch [1] to NetBSD, it's a valid issue for OpenBSD as well [2]: Convert EV_SET from macro to static __inline function LLDB introduced support for kevent(2) and it contains the following function: Status MainLoop::RunImpl::Poll() {

Re: EV_SET() trouble

Kamil Rytarowski wrote: > I committed the following patch [1] to NetBSD, it's a valid issue for > OpenBSD as well [2]: > > It works on FreeBSD and MacOSX, however it broke on NetBSD. > > Culrpit line: >EV_SET(_events[i++], fd.first, EVFILT_READ, EV_ADD, 0, 0, 0); thanks for pointing this

kqueue EV_RECEIPT and EV_DISPATCH

Hi, I recently stumbled upon software that relies on EV_RECEIPT and EV_DISPATCH to be available as flags. It also showed up as dependency for a Rust crate. FreeBSD has it since 8.1 and OSX since 10.5. Patch is below. mike@ looked throug, thanks a lot! Jan Index: sys/kern/kern_event.c

Re: make tags

On Wed, May 31, 2017 at 09:19:35AM +0200, Anton Lindqvist wrote: > Hi, > The `-t` option was passed to ctags(1) in bsd.dep.mk revision 1.9 > 2010/03/27. However, the same option was later turned into a no-op but > kept around for backwards compatibility (usr.bin/ctags/ctags.c revision > 1.23

[PATCH] Do not mention newaliases(8) in /etc/mail/aliases

OpenBSD defaults to file table now so there is no need in running newaliases(8). --- etc/mail/aliases | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/etc/mail/aliases b/etc/mail/aliases index c1ac04b5a81..045b2b2a456 100644 --- a/etc/mail/aliases +++ b/etc/mail/aliases

[PATCH] sdiff: fix comparision between signed and unsiged warning

This diff fixes edit.c: In function 'eparse': edit.c:149: warning: comparision between signed and unsigned warning during compilation. Index: usr.bin/sdiff/edit.c === RCS file: /cvs/src/usr.bin/sdiff/edit.c,v retrieving revision

Re: beacon miss threshold

On Wed, May 31, 2017 at 11:23:07AM +0200, Mark Kettenis wrote: > Is the beacon interval always the same for all modes/hardware? It is defined by the AP. The value (in TU) is sent to clients in beacons: # tcpdump -n -i iwn0 -y IEEE802_11_RADIO -vv 11:50:23.170309 802.11 flags=0<>: beacon,

Re: let's add PF_LOCK()

Hello, > > Could you you make 2 definitions for the lock? It doesn't make sense > to enable them by default for now. I'd like to see you diff committed > now with empty defines and an easy way to enable it. > > That means ok mpi@ if the defines to not take/release locks by default. > I

Re: pf.conf.5 translation option happens immediately only on match rules

* Tony Gong [2017-05-31 10:28]: > Pretty sure pf applies translations immediately only if the rule is a > match rule. > Diff makes this clear in the man page. yup, in, thx -- Henning Brauer, h...@bsws.de, henn...@openbsd.org BS Web Services GmbH, http://bsws.de,

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On May 31, 2017 11:35:28 AM GMT+02:00, Consus wrote: >OpenBSD defaults to file table now so there is no need in running >newaliases(8). >--- > etc/mail/aliases | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > >diff --git a/etc/mail/aliases b/etc/mail/aliases >index

beacon miss threshold

The net80211 stack currently provides a 'beacon miss timeout' value (in ms) which specifies how much time may elapse without beacons before drivers begin searching for a new AP. Drivers convert this timeout value into the amount of beacons they're allowed to miss. Having the stack provide this

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On 11:49 Wed 31 May, Antoine Jacoutot wrote: > I proposed the same a while ago but people preferred to keep it in > regard to other MTA. Maybe it's time to revisit ? Looks like I already have proposed it last September. Totally forgot =/

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On Wed, May 31, 2017 at 11:49:18AM +0200, Antoine Jacoutot wrote: > On May 31, 2017 11:35:28 AM GMT+02:00, Consus wrote: > >OpenBSD defaults to file table now so there is no need in running > >newaliases(8). > >--- > > etc/mail/aliases | 8 ++-- > > 1 file changed, 2

pf.conf.5 translation option happens immediately only on match rules

Pretty sure pf applies translations immediately only if the rule is a match rule. Diff makes this clear in the man page. diff --git share/man/man5/pf.conf.5 share/man/man5/pf.conf.5 index d76129deb47..7fa4bde1495 100644 --- share/man/man5/pf.conf.5 +++ share/man/man5/pf.conf.5 @@ -808,7 +808,9

Re: rework bgpd ext community and support origin validation state

Claudio Jeker(cje...@diehard.n-r-g.com) on 2017.05.31 00:27:21 +0200: > After looking at what IETF and IANA did to extended communities I decided > to refactor the code a major bit and hopefully that will work a bit better > than what we had before. When I implemented it first I foolishliy assumed

Re: let's add PF_LOCK()

Hello Mike, I'd like to ask you to take a one more look to change I'm going to commit. I did one more check of changes with respect to WITH_PF_LOCK and found one more bit to fix. We need to keep pf_purge_expired_fragments() under protection of NET_LOCK()

Re: beacon miss threshold

> Date: Wed, 31 May 2017 10:51:43 +0200 > From: Stefan Sperling > > The net80211 stack currently provides a 'beacon miss timeout' value (in ms) > which specifies how much time may elapse without beacons before drivers > begin searching for a new AP. > > Drivers convert this

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On 2017/05/31 11:10, Jason McIntyre wrote: > On Wed, May 31, 2017 at 11:49:18AM +0200, Antoine Jacoutot wrote: > > On May 31, 2017 11:35:28 AM GMT+02:00, Consus wrote: > > >OpenBSD defaults to file table now so there is no need in running > > >newaliases(8). > > >--- > > >

Re: beacon miss threshold

> Date: Wed, 31 May 2017 11:53:19 +0200 > From: Stefan Sperling > > On Wed, May 31, 2017 at 11:23:07AM +0200, Mark Kettenis wrote: > > Is the beacon interval always the same for all modes/hardware? > > It is defined by the AP. The value (in TU) is sent to clients in beacons: >

Re: kqueue EV_RECEIPT and EV_DISPATCH

On Wed, May 31, 2017 at 02:07:19PM +0200, Mike Belopuhov wrote: > On Wed, May 31, 2017 at 08:37 +0200, Jan Schreiber wrote: > > Hi, > > > > I recently stumbled upon software that relies on EV_RECEIPT and > > EV_DISPATCH to be available as flags. It also showed up as dependency > > for a Rust

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On Wed, May 31, 2017 at 09:53:38AM -0500, Jimmy Hess wrote: > On Wed, May 31, 2017 at 6:34 AM, Gilles Chehade wrote: > > > It is not that simple because newaliases works when you have one aliases > > database (e.g. /etc/mail/aliases). This is the case on the default setup > >

snmpd: remove unused variables

Hi, This diff removes two local variables which are never used. bye, Jan Index: trap.c === RCS file: /cvs/src/usr.sbin/snmpd/trap.c,v retrieving revision 1.29 diff -u -p -r1.29 trap.c --- trap.c 21 Apr 2017 13:46:15 -

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On Wed, May 31, 2017 at 6:34 AM, Gilles Chehade wrote: > It is not that simple because newaliases works when you have one aliases > database (e.g. /etc/mail/aliases). This is the case on the default setup > but smtpd supports per-rule aliases mappings and for example the MX

Re: [patch] rebound.c

Yeah, I use the nowrap or so plugin. When enabled, however, you will need to manually line break your textual lines. /Alexander On May 31, 2017 11:20:52 PM GMT+02:00, Edgar Pettijohn wrote: >Will do. Seems like Thunderbird messes then up sometimes. > >⁣Sent from

i386 clang: fix bootstrap build (sync with amd64)

The same changes as committed yesterday for amd64. This allows building the i386 bootstrap with clang: * build with -ffreestanding * skip the integrated assembler for assym.h * use as(1) to build biosboot.S and the various versions of srt0.S Successfully tested for { pxeboot, disk boot } x {

Question on getcwd(3) behavior on OpenBSD

Just recently converted the main user machines students and faculty use to OpenBSD 6.1. I've found out that git will abort in one scenario where there is a directory in the tree where the user has execute permissions but not read permissions. I traced down this abort to a getcwd(3) call where

Re: beacon miss threshold

On Wed, May 31, 2017 at 01:25:36PM +0200, Mark Kettenis wrote: > > Date: Wed, 31 May 2017 11:53:19 +0200 > > From: Stefan Sperling > > > > On Wed, May 31, 2017 at 11:23:07AM +0200, Mark Kettenis wrote: > > > Is the beacon interval always the same for all modes/hardware? > > > >

tweak txp to avoid ifq_deq_begin/commit/rollback

According to the FreeBSD driver, txp(4) is not setting up its TX ring correctly. FreeBSD driver uses up to 16 fragments, while we use up to 252 which is suspicious. This gets us in line with FreeBSD, introduces goodness of m_defrag and removes pesky if_deq_* thingies. Does anyone still have the

Re: tweak txp to avoid ifq_deq_begin/commit/rollback

On Wed, May 31, 2017 at 20:40 +0200, Mike Belopuhov wrote: > According to the FreeBSD driver, txp(4) is not setting up its TX > ring correctly. FreeBSD driver uses up to 16 fragments, while we > use up to 252 which is suspicious. > > This gets us in line with FreeBSD, introduces goodness of

Re: Question on getcwd(3) behavior on OpenBSD

Kurt Mosiejczuk wrote: > Just recently converted the main user machines students and faculty use > to OpenBSD 6.1. I've found out that git will abort in one scenario > where there is a directory in the tree where the user has execute > permissions but not read permissions. > > I traced down this

Re: rework bgpd ext community and support origin validation state

Hi, A typo slipped into Claudio's patch. While at it, fix the same typo elsewhere. Denis Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving revision 1.308 diff -u -p -r1.308 parse.y --- parse.y 31 May

Re: kqueue EV_RECEIPT and EV_DISPATCH

On Wed, May 31, 2017 at 08:37 +0200, Jan Schreiber wrote: > Hi, > > I recently stumbled upon software that relies on EV_RECEIPT and > EV_DISPATCH to be available as flags. It also showed up as dependency > for a Rust crate. > FreeBSD has it since 8.1 and OSX since 10.5. > Patch is below. > >

Route priority support for ospf6d

Hi, this diff adds priority support to ospf6d. Mostly based on the following ospfd commit: cvs diff -D "2008-12-11" -D "2008-12-13" Additionally I removed the RTF_UP from hdr.rtm_flags in send_rtmsg(). Ospfd and bgpd also don't set the flag. The next steps will be to add support for ospf6ctl

ipsec: tdb_unlink() and dst addr update for MOBIKE

Hi, I'd like to add MOBIKE support to iked, specifically first of all making iked as server react to mobile clients changing their IP addresses. One thing for that is the kernel part. Having MOBIKE means that we need to be able to change the destination address in an existing SA so that the

Re: [PATCH] Do not mention newaliases(8) in /etc/mail/aliases

On Wed, May 31, 2017 at 11:59:08AM +0100, Stuart Henderson wrote: > On 2017/05/31 11:10, Jason McIntyre wrote: > > On Wed, May 31, 2017 at 11:49:18AM +0200, Antoine Jacoutot wrote: > > > On May 31, 2017 11:35:28 AM GMT+02:00, Consus wrote: > > > >OpenBSD defaults to file table now

Re: tweak msk to avoid ifq_deq_begin/commit/rollback

On Wed, May 31, 2017 at 10:28 +1000, David Gwynne wrote: > ie, do the space check before trying to dequeue and mbuf. > > this also moves it to using m_defrag. > Thanks, this looks good. Forgot to mention that you can remove the /* now we are committed to transmit the packet */ comment from both

Re: [patch] rebound.c

Will do. Seems like Thunderbird messes then up sometimes. ⁣Sent from BlueMail ​ On May 31, 2017, 2:14 AM, at 2:14 AM, Ted Unangst wrote: >Edgar Pettijohn wrote: >> Be more consistent with logerr usage. >> > >sure, thanks. can you send future diffs inline please? easier than

Re: [patch] typo smtpd/dns.c

Will do. I just don't trust Thunderbird not to mess them up. ⁣Sent from BlueMail ​ On May 31, 2017, 3:01 AM, at 3:01 AM, Gilles Chehade wrote: >On Tue, May 30, 2017 at 05:26:08PM -0500, Edgar Pettijohn wrote: >> fix typo > >thanks, will commit > >when sending diffs, please