Re: Send hostname to remote host with syslogd

2013-01-31 Thread Rob Pierce
Hey Gabriel, We have seen the same behaviour and will hopefully be testing your patch this week. It would be great to have this capability in base as we don't want to install extra packages (i.e. rsyslog) and so far base does everything we need. Regards, Rob - Original Message -

Re: Send hostname to remote host with syslogd

2013-02-01 Thread Rob Pierce
For what it's worth (http://tools.ietf.org/html/rfc5424): 6.2.4. HOSTNAME The HOSTNAME field identifies the machine that originally sent the syslog message. The HOSTNAME field SHOULD contain the hostname and the domain name of the originator in the format specified in STD 13

Is cvsweb.openbsd.org down?

2015-10-29 Thread Rob Pierce
It appears to be unavailable at the moment. Regards, Rob

Re: Is cvsweb.openbsd.org down?

2015-10-29 Thread Rob Pierce
- Original Message - > From: "Raf Czlonka" <rczlo...@gmail.com> > To: "tech" <tech@openbsd.org> > Sent: Thursday, October 29, 2015 7:33:31 PM > Subject: Re: Is cvsweb.openbsd.org down? > On Thu, Oct 29, 2015 at 11:23:29PM GMT, Rob P

Re: Is cvsweb.openbsd.org down?

2015-10-29 Thread Rob Pierce
- Original Message - > From: "Rob Pierce" <r...@2keys.ca> > To: "tech" <tech@openbsd.org> > Sent: Thursday, October 29, 2015 7:46:11 PM > Subject: Re: Is cvsweb.openbsd.org down? > - Original Message - >> From: "Raf Czl

typo in OPENBSD-RELAYD-MIB.txt

2015-10-13 Thread Rob Pierce
Regards, Index: OPENBSD-RELAYD-MIB.txt === RCS file: /cvs/src/share/snmp/OPENBSD-RELAYD-MIB.txt,v retrieving revision 1.1 diff -u -p -r1.1 OPENBSD-RELAYD-MIB.txt --- OPENBSD-RELAYD-MIB.txt 19 Nov 2014 10:24:39 - 1.1 +++

remove unused variables in netcat.c

2015-10-15 Thread Rob Pierce
It looks like the subject and issuer variables are no longer used in report_tls() since the recent libtls api change. Also a few whitespace mods. Regards, Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving

Re: typo in OPENBSD-RELAYD-MIB.txt

2015-10-14 Thread Rob Pierce
On Wed, Oct 14, 2015 at 11:25:42AM +0100, Stuart Henderson wrote: > On 2015/10/13 23:07, Rob Pierce wrote: > > Regards, > > > > Index: OPENBSD-RELAYD-MIB.txt > > === > > RCS file: /cvs/src/sh

Re: a few style examples don't comply

2015-10-05 Thread Rob Pierce
On Mon, Oct 05, 2015 at 05:38:34PM +0059, Jason McIntyre wrote: > On Mon, Oct 05, 2015 at 11:50:49AM -0400, Rob Pierce wrote: > > There are some offending braces. I just added leading tabs in the right > > places to correct indentation. > > > > Rob > > >

missing period in pledge.2

2015-11-17 Thread Rob Pierce
Index: pledge.2 === RCS file: /cvs/src/lib/libc/sys/pledge.2,v retrieving revision 1.15 diff -u -p -r1.15 pledge.2 --- pledge.216 Nov 2015 19:26:21 - 1.15 +++ pledge.217 Nov 2015 21:14:08 - @@ -472,7 +472,7 @@

mention ntpd support for constraints in 57.html?

2015-08-27 Thread Rob Pierce
Good evening. Since ntpd started supporting constraints in 5.7, maybe 57.html should reflect this? Index: www/57.html === RCS file: /cvs/www/57.html,v retrieving revision 1.92 diff -u -p -r1.92 57.html --- www/57.html 6 Aug 2015

reference ntpctl in ntpd.conf.5

2015-08-27 Thread Rob Pierce
This is similar to what is done for relayd and snmpd, etc. Index: ntpd.conf.5 === RCS file: /cvs/src/usr.sbin/ntpd/ntpd.conf.5,v retrieving revision 1.31 diff -u -p -r1.31 ntpd.conf.5 --- ntpd.conf.5 18 May 2015 11:10:03 -

Should PIE be mentioned in security.html?

2015-08-28 Thread Rob Pierce
Not sure about its location in the list. Index: security.html === RCS file: /cvs/www/security.html,v retrieving revision 1.422 diff -u -p -r1.422 security.html --- security.html 2 Jul 2015 05:49:04 - 1.422 +++

hrefs in FAQ

2015-09-04 Thread Rob Pierce
Index: faq10.html === RCS file: /cvs/www/faq/faq10.html,v retrieving revision 1.194 diff -u -p -r1.194 faq10.html --- faq10.html 2 Jul 2015 05:49:04 - 1.194 +++ faq10.html 5 Sep 2015 03:27:45 - @@ -196,7 +196,7 @@ This

Re: remove redundancy in tame(2) man page

2015-09-06 Thread Rob Pierce
- Original Message - From: "Jason McIntyre" <j...@kerhand.co.uk> To: "tech" <tech@openbsd.org> Sent: Sunday, September 6, 2015 3:15:34 PM Subject: Re: remove redundancy in tame(2) man page On Sun, Sep 06, 2015 at 02:30:43PM -0400, Rob Pierce wrote: > f

Prepare sort(1) for tame(2)

2015-09-05 Thread Rob Pierce
Move set_hw_params() up (sysctl/getrlimit system calls) so tame(2) can be called earlier. Index: sort.c === RCS file: /cvs/src/usr.bin/sort/sort.c,v retrieving revision 1.79 diff -u -p -r1.79 sort.c --- sort.c 5 Apr 2015

OpenNTP and (continuous) constraint checking

2015-09-07 Thread Rob Pierce
Good day. ntpd currently performs constraints checking on startup, but once the constraints are successfully checked cstr->state remains in STATE_REPLY_RECEIVED forever. As such, the constraints are never checked again. The following patch has resolved this for me, and constraints checking now

security.html

2015-09-04 Thread Rob Pierce
Single quotes or double quotes? I left single as single, and double as double, but "fixed" (or is that 'fixed'?) them both. Is there any interest in bring the "New Technologies" section up to date? It seems like lots of additional good stuff has been done. When I point our new guys to this

remove redundancy in tame(2) man page

2015-09-06 Thread Rob Pierce
fstat(2) mentioned twice under wpath. utimes(2) referenced twice under fattr. Rob Index: tame.2 === RCS file: /cvs/src/lib/libc/sys/tame.2,v retrieving revision 1.21 diff -u -p -r1.21 tame.2 --- tame.2 26 Aug 2015 15:17:06

Re: security.html

2015-09-04 Thread Rob Pierce
f security features... someone should flesh out Regards, Rob - Original Message ----- From: "Rob Pierce" <r...@2keys.ca> To: "tech" <tech@openbsd.org> Sent: Friday, September 4, 2015 6:48:48 PM Subject: security.html Is there any interest in bring the "

58.html

2015-09-03 Thread Rob Pierce
href tar and cpio? Index: 58.html === RCS file: /cvs/www/58.html,v retrieving revision 1.51 diff -u -p -r1.51 58.html --- 58.html 3 Sep 2015 23:19:55 - 1.51 +++ 58.html 4 Sep 2015 00:39:18 - @@ -143,7 +143,7 @@

plus58.html hrefs

2015-09-03 Thread Rob Pierce
There is also a reference to smu(4) that appears to be broken, as well as an unreferenced pkg(5) and cupid(6) that I couldn't resolve. Index: plus58.html === RCS file: /cvs/www/plus58.html,v retrieving revision 1.7 diff -u -p -r1.7

Re: plus58.html hrefs

2015-09-03 Thread Rob Pierce
Sorry, an unreferenced cpuid(6) that I couldn't resolve. - Original Message - From: "Rob Pierce" <r...@2keys.ca> To: "tech" <tech@openbsd.org> Sent: Friday, September 4, 2015 12:29:50 AM Subject: plus58.html hrefs There is also a reference to smu(4) th

58.html href syslogd(8)

2015-09-03 Thread Rob Pierce
Index: 58.html === RCS file: /cvs/www/58.html,v retrieving revision 1.51 diff -u -p -r1.51 58.html --- 58.html 3 Sep 2015 23:19:55 - 1.51 +++ 58.html 4 Sep 2015 01:57:32 - @@ -496,7 +496,7 @@

58.html href openssl(1)

2015-09-03 Thread Rob Pierce
Index: 58.html === RCS file: /cvs/www/58.html,v retrieving revision 1.53 diff -u -p -r1.53 58.html --- 58.html 4 Sep 2015 02:08:46 - 1.53 +++ 58.html 4 Sep 2015 03:12:11 - @@ -460,7 +460,7 @@ to 5.8.

58.html href amdcf

2015-09-03 Thread Rob Pierce
Index: 58.html === RCS file: /cvs/www/58.html,v retrieving revision 1.51 diff -u -p -r1.51 58.html --- 58.html 3 Sep 2015 23:19:55 - 1.51 +++ 58.html 4 Sep 2015 01:37:53 - @@ -78,7 +78,7 @@ to 5.8.

Proposed changes for anoncvs.html

2015-09-08 Thread Rob Pierce
Some proposed changes for consistency and readability. Regards, Index: anoncvs.html === RCS file: /cvs/www/anoncvs.html,v retrieving revision 1.428 diff -u -p -r1.428 anoncvs.html --- anoncvs.html2 Sep 2015 13:12:30 -

Re: OpenNTP and (continuous) constraint checking

2015-09-07 Thread Rob Pierce
> - Original Message - > From: "Rob Pierce" <r...@2keys.ca> > To: "tech" <tech@openbsd.org> > Sent: Monday, September 7, 2015 1:22:21 PM > Subject: OpenNTP and (continuous) constraint checking > > Good day. > > ntpd c

ntpd.c - percision of constraint offset

2015-09-17 Thread Rob Pierce
Good day. I understand that the authenticated TLS constraints are not for percision. Nonetheless, I thought it might make sense to consider displaying the ntpctl contraint offset output with greater percision to avoid it being misleading. The text output below shows three values for the

Re: ntpd.c - percision of constraint offset

2015-09-17 Thread Rob Pierce
On Thu, Sep 17, 2015 at 10:53:03AM -0700, Philip Guenther wrote: > On Thu, Sep 17, 2015 at 8:04 AM, Rob Pierce <r...@2keys.ca> wrote: > > I understand that the authenticated TLS constraints are not for percision. > > Nonetheless, I thought it might make sense to consider

Re: update: afterboot.8 to reference ntpd(8) by default

2015-09-26 Thread Rob Pierce
52:39AM BST, Stuart Henderson wrote: >> On 2015/09/26 07:44, Raf Czlonka wrote: >> > On Fri, Sep 25, 2015 at 10:14:03PM BST, Rob Pierce wrote: >> > >> > > Update diff below referencing the correct man page sections and with >> > &

style.9 references "user land"

2015-10-04 Thread Rob Pierce
When I read "user land" in style.9 it seemed weird. I checked and all other man pages refer to "userland". I also checked the source tree and found well over 400 instances of userland, and only 3 other instances of "user land": share/man/man9/style.9 lib/libc/rpc/svc.c

update lex to use __progname

2015-10-04 Thread Rob Pierce
Lex is currently using progam_name = argv[0]. Change to __progname? Regards, Index: flexdef.h === RCS file: /cvs/src/usr.bin/lex/flexdef.h,v retrieving revision 1.7 diff -u -p -r1.7 flexdef.h --- flexdef.h 3 Feb 2004 21:20:17

Re: update: afterboot.8 to reference ntpd(8) by default

2015-09-26 Thread Rob Pierce
On Sat, Sep 26, 2015 at 11:42:11AM +0100, Raf Czlonka wrote: > On Sat, Sep 26, 2015 at 09:52:39AM BST, Stuart Henderson wrote: > > On 2015/09/26 07:44, Raf Czlonka wrote: > > > On Fri, Sep 25, 2015 at 10:14:03PM BST, Rob Pierce wrote: > > > > > > > Update

make caveat consistent with description in md5.1

2015-09-19 Thread Rob Pierce
Mention that collisions are theorizied for SHA-1 in the caveat. Regards, Index: md5.1 === RCS file: /cvs/src/bin/md5/md5.1,v retrieving revision 1.44 diff -u -p -r1.44 md5.1 --- md5.1 4 Dec 2014 20:10:16 - 1.44 +++

flex++ and lex are synonyms for flex(1) in flex.1

2015-09-19 Thread Rob Pierce
Does this makes sense? I took the same approach used in chpass.1. Regards, Index: flex.1 === RCS file: /cvs/src/usr.bin/lex/flex.1,v retrieving revision 1.41 diff -u -p -r1.41 flex.1 --- flex.1 7 Sep 2015 15:28:06 -

rc.d.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in rc.d.8. Regards, Index: rc.d.8 === RCS file: /cvs/src/share/man/man8/rc.d.8,v retrieving revision 1.28 diff -u -p -r1.28 rc.d.8 --- rc.d.8 25 Feb 2015 23:01:28 - 1.28 +++ rc.d.8

rc.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in rc.8. Regards, Index: rc.8 === RCS file: /cvs/src/share/man/man8/rc.8,v retrieving revision 1.40 diff -u -p -r1.40 rc.8 --- rc.822 Jul 2014 07:38:52 - 1.40 +++ rc.818 Sep

rc.conf.8 should ref rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in rc.conf.8 (which discusses rc.conf.local). Rob Index: rc.conf.8 === RCS file: /cvs/src/share/man/man8/rc.conf.8,v retrieving revision 1.26 diff -u -p -r1.26 rc.conf.8 --- rc.conf.8 4 May 2015

afterboot.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility from afterboot.8. Regards, Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.147 diff -u -p -r1.147 afterboot.8 --- afterboot.8 30 Jul 2015 08:03:49 -

Re: flex++ and lex are synonyms for flex(1) in flex.1

2015-09-20 Thread Rob Pierce
On Sun, Sep 20, 2015 at 02:26:38PM +0100, Nicholas Marriott wrote: > The .Nm part yes, but but flex++ is not a synonym, flex generates > different output when called as flex++. This is already mentioned in the > later section on C++. > > > On Sat, Sep 19, 2015 at 10:29:12PM

delete reference to inetd from afterboot.8

2015-09-24 Thread Rob Pierce
Since inetd is no longer started by default and inetd.conf has been relegated to /etc/examples, this sentence can probably be deleted from afterboot.8. Regards, Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v

afterboot.8 to reference ntpd(1) enabled by default

2015-09-25 Thread Rob Pierce
Since ntpd(1) is now enabled by default do the following changes make sense? Regards, Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.149 diff -u -p -r1.149 afterboot.8 --- afterboot.8 24

update: afterboot.8 to reference ntpd(8) by default

2015-09-25 Thread Rob Pierce
Update diff below referencing the correct man page sections and with sentenced starting on a new line. Regards, Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.149 diff -u -p -r1.149

intro.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in intro.8 Regards, Index: intro.8 === RCS file: /cvs/src/share/man/man8/intro.8,v retrieving revision 1.25 diff -u -p -r1.25 intro.8 --- intro.8 26 Aug 2014 19:33:48 - 1.25 +++ intro.8

ntpd user defined constraint margin

2015-09-23 Thread Rob Pierce
Good day, Please see diffs (below) to add a user defined "constraint margin" to ntpd. I also included a basic regress test report (and script). This may be a misguided endeavour, but I am enjoying myself! Comments are more than welcome. Regards, Rob Index: client.c

missing colon delimiters in style.9

2015-10-05 Thread Rob Pierce
Index: style.9 === RCS file: /cvs/src/share/man/man9/style.9,v retrieving revision 1.62 diff -u -p -r1.62 style.9 --- style.9 5 Oct 2015 01:22:34 - 1.62 +++ style.9 5 Oct 2015 11:41:35 - @@ -471,12 +471,12 @@ is

Re: missing colon delimiters in style.9

2015-10-05 Thread Rob Pierce
On Mon, Oct 05, 2015 at 03:18:06PM +0100, Jason McIntyre wrote: > On Sun, Oct 04, 2015 at 10:56:45PM -0400, Rob Pierce wrote: > > > > Index: style.9 > > === > > there are many more places in this pla

Re: missing colon delimiters in style.9

2015-10-05 Thread Rob Pierce
- Original Message - > From: "Jason McIntyre" <j...@kerhand.co.uk> > To: "tech" <tech@openbsd.org> > Sent: Monday, October 5, 2015 11:41:57 AM > Subject: Re: missing colon delimiters in style.9 > On Mon, Oct 05, 2015 at 11:21:24AM -0400, Rob

a few style examples don't comply

2015-10-05 Thread Rob Pierce
There are some offending braces. I just added leading tabs in the right places to correct indentation. Rob Index: style.9 === RCS file: /cvs/src/share/man/man9/style.9,v retrieving revision 1.62 diff -u -p -r1.62 style.9 --- style.9

afterboot - ntpd now on by default

2015-11-20 Thread Rob Pierce
Ping. Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.149 diff -u -p -r1.149 afterboot.8 --- afterboot.8 24 Sep 2015 15:07:55 - 1.149 +++ afterboot.8 26 Sep 2015 16:22:07 - @@

Re: rcctl ls faulty -> failed

2016-03-29 Thread Rob Pierce
> From: "Antoine Jacoutot" > To: "Ian Darwin" > Cc: "tech" > Sent: Tuesday, March 29, 2016 10:59:54 AM > Subject: Re: rcctl ls faulty -> failed > On Tue, Mar 29, 2016 at 10:48:17AM -0400, Ian Darwin wrote: > > On Tue, Mar 29, 2016 at

pledge pstat

2016-04-12 Thread Rob Pierce
Hoist sysct and kvm calls, and pledge stdio, rpath, vminfo. Rob Index: pstat.c === RCS file: /cvs/src/usr.sbin/pstat/pstat.c,v retrieving revision 1.102 diff -u -p -r1.102 pstat.c --- pstat.c 12 Apr 2016 16:53:42 -

Re: pledge pstat

2016-04-13 Thread Rob Pierce
From: "Mike Belopuhov" <m...@belopuhov.com> To: "Rob Pierce" <r...@2keys.ca> Cc: "tech" <tech@openbsd.org> Sent: Tuesday, April 12, 2016 6:05:19 PM Subject: Re: pledge pstat BQ_BEGIN On 12 April 2016 at 22:25, Rob Pierce <r...@2keys.

pstat diff fixed segmentation fault

2016-04-11 Thread Rob Pierce
Running pstat with either [-M core] or [-N system] along with the -T option results in a segmentation fault. Make sure kvm access is initialized prior to running kvm_read() when -T is specified. This issue appears to have been introduced when setgid kmem support was removed in revision 1.99. Rob

prefer memset() over bzero() for ber.c in snmpd and ypldap

2016-03-04 Thread Rob Pierce
A similar change was done to ber.c in ldapd by @mmcc. I just copied those changes for snmpd and ypldap. No binary change. Regards, Index: snmpd/ber.c === RCS file: /cvs/src/usr.sbin/snmpd/ber.c,v retrieving revision 1.30 diff -u

Re: pledge pstat

2016-04-13 Thread Rob Pierce
On Tue, Apr 12, 2016 at 04:25:01PM -0400, Rob Pierce wrote: > Hoist sysct and kvm calls, and pledge stdio, rpath, vminfo. > > Rob Update diff based on comments from tb@: Changes include the following: - kd is a pointer, so compare with NULL (not 0). - simply nlistf/memf condition

intro.2 mention of pledge(2)

2016-04-15 Thread Rob Pierce
Does this make sense? Rob Index: intro.2 === RCS file: /cvs/src/lib/libc/sys/intro.2,v retrieving revision 1.63 diff -u -p -r1.63 intro.2 --- intro.2 6 Mar 2016 22:32:09 - 1.63 +++ intro.2 15 Apr 2016 16:26:24

Re: syslogd: accept space-deliminated fields

2016-07-05 Thread Rob Pierce
- Original Message - > From: "Todd C. Miller" > To: "tech" > Sent: Friday, July 1, 2016 12:55:11 PM > Subject: syslogd: accept space-deliminated fields > Linux, Net and Free also support space-deliminated fields. Maybe > we should too... > -

60.html on ntpd and pledge

2016-08-25 Thread Rob Pierce
ntpd was pledged in 5.9. Rob Index: 60.html === RCS file: /cvs/www/60.html,v retrieving revision 1.70 diff -u -p -r1.70 60.html --- 60.html 24 Aug 2016 20:47:30 - 1.70 +++ 60.html 25 Aug 2016 07:48:55 - @@

minor diff for faq15.html

2016-09-03 Thread Rob Pierce
There is only one result mentioned: ready-to-install binary packages. Rob Index: faq15.html === RCS file: /cvs/www/faq/faq15.html,v retrieving revision 1.141 diff -u -p -r1.141 faq15.html --- faq15.html 1 Sep 2016 12:05:14 -

mention relayd in faq6.html

2016-09-03 Thread Rob Pierce
Not sure if this is the right place or the right wording, but I think it deserves a mention somewhere in the faq. Regards, Rob Index: faq6.html === RCS file: /cvs/www/faq/faq6.html,v retrieving revision 1.383 diff -u -p -r1.383

whitespace in /etc/rc

2016-09-05 Thread Rob Pierce
Index: rc === RCS file: /cvs/src/etc/rc,v retrieving revision 1.486 diff -u -p -r1.486 rc --- rc 10 Jul 2016 09:08:18 - 1.486 +++ rc 5 Sep 2016 15:45:09 - @@ -490,7 +490,6 @@ echo clearing /tmp # rc.securelevel did

minor diff for vmctl.8

2016-09-11 Thread Rob Pierce
"host" is not a command argument. Rob Index: vmctl.8 === RCS file: /cvs/src/usr.sbin/vmctl/vmctl.8,v retrieving revision 1.13 diff -u -p -r1.13 vmctl.8 --- vmctl.8 18 Aug 2016 16:12:05 - 1.13 +++ vmctl.8 12 Sep 2016

Re: fix regress in pstat.c

2016-09-17 Thread Rob Pierce
On Sat, Sep 17, 2016 at 09:20:31PM +0200, Theo Buehler wrote: > While this patch avoids the bug, it isn't quite right: pstat -ft should > be equivalent to "pstat -f && pstat -t" but... > > $ pstat -ft > pstat: kvm_openfiles: /dev/mem: Permission denied > > The actual problem is in ttymode(): if

remove kern.arand from sysctl.8 and rnd.c (comment)

2016-09-22 Thread Rob Pierce
Index: sysctl.8 === RCS file: /cvs/src/sbin/sysctl/sysctl.8,v retrieving revision 1.205 diff -u -p -r1.205 sysctl.8 --- sysctl.87 Sep 2016 17:30:12 - 1.205 +++ sysctl.823 Sep 2016 02:16:14 - @@ -144,7 +144,6 @@

fix regress in pstat.c

2016-09-17 Thread Rob Pierce
ttymode() needs nlist, otherwise "pstat -tf" will fail since kd will not be NULL and the calls from ttymode() to KGET will error as follows: pstat: cannot read ntty: invalid address (0) pstat: cannot read tty_head: invalid address (0) KGET(TTY_NTTY, ntty) and KGET(TTY_TTYLIST, tty_head) both

minor typo in aldap.c comment

2016-10-21 Thread Rob Pierce
Index: aldap.c === RCS file: /cvs/src/usr.sbin/ypldap/aldap.c,v retrieving revision 1.32 diff -u -p -r1.32 aldap.c --- aldap.c 27 Apr 2016 10:53:27 - 1.32 +++ aldap.c 22 Oct 2016 02:42:13 - @@ -1198,7 +1198,7 @@

minor diff for switchd.8

2016-11-28 Thread Rob Pierce
Index: switchd.8 === RCS file: /cvs/src/usr.sbin/switchd/switchd.8,v retrieving revision 1.3 diff -u -p -r1.3 switchd.8 --- switchd.8 20 Oct 2016 19:55:29 - 1.3 +++ switchd.8 29 Nov 2016 02:49:53 - @@ -29,7 +29,7 @@

minor diff for ldapd.conf.5

2016-10-16 Thread Rob Pierce
Fix a couple of grammar mistakes, remove a redundant word, and add a FILES reference for the /etc/ldap/certs directory. Rob Index: ldapd.conf.5 === RCS file: /cvs/src/usr.sbin/ldapd/ldapd.conf.5,v retrieving revision 1.19 diff -u -p

ifstated.c diff for __dead usage

2017-03-19 Thread Rob Pierce
Index: ifstated.c === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v retrieving revision 1.41 diff -u -p -r1.41 ifstated.c --- ifstated.c 30 May 2013 19:22:48 - 1.41 +++ ifstated.c 20 Mar 2017 00:19:52 - @@ -50,28

dhcpd: remove unused structs

2017-08-01 Thread Rob Pierce
I can confirm that the following structs have not been used since at least OpenBSD 4.9. From Edgar Pettijohn. Ok? Index: dhcpd.h === RCS file: /cvs/src/usr.sbin/dhcpd/dhcpd.h,v retrieving revision 1.65 diff -u -p -r1.65 dhcpd.h ---

ifstated: consistent use of log.c

2017-08-03 Thread Rob Pierce
As a result ifstated.c no longer needs err.h. Index: ifstated.c === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v retrieving revision 1.56 diff -u -p -r1.56 ifstated.c --- ifstated.c 24 Jul 2017 12:33:59 - 1.56 +++

switchd: no need to include err.h

2017-08-03 Thread Rob Pierce
switchd no longer requires err.h. Index: packet.c === RCS file: /cvs/src/usr.sbin/switchd/packet.c,v retrieving revision 1.4 diff -u -p -r1.4 packet.c --- packet.c26 Sep 2016 08:55:43 - 1.4 +++ packet.c4 Aug 2017

Re: ifstated: stop tracking interface indexes

2017-08-15 Thread Rob Pierce
On Tue, Aug 15, 2017 at 02:37:22PM -0400, Jeremie Courreges-Anglas wrote: > On Tue, Aug 15 2017, Rob Pierce <r...@2keys.ca> wrote: > > On Mon, Aug 14, 2017 at 11:26:46PM -0400, Jeremie Courreges-Anglas wrote: > >> On Mon, Aug 14 2017, Rob Pierce <r...@2keys.ca> wr

Re: ksh(1) history lines allocation

2017-08-15 Thread Rob Pierce
On Tue, Aug 15, 2017 at 02:03:43PM -0400, Jeremie Courreges-Anglas wrote: > On Tue, Aug 15 2017, Rob Pierce <r...@2keys.ca> wrote: > > [...] > > > I was able to reproduce the problem with a HISTSIZE of 10 which at > > 125000 > > entries rendered my

bsd.regress.mk.5 typo fix

2017-08-11 Thread Rob Pierce
I just ran across this. Ok? Index: bsd.regress.mk.5 === RCS file: /cvs/src/share/man/man5/bsd.regress.mk.5,v retrieving revision 1.14 diff -u -p -r1.14 bsd.regress.mk.5 --- bsd.regress.mk.53 Jul 2017 18:19:55 - 1.14 +++

Re: ksh(1) history lines allocation

2017-08-14 Thread Rob Pierce
On Mon, Aug 14, 2017 at 10:26:48PM -0400, Jeremie Courreges-Anglas wrote: > > So I tinkered with the way ksh(1) tracks memory allocation, trying to > make it faster in the general case. One approach used a RB tree, > I wrote since a simple hash table implementation which seems to work > rather

ifstated: stop tracking interface indexes

2017-08-14 Thread Rob Pierce
ifstated currently tracks and maintains the index of each monitored interface and does not maintain interface names. This means we need to re-index on interface departure and arrival. The following diff moves away from indexes to names. Indexes are still required, but easily obtained dynamically

Re: ifstated: stop tracking interface indexes

2017-08-15 Thread Rob Pierce
On Mon, Aug 14, 2017 at 11:26:46PM -0400, Jeremie Courreges-Anglas wrote: > On Mon, Aug 14 2017, Rob Pierce <r...@2keys.ca> wrote: > > ifstated currently tracks and maintains the index of each monitored > > interface > > and does not maintain interface names. Thi

diff: pledge snmpd

2017-08-11 Thread Rob Pierce
The following diff pledges two of three processes in snmpd: the parent snmpd process and the trap handler. We cannot currently pledge snmpe as snmp requests asking for privileged kernel info are disallowed by pledge. I have included a commented pledge block in snmpe.c below (which will not be

pledge ifstated

2017-07-13 Thread Rob Pierce
The following diff is loosely based on the approach that was taken for pledging mountd. Other code/approaches leveraged from various networking daemons. This first step moves the ioctl with SIOCGIFDATA call to a privileged child so we can at least pledge "stdio rpath dns inet proc exec" without

Re: add simple ifstated regression test script

2017-07-13 Thread Rob Pierce
Sure, no problem. Thank you. Rob From: "Sebastian Benoit" <be...@openbsd.org> To: "Rob Pierce" <r...@2keys.ca> Cc: "tech" <tech@openbsd.org> Sent: Thursday, July 13, 2017 6:12:14 PM Subject: Re: add simple ifstated regression te

Re: pledge ifstated

2017-07-13 Thread Rob Pierce
On Mon, Jul 10, 2017 at 01:21:58PM -0400, Rob Pierce wrote: > The following diff is loosely based on the approach that was taken for > pledging mountd. Other code/approaches leveraged from various networking > daemons. > > This first step moves the ioctl with SIOCGIFDATA call

Re: pledge ifstated

2017-07-17 Thread Rob Pierce
On Sun, Jul 16, 2017 at 04:47:07PM -0400, Rob Pierce wrote: > On Thu, Jul 13, 2017 at 09:16:14PM -0400, Rob Pierce wrote: > > On Mon, Jul 10, 2017 at 01:21:58PM -0400, Rob Pierce wrote: > > > The following diff is loosely based on the approach that was taken for > > >

Re: add simple ifstated regression test script

2017-07-06 Thread Rob Pierce
On Sun, Jul 02, 2017 at 06:29:07PM +0200, Sebastian Benoit wrote: > Rob Pierce(r...@2keys.ca) on 2017.07.02 12:06:25 -0400: > > I am currently using this regression script for basic ifstated sanity > > testing. > > > > Still a work in progress. Requesting commit f

ifstated diff cleanup before delegating proc/exec to privchild

2017-07-15 Thread Rob Pierce
This diff should probably be three separate diffs, but changes are colliding (i.e. adjacent lines of code are being modified within different diffs). The diff contains three modifications: - removal of unused logging code (see previous diff); - a cleanup of parse.y, converting it to use log.c;

ifstated regress statemachine whitespace diff

2017-07-14 Thread Rob Pierce
Remove some unwanted whitespace that creeped in. Rob Index: statemachine === RCS file: /cvs/src/regress/usr.sbin/ifstated/statemachine,v retrieving revision 1.1 diff -u -p -r1.1 statemachine --- statemachine14 Jul 2017

Re: pledge ifstated

2017-07-16 Thread Rob Pierce
On Thu, Jul 13, 2017 at 09:16:14PM -0400, Rob Pierce wrote: > On Mon, Jul 10, 2017 at 01:21:58PM -0400, Rob Pierce wrote: > > The following diff is loosely based on the approach that was taken for > > pledging mountd. Other code/approaches leveraged from various network

simple ifstated pledge

2017-07-21 Thread Rob Pierce
With the most recent commit ifstated can now be pledged in a straight forward manner. A better pledge is possible with more work. Does it make sense to get this one in now? Rob Index: ifstated.c === RCS file:

pledge snmpctl

2017-07-25 Thread Rob Pierce
snmpclient pledges after calling chroot(2) and requires a dns promise for sendto(2) with non-NULL destination. Rob Index: snmpclient.c === RCS file: /cvs/src/usr.sbin/snmpctl/snmpclient.c,v retrieving revision 1.13 diff -u -p -r1.13

unused struct in dhcpd.h

2017-07-23 Thread Rob Pierce
This struct appears to be unused at the moment. Regards, Rob Index: dhcpd.h === RCS file: /cvs/src/usr.sbin/dhcpd/dhcpd.h,v retrieving revision 1.64 diff -u -p -r1.64 dhcpd.h --- dhcpd.h 24 Apr 2017 14:58:36 - 1.64 +++

broken base build at src/usr/lib/libpcap?

2017-07-23 Thread Rob Pierce
My build breaks at usr/lib/libpcap: cc -O2 -pipe -g -I. -I/usr/src/lib/libpcap -Dyylval=pcap_yylval -DHAVE_SYS_IOCCOM_H -DHAVE_SYS_SOCKIO_H -DHAVE_ETHER_HOSTTON -DHAVE_STRERROR -DHAVE_SOCKADDR_SA_LEN -DLBL_ALIGN -DHAVE_IFADDRS_H -DINET6 -DHAVE_BSD_IEEE80211 -c pcap.c -o pcap.o cc -O2 -pipe

Re: broken base build at src/usr/lib/libpcap?

2017-07-23 Thread Rob Pierce
> From: "Rob Pierce" <r...@2keys.ca> > To: "tech" <tech@openbsd.org> > Sent: Sunday, July 23, 2017 5:40:24 PM > Subject: broken base build at src/usr/lib/libpcap? > My build breaks at usr/lib/libpcap: Sorry, I jumped the gun. Works fine after another update.

ioctl under route promise for pledging snmpd

2017-07-26 Thread Rob Pierce
snmpe calls kif_update on an interface change which performs an ioctl with SIOCGIFDESCR, currently disallowed by pledge. No other network daemons do this. The only other programs that make this call appear to be ifconfig and systat. ifnet.if_description simply contains an optional user defined

Re: broken base build at src/usr/lib/libpcap?

2017-07-24 Thread Rob Pierce
> From: "Marc Espie" <es...@nerim.net> > To: "Rob Pierce" <r...@2keys.ca> > Cc: "tech" <tech@openbsd.org> > Sent: Sunday, July 23, 2017 7:36:29 PM > Subject: Re: broken base build at src/usr/lib/libpcap? > On Sun, Jul 23, 2017 at 0

ifstated whitespace var assignment diff

2017-07-01 Thread Rob Pierce
Remove variable assignment in declaration and add whitespace to improve readability. No functional change. Rob Index: ifstated.c === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v retrieving revision 1.45 diff -u -p -r1.45

Re: add simple ifstated regression test script

2017-07-02 Thread Rob Pierce
> From: "Sebastian Benoit" <be...@openbsd.org> > To: "Rob Pierce" <r...@2keys.ca> > Cc: "tech" <tech@openbsd.org> > Sent: Sunday, July 2, 2017 12:29:07 PM > Subject: Re: add simple ifstated regression test script > Rob Pierce(r..

ifstated ifsd_config variable name change

2017-07-02 Thread Rob Pierce
Second diff to rename additional "always" variable in struct ifsd_config. Requested by stsp@. Rob Index: ifstated.c === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v retrieving revision 1.47 diff -u -p -r1.47 ifstated.c ---

Re: rename variable in ifstated

2017-07-02 Thread Rob Pierce
On Sun, Jul 02, 2017 at 02:56:06PM +0200, Stefan Sperling wrote: > On Sat, Jul 01, 2017 at 05:53:54PM -0400, Rob Pierce wrote: > > never.never say always.always. > > > > Rename one of the "always" variables to "body" for improved readability. >

  1   2   >