Re: Optimize cerror on arm64

2017-03-18 Thread Mark Kettenis
> Date: Sat, 18 Mar 2017 14:58:36 -0700 > From: Philip Guenther > > > Hmm, the arm version still has the equivalent movn r1. I'll let > > guenther@ deal with that. > > Ah, but it's necessary there...for correct error return from lseek(). > 64bit archs never need the second

Re: Optimize cerror on arm64

2017-03-18 Thread Philip Guenther
On Sat, 18 Mar 2017, Mark Kettenis wrote: > > Date: Sat, 18 Mar 2017 17:20:21 +0100 > > From: Patrick Wildt > > > > On Sat, Mar 18, 2017 at 03:47:18PM +0100, Mark Kettenis wrote: > > > Just like we did on other architectures. > > > > > > ok? > > > > guenther@ had the same

Re: Optimize cerror on arm64

2017-03-18 Thread Mark Kettenis
> Date: Sat, 18 Mar 2017 17:20:21 +0100 > From: Patrick Wildt > > On Sat, Mar 18, 2017 at 03:47:18PM +0100, Mark Kettenis wrote: > > Just like we did on other architectures. > > > > ok? > > guenther@ had the same diff (but he also removed the movn x1), which > looked good to

Re: Optimize cerror on arm64

2017-03-18 Thread Patrick Wildt
On Sat, Mar 18, 2017 at 03:47:18PM +0100, Mark Kettenis wrote: > Just like we did on other architectures. > > ok? guenther@ had the same diff (but he also removed the movn x1), which looked good to me as well. Basically still ok patrick@. ;) > > > Index: lib/libc/arch/aarch64/sys/cerror.S >

Optimize cerror on arm64

2017-03-18 Thread Mark Kettenis
Just like we did on other architectures. ok? Index: lib/libc/arch/aarch64/sys/cerror.S === RCS file: /cvs/src/lib/libc/arch/aarch64/sys/cerror.S,v retrieving revision 1.2 diff -u -p -r1.2 cerror.S ---