Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

2017-06-25 Thread Sebastian Benoit
ok as wor the WELLKNOWN, what do other implementations do? If others print it or accept it as input, lets keep it. If not, remove it from both your diff and bgpctls output. /Benno Job Snijders(j...@instituut.net) on 2017.06.25 14:59:21 +0200: > Small update. > > I renamed the 'msb' argument

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

2017-06-25 Thread Job Snijders
On Sun, Jun 25, 2017 at 11:41:05PM +0200, Sebastian Benoit wrote: > ok > > as wor the WELLKNOWN, what do other implementations do? I'm not aware of other implementations that do a blanket replacement of "65535:" with something like "WELLKNOWN:" in their CLI output. Most implementations (after

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

2017-06-25 Thread Job Snijders
Small update. I renamed the 'msb' argument ('most significant bits') to 'part' to improve readability. In Community 15562:4, '15562' is part 0 and the '4' is part 1. Same type of logic might be useful down the road for Large Communities which would have 3 parts. - Job diff --git

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

2017-06-25 Thread Job Snijders
On Sun, Jun 25, 2017 at 02:09:22PM +0200, Peter Hessler wrote: > : $ bgpctl show rib community WELLKNOWN:0 > : .. > : $ bgpctl show rib community WELLKNOWN:* > : .. > > Eh, I don't really see a reason to have syntatic sugar for > '65535'. In this case, I'm

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

2017-06-25 Thread Peter Hessler
On 2017 Jun 23 (Fri) at 16:01:58 +0200 (+0200), Job Snijders wrote: :Dear team, : :This patch makes 'unknown' well-known communities more of a first-class :citizen. : :A powerful property of well-known communities is that (often) operators :can implement the feature associated with a given