Re: [PATCH] vhost_socket tweak

2004-02-18 Thread Geoffrey Young
sub vhost_socket { -my $module = shift; +my ($module, $nossl) = @_; local $Apache::TestRequest::Module = $module if $module; my $hostport = hostport(Apache::Test::config()); @@ -224,7 +224,7 @@ my($host, $port) = split ':', $hostport; my(%args) = (PeerAddr

Re: [PATCH] vhost_socket tweak

2004-02-18 Thread Joe Orton
On Wed, Feb 18, 2004 at 09:05:47AM -0500, Geoffrey Young wrote: sub vhost_socket { ... that all looks reasonable. Thanks for the review Geoff! ... that the appropriate status code is returned seems like a valid test that we would want to keep around. maybe keep this but issue another

Re: [PATCH] vhost_socket tweak

2004-02-18 Thread Joe Orton
On Wed, Feb 18, 2004 at 09:54:26AM -0500, Geoffrey Young wrote: I should have explained this... the issue is that in response to an HTTP request on an SSL port, mod_ssl in 2.0 issues an HTTP/0.9 response, i.e. it just spits out the response body without headers. This makes

Re: [PATCH] vhost_socket tweak

2004-02-18 Thread Geoffrey Young
Well, it gets my vote. If it were to be an argument, it would have to be stripped out of @_ before being passed through to LWP, which sounds like it could get messy. ok, give this a whirl and see if it works for you. --Geoff Index: Apache-Test/lib/Apache/TestRequest.pm

Re: [PATCH] vhost_socket tweak

2004-02-18 Thread Joe Orton
On Wed, Feb 18, 2004 at 10:40:51AM -0500, Geoffrey Young wrote: Well, it gets my vote. If it were to be an argument, it would have to be stripped out of @_ before being passed through to LWP, which sounds like it could get messy. ok, give this a whirl and see if it works for you. Yup,

Re: [PATCH] vhost_socket tweak

2004-02-18 Thread Geoffrey Young
Joe Orton wrote: On Wed, Feb 18, 2004 at 10:40:51AM -0500, Geoffrey Young wrote: Well, it gets my vote. If it were to be an argument, it would have to be stripped out of @_ before being passed through to LWP, which sounds like it could get messy. ok, give this a whirl and see if it works