Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Nicholas Marriott
We could change it to something like couldn't connect to server or ask is the server running? but I don't see much difference from failed to connect to server. I don't think it is sensible to mention sessions, for tmux the server is the process that contains the sessions by definition, we don't

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Nicholas Marriott
Hi I think the current message is fine. We describe what is meant by server in the first few paragraphs of the man page. On Wed, Apr 15, 2015 at 08:06:58PM +0530, Karthik K wrote: --- client.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/client.c

[PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Karthik K
When no sessions are present, tmux ls now displays an error Falied to connect: Connection Refused. This is confusing and creates an impression that tmux is present but refusing connections. The patch makes tmux display a message indicating that sessions may not be present. Karthik K (1): Give

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Karthik K
Although the explanation for what a server is, is given in the man page, the argument still holds. The error message just makes you think that there is something wrong with the connection. If it's not possible to patch the code, maybe atleast an entry can be added at the end of the manpage

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Karthik K
Hmm.. Your arguments do hold merit. It's just that everyone I know have been stumped by this message when they start using tmux. Just felt that the error message should be more descriptive explaining the most common reason for connection being refused. On Apr 15, 2015 8:33 PM, Nicholas Marriott

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Thomas Adam
On 15 April 2015 at 15:50, Karthik K hashken.dis...@gmail.com wrote: Although the explanation for what a server is, is given in the man page, the argument still holds. The error message just makes you think that there is something wrong with the connection. Which is correct; no sessions means

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Nicholas Marriott
I think we should change it to just no server running or something, it better matches the no sessions that you get if you try tmux attach: diff --git a/client.c b/client.c index 042ec92..e8d2b25 100644 --- a/client.c +++ b/client.c @@ -261,8 +261,12 @@ client_main(int argc, char **argv, int

Re: Negative length limit?

2015-04-15 Thread Nicholas Marriott
Actually I spoke too soon, should have tried to apply the diff first. Sorry. Your diff doesn't apply because it is against an older version and we changed it so that the length limits work with UTF-8. You'll need to take a look at the code in Git and probably add a function to do this in a safe

Re: patch for setting pane background color

2015-04-15 Thread Nicholas Marriott
Couple of fixes. BCE is a FLAG not a STRING, and we need to check with tty_term_flag not tty_term_has (so it wasn't actually making use of BCE at all even if the terminal supported it). Also don't use the pane colours for the borders. I like this, don't see any other problems so far. Index:

[tmux:tickets] #186 Moving tmux repo to Github

2015-04-15 Thread Karthik
--- ** [tickets:#186] Moving tmux repo to Github** **Status:** open **Labels:** github **Created:** Tue Apr 14, 2015 07:40 PM UTC by Karthik **Last Updated:** Tue Apr 14, 2015 07:40 PM UTC **Owner:** nobody Is there any reason that the tmux project still continues to use SourceForge and

Re: [tmux:tickets] #186 Moving tmux repo to Github

2015-04-15 Thread Roberto
I agree 100% with this. On Tue, Apr 14, 2015 at 9:40 PM, Karthik hash...@users.sf.net wrote: -- * [tickets:#186] http://sourceforge.net/p/tmux/tickets/186 Moving tmux repo to Github* *Status:* open *Labels:* github *Created:* Tue Apr 14, 2015 07:40 PM UTC by

Re: [tmux:tickets] #186 Moving tmux repo to Github

2015-04-15 Thread Thomas Adam
On 15 April 2015 at 10:34, Nicholas Marriott nicholas.marri...@gmail.com wrote: We don;t click our fingers and it moves, there are lots of things to consider, it will take work and there needs to be good reasons. Indeed. Being sheep for the sake of blindly following what the popular choice is

Re: [tmux:tickets] #186 Moving tmux repo to Github

2015-04-15 Thread Mark Volkmann
I'm not particularly concerned about whether tmux moves to Github, but I'm curious what features SourceForge has that Github doesn't. --- R. Mark Volkmann Object Computing, Inc. On Apr 15, 2015, at 5:31 AM, Thomas Adam tho...@xteddy.org wrote: On 15 April 2015 at 10:34, Nicholas Marriott

Re: [tmux:tickets] #186 Moving tmux repo to Github

2015-04-15 Thread Nicholas Marriott
We don;t click our fingers and it moves, there are lots of things to consider, it will take work and there needs to be good reasons. On Wed, Apr 15, 2015 at 10:42:26AM +0200, Roberto wrote: I agree 100% with this. On Tue, Apr 14, 2015 at 9:40 PM, Karthik [1]hash...@users.sf.net wrote: