cvs commit: jakarta-tomcat-4.0/webapps/admin/valve requestDumperValve.jsp accessLogValve.jsp

2002-04-09 Thread manveen
manveen 02/04/08 19:56:57 Modified:webapps/admin/valve accessLogValve.jsp Added: webapps/admin/valve requestDumperValve.jsp Log: Added request dumper valve page. Revision ChangesPath 1.2 +2 -2 jakarta-tomcat-4.0/webapps/admin/valve/accessLogValve.jsp

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costinm
On Mon, 8 Apr 2002, Larry Isaacs wrote: It's not so much having one util jar, but understanding the differences between jakarta-tomcat-connectors' tomcat-util.jar and connectors_util.jar. If they are the same, then I would prefer to use a single name. They are certainly not the same ( or

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RequestDumperValveForm.java

2002-04-09 Thread manveen
manveen 02/04/08 19:58:46 Added: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RequestDumperValveForm.java Log: Addes form bean for the request dumper valve page. Revision ChangesPath 1.1

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Constants.java InputBuffer.java OutputBuffer.java

2002-04-09 Thread Remy Maucherat
On Mon, 8 Apr 2002, Remy Maucherat wrote: I'd like those two to stay the way they are. They're not related to the hooks or actions. I/O should be handled as a special case IMO; faster + simpler. (could you remove the comments ?) Ok, but at least add a second parameter ( Request,

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread remm
remm02/04/09 01:59:48 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Remove tabs. - Add some comments. - Passing the request as an argument is useless (at least for the HTTP/1.1 processor), since there's a 1 - 1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread billbarker
billbarker02/04/09 00:00:10 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Actually implement RemoteHost lookup in the processor. Revision ChangesPath 1.17 +5 -1

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java

2002-04-09 Thread billbarker
billbarker02/04/08 21:33:53 Modified:coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Log: Do a correct check if the request is for a SSL attribute. The lookup is way too expensive to do it when it isn't needed. Revision Changes

Re: make path relative to server root in mod_jk2

2002-04-09 Thread jean-frederic clere
[EMAIL PROTECTED] wrote: On Mon, 8 Apr 2002 [EMAIL PROTECTED] wrote: My first idea is to add makeRoot() in jk_ws_service_t. But I have the problem that apache needs a pool (not a jk_pool) to call ap_server_root_relative(). Where could I get the pool? Actually, that would be a good idea

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread billbarker
billbarker02/04/09 00:02:53 Modified:coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java Log: Tie into the backend remoteAddr remoteHost lookup. The duplicates are ugly, but until we can safely stop the agressive recycling, they provide huge

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread billbarker
billbarker02/04/09 00:03:53 Modified:coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java Log: Fix Typo. Revision ChangesPath 1.6 +1 -1 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3/Tomcat3Request.java

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteRequest.java

2002-04-09 Thread remm
remm02/04/09 02:23:13 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteRequest.java Log: - Use the action to have the protocol handler compute the remote host. Revision ChangesPath 1.18 +12 -11

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote ActionCode.java

2002-04-09 Thread remm
remm02/04/09 02:23:40 Modified:coyote/src/java/org/apache/coyote ActionCode.java Log: - Coding style cleanup. Revision ChangesPath 1.6 +8 -3 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/ActionCode.java Index: ActionCode.java

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread remm
remm02/04/09 02:27:12 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Add comments. - It seems to me that getting the remote host is expensive, while getting the remote address is super cheap (I don't even think it

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread billbarker
billbarker02/04/08 21:18:02 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Make the SSL attributes functional (at least until we can do better). We still need the KeySize to be added to SSLSupport, but I'm leaving that for

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java

2002-04-09 Thread billbarker
billbarker02/04/08 21:23:04 Modified:coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Log: Hook-up the SSL attributes to the back-end. This should work reasonably well across connectors. Revision ChangesPath 1.4 +10 -2

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve - New directory

2002-04-09 Thread manveen
manveen 02/04/08 18:55:24 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve AccessLogForm.java

2002-04-09 Thread manveen
manveen 02/04/08 18:56:15 Added: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve AccessLogForm.java Log: Form bean for Access log valve page. Revision ChangesPath 1.1

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve AccessLogValveForm.java AccessLogForm.java

2002-04-09 Thread manveen
manveen 02/04/08 18:58:42 Added: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve AccessLogValveForm.java Removed: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve AccessLogForm.java Log: rename

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteRequest.java

2002-04-09 Thread remm
remm02/04/09 03:22:17 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteRequest.java Log: - RequestHost and requestAddr must be recycled. Revision ChangesPath 1.19 +6 -4

Apache 2.0.35 Linux RPM available

2002-04-09 Thread GOMEZ Henri
Hi to all, You could find the Apache 2.0.35 rpm for Linux at : http://ftp.falsehope.com/home/gomez/apache2/ apache2-2.0.35-1.src.rpm apache2-2.0.35-1.i386.rpm apache2-devel-2.0.35-1.i386.rpm apache2-manual-2.0.35-1.i386.rpm There are signed with my PGP key (the same used

DO NOT REPLY [Bug 7861] New: - Does not detect if included file has been updated

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7861. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 7863] New: - I have a problem when running Tomcat with IIS

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7863. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Tuesday, April 09, 2002 2:50 AM To: Tomcat Developers List Subject: RE: cvs commit: jakarta-tomcat build.xml On Mon, 8 Apr 2002, Larry Isaacs wrote: It's not so much having one util jar, but

Q: implementation of servlet/jsp specification level?

2002-04-09 Thread Hugh J. L.
Hi, Does current Tomcat 4 implement all requirements of Servlet specification 2.3 and JSP specification 1.2? Thanks. Hugh __ Do You Yahoo!? Yahoo! Tax Center - online filing with TurboTax http://taxes.yahoo.com/ -- To unsubscribe, e-mail:

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread GOMEZ Henri
tomcat_util.jar ( in container ) has all of the tools. The instructions for installing Coyote on Tomcat 3.3.x say to replace connectors_util.jar with j-t-c's tomcat-utils.jar. Since I plan to include Coyote in Tomcat 3.3.2 distribution, then the util jar we ship in common loader must remain

[GUMP] Build Failure - Tomcat 3.x

2002-04-09 Thread Craig McClanahan
This email is autogenerated from the output from: http://jakarta.apache.org/builds/gump/2002-04-09/jakarta-tomcat.html Buildfile: build.xml detect: msg.jdk12: [echo] Detected JDK1.2

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpRequestBase.java

2002-04-09 Thread glenn
glenn 02/04/09 05:53:45 Modified:catalina/src/share/org/apache/catalina/connector HttpRequestBase.java Log: Fix for a bug where parseParameters() could go into an infinite loop trying to read the HTTP Request POST content if the content sent was less

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector LocalStrings.properties

2002-04-09 Thread glenn
glenn 02/04/09 06:19:20 Modified:catalina/src/share/org/apache/catalina/connector LocalStrings.properties Log: Fix for a bug where parseParameters() could go into an infinite loop trying to read the HTTP Request POST content if the content sent was

cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs/config jk.xml

2002-04-09 Thread glenn
glenn 02/04/09 06:27:29 Modified:webapps/tomcat-docs/config jk.xml Log: Add a note about 1 to 1 httpd to processor mapping with Apache Revision ChangesPath 1.6 +4 -0 jakarta-tomcat-4.0/webapps/tomcat-docs/config/jk.xml Index: jk.xml

cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs/config ajp.xml

2002-04-09 Thread glenn
glenn 02/04/09 06:29:10 Modified:webapps/tomcat-docs/config Tag: tomcat_40_branch ajp.xml Log: Add a note about 1 to 1 httpd to processor mapping with Apache Revision ChangesPath No revision No revision 1.2.2.8 +4

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpRequestBase.java LocalStrings.properties

2002-04-09 Thread glenn
glenn 02/04/09 06:29:37 Modified:catalina/src/share/org/apache/catalina/connector Tag: tomcat_40_branch HttpRequestBase.java LocalStrings.properties Log: Fix for a bug where parseParameters() could go into an infinite loop trying

Re: Q: implementation of servlet/jsp specification level?

2002-04-09 Thread todd tredeau
http://jakarta.apache.org/tomcat/index.html Tomcat 4.0.x. Tomcat 4.0.3 is the current production quality release. Tomcat 4.0 is the next generation of Tomcat. The 4.0 servlet container (Catalina) has been developed from the ground up for flexibility and performance. Version 4.0 implements

Re: Why won't you die?

2002-04-09 Thread Remy Maucherat
Ok... I'm facing this little problem... I have a servlet creating a RMI registry, and that binds to a port, creates a non-daemon Thread... Yadayadayada... You know where I want to end up to... Now, catalina.sh stop doesn't work anymore, because I found no apparent way of shutting down that

DO NOT REPLY [Bug 7873] New: - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7873. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7873. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyoteConstants.java InputBuffer.java OutputBuffer.java

2002-04-09 Thread costinm
Ok, ok. I'll work around it. Costin On Tue, 9 Apr 2002, Remy Maucherat wrote: On Mon, 8 Apr 2002, Remy Maucherat wrote: I'd like those two to stay the way they are. They're not related to the hooks or actions. I/O should be handled as a special case IMO; faster + simpler.

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7873. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Jk2: removing the servlet and the http connector

2002-04-09 Thread costinm
Hi, As you noticed, we will use coyote for connector and avoid the duplication. There are few more things that need to be fixed, but it seems everything will actually work better. I still like the idea of packing the connector as a webapp and doing all config in web.xml - but having more

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7873. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7873. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Constants.java InputBuffer.java OutputBuffer.java

2002-04-09 Thread Remy Maucherat
Ok, ok. I'll work around it. No need to. You didn't make your intentions known, and I assumed that you had in mind changes in the HTTP/1.1 connector, which I considered to be a bad idea. So since it's been cleared, +1 for adding Request and Response as a parameter to the methods in InputBuffer

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7873. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 7880] New: - If a TLV flags flags an error during the translation phase, a fatal translation error is not returned (HTTP 500).

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7880. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Larry Isaacs wrote: The instructions for installing Coyote on Tomcat 3.3.x say to replace connectors_util.jar with j-t-c's tomcat-utils.jar. Since j-t-c tomcat-utils are a subset of tomcat-utils.jar from container/ Sorry, I didn't read the instructions for Coyote - I'm

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread costin
costin 02/04/09 10:13:51 Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Implement the input buffer. Recycle the req/res ( coyote http adapter doesn't call recycle on coyoteRequest/coyoteResponse - which is actually a very good idea ). Add a workaround

Re: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Remy Maucherat
On Tue, 9 Apr 2002, Larry Isaacs wrote: The instructions for installing Coyote on Tomcat 3.3.x say to replace connectors_util.jar with j-t-c's tomcat-utils.jar. Since j-t-c tomcat-utils are a subset of tomcat-utils.jar from container/ Sorry, I didn't read the instructions for Coyote -

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread costin
costin 02/04/09 10:23:49 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: If host header is not set, use the local socket to set the local port and hostname. Remy - I'm not sure if this is correct, but I see no other way to

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread costin
costin 02/04/09 10:26:07 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java Log: Remy, I think response.finish() must be called - otherwise we get no COMMIT callback. I put a workaround in ajp, but if this is correct behavior it's

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Tuesday, April 09, 2002 2:09 PM To: Tomcat Developers List Subject: RE: cvs commit: jakarta-tomcat build.xml On Tue, 9 Apr 2002, Larry Isaacs wrote: The instructions for installing Coyote on

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED]] Sent: Tuesday, April 09, 2002 1:15 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat build.xml On Tue, 9 Apr 2002, Larry Isaacs wrote: The instructions for installing Coyote on Tomcat

Re: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, April 09, 2002 10:14 AM Subject: Re: cvs commit: jakarta-tomcat build.xml On Tue, 9 Apr 2002, Larry Isaacs wrote: The instructions for installing Coyote on

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread Remy Maucherat
costin 02/04/09 10:26:07 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java Log: Remy, I think response.finish() must be called - otherwise we get no COMMIT callback. I put a workaround in ajp, but if this is correct behavior

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java CoyoteConnector2.java

2002-04-09 Thread remm
remm02/04/09 10:47:07 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector2.java Added: coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java Log: - Add a socket factory to allow

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4CoyoteResponse.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: public class CoyoteResponse @@ -485,6 +485,7 @@ throws IOException { // Writing leftover bytes outputBuffer.close(); +coyoteResponse.finish(); } This is called no matter what right

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote InputBuffer.java

2002-04-09 Thread costin
costin 02/04/09 10:57:13 Modified:coyote/src/java/org/apache/coyote InputBuffer.java Log: Added (another) piece of comment ( after hunting for NPEs :-) The way InputBuffer is used is different from OutputBuffer - the param is empty, the byte[]. The protocol is supposed to

Re: tomcat native webdav

2002-04-09 Thread Szymon Stasik
it looks to be even worse for url-parrern: /webdav/* i've found: PROPFIND /context/webdav HTTP/1.1 207 1904 and PROPFIND /context/webdav/aaa HTTP/1.1 404 585 while webdav exists only in / of webapplication and there is also aaa directory inside the webdav (/webdav/aaa) regards, Szymon -- To

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread remm
remm02/04/09 10:59:42 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Modify Costin's patch: - In HTTP/1.1, we must default to the protocol's default (spec requirement); this was fixed recently (bug 6668) - In

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread costin
costin 02/04/09 11:02:19 Modified:coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java Log: Merged few more methods from ajp. Use the same buffer for addresses, pass the info to Coyote Request Revision ChangesPath 1.7 +56 -0

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote InputBuffer.java

2002-04-09 Thread Remy Maucherat
costin 02/04/09 10:57:13 Modified:coyote/src/java/org/apache/coyote InputBuffer.java Log: Added (another) piece of comment ( after hunting for NPEs :-) The way InputBuffer is used is different from OutputBuffer - the param is empty, the byte[]. The protocol is supposed

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread Remy Maucherat
On Tue, 9 Apr 2002, Remy Maucherat wrote: public class CoyoteResponse @@ -485,6 +485,7 @@ throws IOException { // Writing leftover bytes outputBuffer.close(); +coyoteResponse.finish(); } This is called no matter

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costinm
I'll commit a fix. Larry, is it ok if we call the buildfile for j-t-c from 3.3's build.xml ? ( 4.0 is doing that too ). The problem is the order which may be tricky - tomcat33 depends on j-t-c utils and it will copy coyote. But coyote depens on tomcat33 beeing build, so it can find the

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote InputBuffer.java OutputBuffer.java

2002-04-09 Thread costin
costin 02/04/09 11:15:21 Modified:coyote/src/java/org/apache/coyote InputBuffer.java OutputBuffer.java Log: Added a second parameter allowing IB and OB to be implemented stateless ( or statefull, depending on the rest of the code ) I'll add the extra

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java Response.java

2002-04-09 Thread costin
costin 02/04/09 11:19:27 Modified:coyote/src/java/org/apache/coyote Request.java Response.java Log: Add the second param in calling. The tomcat3 and 4 adapters are calling the request and response methods, it doesn't seem to be any other place to depend on this ( except the

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java InternalOutputBuffer.java

2002-04-09 Thread remm
remm02/04/09 11:21:23 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java InternalOutputBuffer.java Log: - Add some code to prevent problems when calling finish or commit twice. Revision ChangesPath 1.22 +3 -0

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Tuesday, April 09, 2002 3:11 PM To: Tomcat Developers List Subject: RE: cvs commit: jakarta-tomcat build.xml I'll commit a fix. Larry, is it ok if we call the buildfile for j-t-c from 3.3's

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters ChunkedInputFilter.java ChunkedOutputFilter.java IdentityInputFilter.java IdentityOutputFilter.java VoidInputFilter.java VoidOutputFilter.java

2002-04-09 Thread costin
costin 02/04/09 11:35:54 Modified:http11/src/java/org/apache/coyote/http11 InputFilter.java InternalInputBuffer.java InternalOutputBuffer.java OutputFilter.java http11/src/java/org/apache/coyote/http11/filters

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor.java CoyoteInterceptor2.java CoyoteProcessor.java CoyoteRequest.java CoyoteResponse.java Tomcat3Adapter.java Tomcat3Request.java Tomcat3Response.java

2002-04-09 Thread costin
costin 02/04/09 11:37:24 Modified:coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor.java CoyoteInterceptor2.java CoyoteProcessor.java CoyoteRequest.java CoyoteResponse.java Tomcat3Adapter.java

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread Remy Maucherat
costin 02/04/09 10:23:49 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: If host header is not set, use the local socket to set the local port and hostname. Remy - I'm not sure if this is correct, but I see no other

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat33/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java

2002-04-09 Thread costin
costin 02/04/09 11:43:11 Removed: jk/java/org/apache/jk/server/tomcat33/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java Log: Removed duplicated config. mod_jk2 will use a different syntax and a single

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyoteInputBuffer.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: BTW, this is a very cool idea - it avoids one copy and allocations, and simplifies the code. But it deserves a comment :-). Yes, indeed. I worked hard so that there wouldn't be any useless copy. Yes, excelent !. One question for future

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: ( this used to be in the 3.3-specific code, and is needed to construct redirects, etc ) +//The info from socket is usually acurate +// req.setServerPort(80); That's not good. If no host is specified with

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4CoyoteResponse.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: Can you add a small comment in Response and clearly indicate who should call it - I'm fine with any, but we should do it consistenlty in the 2 adapters and in the 2 protocols. The class which is implementing the Adapter interface is calling it

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Bill Barker
+ +remoteAddrMB = coyoteRequest.remoteAddr(); + remoteHostMB = coyoteRequest.remoteHost(); + serverNameMB = coyoteRequest.serverName(); + + This forces the lookup to always be per-request, when it would be much nicer to do it per-connection. + +public void

cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costin
costin 02/04/09 12:33:43 Modified:.build.xml Log: As discussed on tomcat-dev, place j-t-c/tomcat-utils.jar in common, rename the old one to container-utils. Call the ant files for j-t-c to build and clean Revision ChangesPath 1.169 +53 -31

cvs commit: jakarta-tomcat/src/etc modules.xml

2002-04-09 Thread costin
costin 02/04/09 12:34:20 Modified:src/etc modules.xml Log: Add CoyoteInterceptor2. Revision ChangesPath 1.14 +2 -0 jakarta-tomcat/src/etc/modules.xml Index: modules.xml === RCS file:

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread Remy Maucherat
On Tue, 9 Apr 2002, Remy Maucherat wrote: Can you add a small comment in Response and clearly indicate who should call it - I'm fine with any, but we should do it consistenlty in the 2 adapters and in the 2 protocols. The class which is implementing the Adapter interface is calling

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread Remy Maucherat
On Tue, 9 Apr 2002, Remy Maucherat wrote: ( this used to be in the 3.3-specific code, and is needed to construct redirects, etc ) +//The info from socket is usually acurate +// req.setServerPort(80); That's not good. If no host is specified with

cvs commit: jakarta-tomcat/src/etc server.xml

2002-04-09 Thread costin
costin 02/04/09 12:43:27 Modified:src/etc server.xml Log: Changed to CoyoteInterceptor2. ( after we are comfortable with it, we'll rename it to CoyoteInterceptor ) Added the commented out impl of Coyte-based jk. Revision ChangesPath 1.97 +8 -2

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3Tomcat3Request.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Bill Barker wrote: + +remoteAddrMB = coyoteRequest.remoteAddr(); + remoteHostMB = coyoteRequest.remoteHost(); + serverNameMB = coyoteRequest.serverName(); + + This forces the lookup to always be per-request, when it would be much nicer to

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: port if it is not the standard one. But if the Host header is correct, it'll allways be the same thing as the getPort on socket - if it's https on standard port, the port will be 443 as the default, etc. Even if the port in the host header

JAAS IN TOMCAT 4.0.x

2002-04-09 Thread Williams Mark L DLPC
I've been trying to get JAAS capabilities to work (JDK 1.4.0, Tomcat 4.0.1, 4.0.3, Solaris 8) and am getting odd (and unsatisfactory) results. Is there any reference that identifies if JAAS should work under Tomcat 4.0.x? BTW, I get different behavior between 4.0.1 and 4.0.3 with the same

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread Remy Maucherat
On Tue, 9 Apr 2002, Remy Maucherat wrote: port if it is not the standard one. But if the Host header is correct, it'll allways be the same thing as the getPort on socket - if it's https on standard port, the port will be 443 as the default, etc. Even if the port in the host

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat33 JkConfig33.java JkRequest33.java JkResponse33.java JkServlet33.java Worker33.java

2002-04-09 Thread costin
costin 02/04/09 13:15:09 Removed: jk/java/org/apache/jk/server/tomcat33 JkConfig33.java JkRequest33.java JkResponse33.java JkServlet33.java Worker33.java Log: Removed the old connector, use Coyote instead. -- To unsubscribe, e-mail:

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat40/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java

2002-04-09 Thread costin
costin 02/04/09 13:16:54 Removed: jk/java/org/apache/jk/server/tomcat40/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java Log: Removed the duplicate config. We'll use the one in ajp for mod_jk1, a different

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat40 JkConfig40.java JkConnector.java JkRequest40.java JkResponse40.java LocalStrings.properties Worker40.java

2002-04-09 Thread costin
costin 02/04/09 13:17:47 Removed: jk/java/org/apache/jk/server/tomcat40 JkConfig40.java JkConnector.java JkRequest40.java JkResponse40.java LocalStrings.properties Worker40.java Log: Removed the duplicated tomcat4 connector. We'll

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread costin
costin 02/04/09 13:19:53 Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Update to the stateless-enabled Input/OutputBuffer interfaces. Clean up the code ( jk2 is mostly stateless ) Revision ChangesPath 1.6 +42 -58

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Bill Barker
- Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, April 09, 2002 1:45 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java On Tue, 9 Apr 2002, Bill Barker wrote:

DO NOT REPLY [Bug 7891] New: - Class loader collision

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7891. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: Yes, that's what the fixed patch does. So I did it right, I think :) Thanks. Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

DO NOT REPLY [Bug 7891] - Class loader collision

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7891. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf C2BConverter.java

2002-04-09 Thread costin
costin 02/04/09 13:39:06 Modified:util/java/org/apache/tomcat/util/buf C2BConverter.java Log: Backward-compatible change to C2BConverter. Needed by jk - this would avoid duplicating the code. The duplicated class was needed to allow jk to work with unmodified versions of

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/util C2B.java

2002-04-09 Thread costin
costin 02/04/09 13:39:38 Removed: jk/java/org/apache/jk/util C2B.java Log: Remove the duplicated class. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread costin
costin 02/04/09 13:40:44 Modified:jk/java/org/apache/jk/common JkInputStream.java jk/java/org/apache/jk/core JkHandler.java jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Revision ChangesPath 1.5 +10 -0

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3Tomcat3Request.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Bill Barker wrote: Unless I'm missing something. These fields are recycled per-request, so we lose the value of remoteHost/remoteAddr and will have to look it up again. If the buffers are identical, then the o.a.c.Request field is recycled as well. At least for

CoyoteInterceptor2

2002-04-09 Thread costinm
Bill, Do you think we can move to CoyoteInterceptor2 and Protocol ? It seems to be working for both http and ajp - it is still less stable than your original one, but I think we're close. Your call. Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands,

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread remm
remm02/04/09 13:51:06 Modified:jk/java/org/apache/jk/common JkInputStream.java jk/java/org/apache/jk/server JkCoyoteHandler.java Log: - Remove old package from imports. Revision ChangesPath 1.6 +0 -1

cvs commit: jakarta-tomcat-connectors/jk/native2 build.xml

2002-04-09 Thread jfclere
jfclere 02/04/09 13:57:19 Modified:jk/native2 build.xml Log: Add unless HAVE_APR to compile it without APR. Revision ChangesPath 1.17 +2 -0 jakarta-tomcat-connectors/jk/native2/build.xml Index: build.xml

cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache13 mod_jk2.c

2002-04-09 Thread jfclere
jfclere 02/04/09 14:00:38 Modified:jk/native2/common jk_config.c jk_workerEnv.c jk/native2/server/apache13 mod_jk2.c Log: Add $(serverRoot) handling for apache13 and jk_config.c (it cores when modifying the value parameter (in the read only part of executable).

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Bill Barker
- Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, April 09, 2002 1:45 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java On Tue, 9 Apr 2002, Bill Barker wrote:

Re: CoyoteInterceptor2

2002-04-09 Thread Bill Barker
I'm +1 for this. But for at least a little while, I'd rather just deprecate CoyoteInterceptor and related classes. - Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, April 09, 2002 1:48 PM Subject: CoyoteInterceptor2 Bill, Do

  1   2   >