cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TldLocationsCache.java

2004-02-04 Thread luehe
luehe 2004/02/04 12:01:13 Modified:jasper2/src/share/org/apache/jasper/compiler TldLocationsCache.java Log: Ported (from org.apache.catalina.startup.TldConfig) ability to ignore (for TLD scanning purposes) JARs (in the classloader delegation chain

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-02-04 Thread luehe
luehe 2004/02/04 13:55:12 Modified:catalina/src/conf web.xml Log: Upgraded default web.xml to Servlet 2.4. Let me know if there are any objections. Revision ChangesPath 1.31 +5 -4 jakarta-tomcat-catalina/catalina/src/conf/web.xml Index: web.xml

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-02-04 Thread luehe
luehe 2004/02/04 14:25:26 Modified:catalina/src/conf web.xml Log: Reverted upgrade because of validation errors Revision ChangesPath 1.32 +4 -5 jakarta-tomcat-catalina/catalina/src/conf/web.xml Index: web.xml

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java

2004-02-03 Thread luehe
luehe 2004/02/03 12:20:19 Modified:jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java Log: Convert selected tag attribute types to their Fully-Qualified-Name equivalents if the taglib is JSP 1.2 based. This has been discussed

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java

2004-02-03 Thread Jan Luehe
[EMAIL PROTECTED] wrote: luehe 2004/02/03 12:20:19 Modified:jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java Log: Convert selected tag attribute types to their Fully-Qualified-Name equivalents if the taglib is JSP 1.2 based

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-02-03 Thread luehe
luehe 2004/02/03 12:28:56 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Reverted change that was done in revision 1.34 Revision ChangesPath 1.35 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java

2004-02-03 Thread Jan Luehe
Jan Luehe wrote: [EMAIL PROTECTED] wrote: luehe 2004/02/03 12:20:19 Modified:jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java Log: Convert selected tag attribute types to their Fully-Qualified-Name equivalents if the taglib is JSP 1.2

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-02-02 Thread luehe
luehe 2004/02/02 15:08:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Expose handshake failure as error, so it gets logged unconditionally Revision ChangesPath 1.34 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspFragmentHelper.java

2004-01-30 Thread luehe
luehe 2004/01/30 17:57:08 Modified:jasper2/src/share/org/apache/jasper/runtime JspFragmentHelper.java Log: Fixed Bugtraq 4984188 (pageContext used in *.tag files) Implicit pageContext object no longer exposed in tag files, to comply with JSP spec

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-01-27 Thread luehe
luehe 2004/01/26 15:13:51 Modified:catalina/src/share/org/apache/catalina/core ApplicationContext.java Log: Fixed Bugtraq 4873423 by ignoring any (trailing) path params (separated by ;) when attempting to map path passed

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote RequestGroupInfo.java

2004-01-27 Thread luehe
luehe 2004/01/27 09:59:27 Modified:coyote/src/java/org/apache/coyote RequestGroupInfo.java Log: Avoid java.util.ConcurrentModificationException seen with very high load. It seems synchronization has become necessary since the addition of the removeRequestProcessor() method

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationResponse.java ApplicationHttpResponse.java

2004-01-27 Thread luehe
luehe 2004/01/27 16:02:06 Modified:catalina/src/share/org/apache/catalina/core ApplicationResponse.java ApplicationHttpResponse.java Log: Ignore setBufferSize()/setLocale() calls on included response Revision ChangesPath

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2004-01-21 Thread luehe
luehe 2004/01/21 10:46:19 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: Fix for Bugtraq 4932547: Replaced SC_INTERNAL_SERVER_ERROR with SC_FORBIDDEN if anonymous access (caused by missing login-config/auth-method in web.xml) is not allowed

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Response.java

2004-01-20 Thread luehe
luehe 2004/01/20 11:38:38 Modified:catalina/src/share/org/apache/catalina Response.java Log: Fix for Bugtraq 4655010: Method sendError() of class HttpServletResponse does not send multi byte data Use response encoding when generating error report

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java

2004-01-20 Thread luehe
luehe 2004/01/20 11:39:00 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java Log: Fix for Bugtraq 4655010: Method sendError() of class HttpServletResponse does not send multi byte data Use response

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2004-01-20 Thread luehe
luehe 2004/01/20 15:07:37 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: Fixed indentation Revision ChangesPath 1.109 +6 -6 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2003-12-04 Thread luehe
luehe 2003/12/04 18:29:47 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Have JspC.execute() propagate its exceptions. In some cases, there used to be no way for a caller to determine whether an exception occurred, because some exceptions would be swallowed

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime PerThreadTagHandlerPool.java

2003-11-25 Thread luehe
luehe 2003/11/25 10:05:06 Modified:jasper2/src/share/org/apache/jasper/runtime PerThreadTagHandlerPool.java Log: General cleanup (for instance, perThread.get() was always returning null) Revision ChangesPath 1.4 +46 -61 jakarta-tomcat

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java

2003-11-20 Thread luehe
luehe 2003/11/20 12:56:28 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java Log: Backing out this change for the time being, as it breaks some of the Servlet compatibility tests. I've suggested to the Servlet spec lead

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java

2003-11-20 Thread Jan Luehe
Remy Maucherat wrote: Larry Isaacs wrote: Hi Jan, This looked like a good idea, so I ported it to Tomcat 4.1.x. I'll go ahead and un-port it for consistincy with Tomcat 5. I thought it was a good idea too. Too bad this has to be unported. I'll see what I can do to have this fix back in. Maybe

[PATCH][jakarta-servletapi-5/jsr152] Upgrade to JSTL 1.1

2003-11-20 Thread Jan Luehe
Patch is attached. Also, please update jstl.jar and standard.jar in jakarta-servletapi-5/jsr152/examples/WEB-INF/lib with their JSTL-1.1 counterparts from http://www.tux.org/pub/net/apache/dist/jakarta/taglibs/standard/binaries/ Thanks! Jan Executing ssh-askpass to query the password...

Re: [VOTE] New committer: Mark Thomas

2003-11-20 Thread Jan Luehe
+1. Jan Remy Maucherat wrote: Hi, I'd like to nominate Mark Thomas as a Tomcat committer. He has contibuted a significant amount of fixes already, and does what nobody else does: roam Bugzila to fix older issues and cleanup the database. He has special interest in the WebDAV code, which

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java

2003-11-19 Thread luehe
luehe 2003/11/19 09:18:35 Modified:util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java Log: Added check for keyAlias!=null Revision ChangesPath 1.19 +2 -2 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java

2003-11-19 Thread luehe
luehe 2003/11/19 10:02:53 Modified:util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java Log: The KeyStore implementation (JKS) of the SUN provider converts alias names to lower case, so we need to do the same Revision ChangesPath

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java

2003-11-19 Thread luehe
luehe 2003/11/19 17:14:31 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java Log: Do not store the charset specified in ServletRequest.setCharacterEncoding() if the request params have already been parsed or a reader/inputstream

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java

2003-11-18 Thread luehe
luehe 2003/11/18 17:19:44 Modified:util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java Log: Throw exception if keyAlias does not identify key entry in connector's key store, to prevent infinite loop

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/res - New directory

2003-11-18 Thread luehe
luehe 2003/11/18 17:19:54 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/res - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/res LocalStrings.properties

2003-11-18 Thread luehe
luehe 2003/11/18 17:20:47 Added: util/java/org/apache/tomcat/util/net/jsse/res LocalStrings.properties Log: Throw exception if keyAlias does not identify key entry in connector's key store, to prevent infinite loop

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java

2003-11-11 Thread luehe
luehe 2003/11/11 15:19:29 Modified:jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java Log: Fixed Bugtraq 4952390 ('' operator used in simple Math throws an error: When used with taglib) Revision ChangesPath 1.36 +4 -4

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java

2003-11-06 Thread luehe
luehe 2003/11/06 10:23:20 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java Log: Moved the adjustment of maxThreads settings 10 from setMaxThreads() to adjustLimits() Revision ChangesPath 1.17 +6 -8 jakarta-tomcat-connectors/util/java/org

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/res LocalStrings.properties

2003-11-06 Thread luehe
luehe 2003/11/06 11:05:23 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java util/java/org/apache/tomcat/util/threads/res LocalStrings.properties Log: More i18n: added 'threadpool.thread_error' error code Revision Changes

Re: Connector ObjectName includes address

2003-11-05 Thread Jan Luehe
Bill Barker wrote: Currently, connector objectname includes address in this format: domain:type=Connector,port=8080,address=0.0.0.0. This causes a problem when IPV6 addresses are used since IPV6 addresses include colons. The javax.management.ObjectName doesn't allow to have colon character in

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-03 Thread luehe
luehe 2003/11/03 13:13:01 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Reverted support for maxThreads=1 Revision ChangesPath 1.27 +9 -24 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java Index

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/res LocalStrings.properties

2003-11-03 Thread luehe
luehe 2003/11/03 13:54:24 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java util/java/org/apache/tomcat/util/threads/res LocalStrings.properties Log: Correct any maxThreads settings 10 Revision ChangesPath 1.16

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: I guess I don't understand what makes 1 bad but 2 OK. Where do we draw the line of what is a stupid config? Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable minimal value for maxThreads; let's say 10 - 20. Remy, I

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Jan Luehe
Remy, I agree we should help users come up with reasonable config values, but I'm just afraid rejecting any maxThreads 10 or 20 will send the wrong message, as if there was a bug in the way we dispatch incoming requests that requires at least 10 threads. Nope, I disagree. If maxThreads (say)

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread luehe
luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request: SEVERE: All threads (1) are currently busy

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Jan Luehe
Remy Maucherat wrote: Bill Barker wrote: [EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/res - New directory

2003-10-28 Thread luehe
luehe 2003/10/28 12:00:42 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/res - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/res LocalStrings.properties

2003-10-28 Thread luehe
luehe 2003/10/28 12:03:01 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java Added: util/java/org/apache/tomcat/util/threads/res LocalStrings.properties Log: Added support for localized messages Revision ChangesPath 1.15

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator AuthenticatorBase.java

2003-10-20 Thread luehe
luehe 2003/10/20 19:58:42 Modified:catalina/src/share/org/apache/catalina/authenticator AuthenticatorBase.java Log: Fixed indentation/removed tabs Revision ChangesPath 1.12 +66 -47 jakarta-tomcat-catalina/catalina/src/share/org/apache

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters BufferedInputFilter.java

2003-10-17 Thread luehe
luehe 2003/10/17 11:45:40 Modified:http11/src/java/org/apache/coyote/http11 Constants.java Http11Processor.java Added: http11/src/java/org/apache/coyote/http11/filters BufferedInputFilter.java Log: In case the server needs

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator SSLAuthenticator.java

2003-10-17 Thread luehe
luehe 2003/10/17 11:47:43 Modified:catalina/src/share/org/apache/catalina/authenticator SSLAuthenticator.java Log: In case the server needs to reinitiate SSL handshake (with client auth enabled), consume request body and buffer it, so that it does

[5.0] No sessions purged in Context with backgroundProcessorDelay 0?

2003-10-15 Thread Jan Luehe
I may be totally wrong here, but it seems that if the backgroundProcessorDelay property on a StandardContext is set to something greater than zero (default is -1, inherited from ContainerBase), the context's sessions are never purged. This is because in ContainerBase$ContainerBackgroundProcessor,

Re: [5.0] No sessions purged in Context with backgroundProcessorDelay 0?

2003-10-15 Thread Jan Luehe
Thanks for confirming, Remy! I'll make these changes. Jan Remy Maucherat wrote: Jan Luehe wrote: I may be totally wrong here, but it seems that if the backgroundProcessorDelay property on a StandardContext is set to something greater than zero (default is -1, inherited from ContainerBase

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java StandardContext.java

2003-10-15 Thread luehe
luehe 2003/10/15 10:24:16 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java StandardContext.java Log: Start/stop ContainerBackgroundProcessor thread as part of StandardContext.start()/stop(), respectively. Revision Changes

How to make CLIENT-CERT protection work?

2003-10-15 Thread Jan Luehe
Consider the following scenario: 1. Client sends POST request (with content type other than application/x-www-form-urlencoded) to SSL-enabled server (with client auth turned off). 2. Server parses request header, and determines that the resource identified by the request-URI is

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Response.java

2003-10-14 Thread Jan Luehe
Bill, this.contentType = contentType.substring(0, beginCharsetParam); -String tail = contentType.substring(beginCharsetParam + 1); +// Trim the semicolon preceding the charset +int charsetSemi = this.contentType.lastIndexOf(';'); This is still not working

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Response.java

2003-10-14 Thread luehe
luehe 2003/10/14 12:21:25 Modified:coyote/src/java/org/apache/coyote Response.java Log: Take into accout that there may be other content-type params whose names end in charset when determining response charset Revision ChangesPath 1.29 +41 -21 jakarta-tomcat

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Response.java

2003-10-13 Thread luehe
luehe 2003/10/13 14:53:45 Modified:coyote/src/java/org/apache/coyote Response.java Log: Fixed Bugtraq 4934442 (Response Content-Type has no charset even though setCharacterEncoding was called) This fixes the problem where a response char setting via

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Response.java

2003-10-13 Thread luehe
luehe 2003/10/13 16:36:23 Modified:coyote/src/java/org/apache/coyote Response.java Log: Support separators other than space preceding charset= Revision ChangesPath 1.28 +13 -9 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-10-10 Thread luehe
luehe 2003/10/10 10:40:39 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Quote value of 'classid' attribute Revision ChangesPath 1.213 +11 -18 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java

2003-10-05 Thread luehe
luehe 2003/10/05 14:00:38 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java Log: Set the tcpNoDelay property on the underlying socket even if this property has not been set explicitly on CoyoteConnector (in which case

Re: [5.0] Schedule change

2003-10-02 Thread Jan Luehe
Hans/Remy, I don't know more than you do about when J2EE 1.4 will be released, but the specs are starting to move through final approval now, so I'm pretty sure it will happen in a month or two. Three months for running a few Beta releases instead of releasing it as something it's not doesn't

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java

2003-10-01 Thread luehe
luehe 2003/10/01 09:15:33 Modified:jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java Log: Fixed indentation Revision ChangesPath 1.55 +16 -16 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy, As I mentioned in my private email to you, it may not always be practical to rely on the list of noTldJars configured in catalina.properties if you bundle Tomcat with your own product. That's why I added the setProperty method on CatalinaProperties, in order to be able to override the value

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java CatalinaProperties.java catalina.properties

2003-09-26 Thread luehe
luehe 2003/09/26 12:31:16 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java CatalinaProperties.java catalina.properties Log: Reverted patch for JAR exclusion list Revision ChangesPath 1.30 +6 -39

cvs commit: jakarta-tomcat-catalina/catalina/src/conf catalina.properties

2003-09-26 Thread luehe
luehe 2003/09/26 12:32:08 Modified:catalina/src/conf catalina.properties Log: Reverted patch for JAR exclusion list Revision ChangesPath 1.9 +0 -5 jakarta-tomcat-catalina/catalina/src/conf/catalina.properties Index: catalina.properties

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy Maucherat wrote: OK, I'll revert my patch (and leave it as a private extension), until we have found a better solution that everybody agrees on. Thanks :) As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-09-26 Thread luehe
luehe 2003/09/26 16:09:08 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: Added hard-coded list of names of JARs that are known not to contain any TLDs. This list can be overridden using the new TldConfig.setNoTldJars

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Jan Luehe
at runtime. The code that is embedding Tomcat would call CatalinaProperties.setProperty() *before* starting Tomcat. I leave the judgement up to the community. Thanks, Jan Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2003/09/24 12:09:29 Modified:catalina/src/share/org/apache/catalina

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Jan Luehe
Hans, thanks for stepping in. sorry, but I don't see which part of our email exchange you found very frustrating. As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. [...] Sorry for not jumping in earlier in this discussion. When I implemented

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Jan Luehe
Hans, good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I don't give them that option (with regards to this) in LiteWebServer. The only place I look for shared

Re: [PROPOSAL] Narrow down the list of JARs to be scanned for TLDs

2003-09-23 Thread Jan Luehe
Petr, I haven't committed any changes related to the proposal yet, as I was waiting for more feedback. The changes I committed in TldConfig.java were unrelated. As Jan has already pointed out, it should improve the startup time for Tomcat 5 (since scanning TLD files is a major hit). I too

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-09-23 Thread luehe
luehe 2003/09/23 11:48:36 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: Do not search *shared* JARs that are known not to contain any TLDs for TLDs. JARs in WEB-INF/lib are *always* searched, as mandated by the spec

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java catalina.properties

2003-09-23 Thread luehe
luehe 2003/09/23 12:47:52 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java catalina.properties Log: Made noTldJars are configurable property in catalina.properties, as suggested by Jeanfrancois Arcand Revision ChangesPath

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-09-23 Thread luehe
luehe 2003/09/23 13:06:07 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: improved javadocs Revision ChangesPath 1.27 +10 -3 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup

cvs commit: jakarta-tomcat-catalina/catalina/src/conf catalina.properties

2003-09-23 Thread luehe
luehe 2003/09/23 14:10:28 Modified:catalina/src/conf catalina.properties Log: Added noTldJars property Revision ChangesPath 1.8 +5 -0 jakarta-tomcat-catalina/catalina/src/conf/catalina.properties Index: catalina.properties

[PROPOSAL] Narrow down the list of JARs to be scanned for TLDs

2003-09-22 Thread Jan Luehe
Currently, any JARs in the classloader delegation chain of a webapp's classloader are scanned for packaged TLDs. This is convenient, as it allows a JAR-packaged taglib to be simply dropped in common/lib and shared by all webapps, rather than requiring each webapp to bundle the taglib in its own

Re: [PROPOSAL] Narrow down the list of JARs to be scanned for TLDs

2003-09-22 Thread Jan Luehe
an idea of the proposal's benefit. Currently, we're scanning the following global JARs for TLDs (depending on your runtime, there may be even more!), none of which contain any TLDs: /home/luehe/ws/jakarta-tomcat-5/build/common/lib/servlet-api.jar /home/luehe/ws/jakarta-tomcat-5/build/common/lib

Re: [PROPOSAL] Narrow down the list of JARs to be scanned for TLDs

2003-09-22 Thread Jan Luehe
Amy Roh wrote: The proposal is to add a configurable String property (tldJarNames) on Context, which specifies the comma-separated list of JAR file names (without any path info) that must be scanned for TLDs. +1 Amy :-) Yeah! Thanks! :) Jan

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-09-22 Thread luehe
luehe 2003/09/22 14:42:45 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: Fixed javadocs for tldScanJar(File file) Revision ChangesPath 1.21 +2 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-09-22 Thread luehe
luehe 2003/09/22 15:25:20 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: Avoid TLD-scanning the JARs under WEB-INF lib twice per webapp. When navigating the webapp classloader delegation chain in search for global JARs

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-09-22 Thread luehe
luehe 2003/09/22 16:56:11 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: Do not let the parsing error of a single TLD disrupt the parsing of remaining TLDs in the JAR Revision ChangesPath 1.23 +10 -14

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java

2003-09-22 Thread luehe
luehe 2003/09/22 18:11:24 Modified:jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java Log: Fixed javadocs of parseTLD, which used to return boolean but was changed to void Revision ChangesPath 1.48 +4 -9 jakarta

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TldLocationsCache.java

2003-09-22 Thread luehe
luehe 2003/09/22 18:19:53 Modified:jasper2/src/share/org/apache/jasper/compiler TldLocationsCache.java Log: Avoid scanning the JARs under WEB-INF/lib twice Revision ChangesPath 1.21 +18 -39 jakarta-tomcat-jasper/jasper2/src/share/org

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2003-09-18 Thread Jan Luehe
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2003/09/17 16:26:33 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java Log: Fix for Bugtraq 4924326 (JMX registrations of servlets that map to the same jsp-file use the same name

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java

2003-09-18 Thread luehe
luehe 2003/09/18 15:50:08 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java Log: Separated JSESSION cookie configuration into its own method, which may be overridden Revision ChangesPath 1.17 +26 -15 jakarta

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2003-09-17 Thread luehe
luehe 2003/09/17 16:26:33 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java Log: Fix for Bugtraq 4924326 (JMX registrations of servlets that map to the same jsp-file use the same name) This allows for the following 2 servlets

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2003-09-16 Thread luehe
luehe 2003/09/16 11:56:35 Modified:catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java Log: Fixed Bugtraq 4923455 (Sessions created in the target webapp of a cross-context are invalid) Revision ChangesPath 1.13 +5 -4

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util RequestUtil.java

2003-09-12 Thread luehe
luehe 2003/09/12 12:54:57 Modified:catalina/src/share/org/apache/catalina/util RequestUtil.java Log: Reverted patch for 4918152 (using % in the value of jsp:param corrupts the query string), as it is not needed for JSP 2.0. JSP.5.6 (jsp:param) has clarified the potential

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util RequestUtil.java

2003-09-10 Thread luehe
luehe 2003/09/10 18:59:51 Modified:catalina/src/share/org/apache/catalina/util RequestUtil.java Log: Fix for 4918152 (using % in the value of jsp:param corrupts the query string) Patch provided by [EMAIL PROTECTED] Revision ChangesPath 1.5 +11 -6

cvs commit: jakarta-tomcat-catalina/webapps/docs class-loader-howto.xml

2003-09-08 Thread Jan Luehe
I think the current description of the classloader delegation model from a web application's perspective is still somewhat misleading. Currently, the document describes this order: /WEB-INF/classes of your web application /WEB-INF/lib/*.jar of your web application Bootstrap classes of

Re: [5.0] Planning

2003-09-08 Thread Jan Luehe
On that topic, is there a reason that Tomcat 5.0.x still uses commons-logging-api.jar instead of commons-logging.jar? If you're putting this jar in common/lib, you'd avoid the need for webapps to have to include commons-logging.jar themselves in order to use the default functionality. Craig,

cvs commit: jakarta-tomcat-catalina/webapps/docs class-loader-howto.xml

2003-09-08 Thread luehe
luehe 2003/09/08 15:03:32 Modified:webapps/docs class-loader-howto.xml Log: - Fixed classloader delegation order as seen from webapp perspective. - Removed org.apache.commons.logging.* from list of packages that trigger delegation to parent (the doc already mentions

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2003-09-04 Thread luehe
luehe 2003/09/04 10:45:40 Modified:catalina/src/share/org/apache/catalina/core ApplicationContext.java Log: Get the absolute path to the work dir, so that JARs in /WEB-INF/lib can be found Revision ChangesPath 1.20 +5 -5 jakarta

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java

2003-09-03 Thread luehe
luehe 2003/09/03 15:10:33 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java Log: Fixed Bugtraq 4916164 (Tomcat's default charset for Preferred locale overrides page directive) The HTTP spec mandates

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspFactoryImpl.java

2003-09-02 Thread luehe
luehe 2003/09/02 13:41:00 Modified:jasper2/src/share/org/apache/jasper/runtime JspFactoryImpl.java Log: Fixed Bugtraq 4863026 (JSP error page mechanism fails intermittently to display contents of error page) Problem was caused by the fact that one

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java ParserController.java

2003-08-29 Thread luehe
luehe 2003/08/29 12:31:22 Modified:jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java ParserController.java Log: Added support for JSP.6.2.4: A JSP document with a DOCTYPE declaration must be validated by the container

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java TagLibraryInfoImpl.java

2003-08-26 Thread luehe
luehe 2003/08/25 17:08:33 Modified:jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java TagLibraryInfoImpl.java Log: - Prepend urn:jsptld to uri values that represent relative paths when adding xmlns:prefix attribute on the root of the JSP

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2003-08-26 Thread luehe
luehe 2003/08/25 15:25:55 Modified:jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java jasper2/src/share/org/apache/jasper/resources messages.properties Log: Ensure that jsp:root is root element in JSP

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSESocketFactory.java

2003-08-25 Thread luehe
luehe 2003/08/25 11:38:52 Modified:util/java/org/apache/tomcat/util/net/jsse JSSESocketFactory.java Log: Also consider last element in comma-separated list of ciphers, or the case where the list contains a single element and no commas Revision

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java

2003-08-25 Thread luehe
luehe 2003/08/25 10:37:26 Modified:util/java/org/apache/tomcat/util/net/jsse JSSE14SocketFactory.java Log: Also consider last element in comma-separated protocols list, or the case where the list contains a single element and no commas :) Revision

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java

2003-08-25 Thread luehe
luehe 2003/08/25 12:46:50 Modified:jasper2/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java Log: Supply taglib's unique id (instead of the value of the uri argument in the directive) to the TagLibraryValidator's validate method

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Response.java

2003-08-25 Thread luehe
luehe 2003/08/25 14:27:04 Modified:coyote/src/java/org/apache/coyote Response.java Log: javadocs fix Revision ChangesPath 1.24 +2 -2 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java Index: Response.java

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Response.java

2003-08-25 Thread luehe
luehe 2003/08/25 14:35:06 Modified:coyote/src/java/org/apache/coyote Response.java Log: More javadocs fixes Revision ChangesPath 1.25 +1 -1 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java Index: Response.java

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-22 Thread luehe
luehe 2003/08/22 12:42:58 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Avoid defining multiple getServletInfo() methods (one for each page directive with an 'info' attribute) Revision ChangesPath 1.201 +22 -5 jakarta-tomcat

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

2003-08-22 Thread luehe
luehe 2003/08/22 16:18:24 Modified:catalina/src/share/org/apache/catalina/startup TldConfig.java Log: Minor optimization: Avoid scanning duplicate JARs for TLDs Revision ChangesPath 1.17 +33 -20 jakarta-tomcat-catalina/catalina/src

<    1   2   3   4   5   6   7   8   9   >