Below is a patch for bug 22857, bug 22858 and one additional issue I found
whilst looking at the other issues. I am concerned that the patch may only work
on windows platforms and would appreciate it if someone with non-Windows
knowledge could review this patch.
I have included TC5 and TC4
I see a few possible issues.
1) Don't append \, instead use File.separatorChar
2) is case sensitivity an issue where you are doing the
command.endsWith(.pl) || command.endsWith(.cgi) commands?
It seems like getCanonicalPath will, on some platforms, return the
exact case of the file as it is on
Oh, ignore my item #2, I didn't see that you were DELETING the
command.endsWith stuff, not adding it.
Still, I think the item number one - not assuming the separator is a
\ is needed for OS portability, right? It looks like this was just
committed as-is, not using File.separator or
Jeff Tulley wrote:
Still, I think the item number one - not assuming the separator is a
\ is needed for OS portability, right? It looks like this was just
committed as-is, not using File.separator or File.separatorChar
You need to use File.separator for escaping double quote on different OS?
Ah, once again I'm up in the night. *big sheepish grin*
I run at 1600x1200, and the double set of quotes looked like one quote.
I guess my clue should have been that you would've put \\ for a
single backslash.
Sorry! I saw the mention of a need for a review by those who deal with
other OS's
