cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11AprProcessor.java

2005-07-31 Thread remm
remm2005/07/31 02:23:02 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11AprProcessor.java Log: - Maybe Eclipse created the bad imports to the AJP package for me. Revision ChangesPath 1.124 +0 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11AprProcessor.java

2005-07-25 Thread remm
remm2005/07/25 08:32:48 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11AprProcessor.java Log: - Oops, fix bad cut paste error (the condition is inverted), which causes problems when using the default ports. Revision

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2005-03-14 Thread remm
remm2005/03/14 07:33:11 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Log: - The new thread pool currently uses the endpoint to store its

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2005-02-27 Thread keith
keith 2005/02/27 13:30:52 Modified:coyote/src/java/org/apache/coyote Tag: TOMCAT_5_0 Response.java coyote/src/java/org/apache/coyote/tomcat4 Tag: TOMCAT_5_0 OutputBuffer.java

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2005-02-09 Thread keith
keith 2005/02/09 21:25:42 Modified:http11/src/java/org/apache/coyote/http11/filters Tag: TOMCAT_5_0 IdentityOutputFilter.java coyote/src/java/org/apache/coyote Tag: TOMCAT_5_0 Response.java

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2005-01-06 Thread remm
remm2005/01/06 04:43:15 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Content length should be ignored if there is chunking. Revision ChangesPath 1.117 +8 -8

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: billbarker2004/11/21 22:42:46 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Reverting reversion of patch ;-) Sorry for the trouble ;) Rémy

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-21 Thread Remy Maucherat
Bill Barker wrote: Bill Barker wrote: [EMAIL PROTECTED] wrote: billbarker2004/11/19 19:04:28 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: If we are in the error state, we aren't going to keep-alive. So don't lie to the UA that we

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-21 Thread billbarker
billbarker2004/11/21 22:42:46 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Reverting reversion of patch ;-) Revision ChangesPath 1.115 +1 -1

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-20 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Saturday, November 20, 2004 1:17 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java [EMAIL PROTECTED] wrote

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-20 Thread billbarker
billbarker2004/11/20 13:59:49 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Reverting patch per vote on tomcat-dev Revision ChangesPath 1.114 +1 -1

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-20 Thread Remy Maucherat
Bill Barker wrote: [EMAIL PROTECTED] wrote: billbarker2004/11/19 19:04:28 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: If we are in the error state, we aren't going to keep-alive. So don't lie to the UA that we are. Fix for Bug

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-20 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Saturday, November 20, 2004 2:40 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Bill Barker wrote

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-11-19 Thread billbarker
billbarker2004/11/19 19:04:28 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: If we are in the error state, we aren't going to keep-alive. So don't lie to the UA that we are. Fix for Bug #32292 Revision ChangesPath

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-14 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] The issue is that there's no value in this: it would likely take 5 minutes for an attacker to figure out the webserver is running Tomcat. The Server header is maybe the less visible of them (and gives little information when compared to the

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2004-09-14 Thread funkman
funkman 2004/09/14 17:16:05 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Log: Allow for customized server header at config time. So now one can do this: Connector port=8080 server=TinFoil Hats R US

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-14 Thread Remy Maucherat
Mark Thomas wrote: From: Remy Maucherat [mailto:[EMAIL PROTECTED] The issue is that there's no value in this: it would likely take 5 minutes for an attacker to figure out the webserver is running Tomcat. The Server header is maybe the less visible of them (and gives little information when

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: markt 2004/08/23 12:29:35 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Fix bug 16254 - Server header appears twice after a call to response.setHeader() Revision ChangesPath 1.105 +3 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread remm
remm2004/09/13 11:25:08 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Revert patch. I disalike patches which cause a performance hit for the sole interest of embeddors who don't contribute anything. The X-Powered-By

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread Tim Funk
This is an often asked for feature. My pref is for it to be a configuration in the Connector. Then the only added overhead is in during init. For example ... protected serverHeader = Constants.SERVER; ... setServerHeader() ... getServerHeader() ... ...

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread Mark Thomas
I disalike patches which cause a performance hit for the sole interest of embeddors who don't contribute anything. Agreed. But this wasn't the reasoning behind the patch. From the original bug report (16254) I believe the reporter had a security motive. To repeat some of my earlier comments

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread Remy Maucherat
Mark Thomas wrote: I disalike patches which cause a performance hit for the sole interest of embeddors who don't contribute anything. Agreed. But this wasn't the reasoning behind the patch. From the original bug report (16254) I believe the reporter had a security motive. To repeat some of

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread remm
remm2004/09/13 14:39:40 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Cleanup a little access to the headers using a local variable. - Use direct access to the headers whenever possible (extra checks were done in

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] My position remains that the above reasons are sufficient justification for the patch to remain. My position remains the same as well. Making the value of the server header configurable, as per Tim's suggestion earlier in this thread,

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-13 Thread Remy Maucherat
Mark Thomas wrote: Making the value of the server header configurable, as per Tim's suggestion earlier in this thread, would meet the user requirement described in bug 16254 which is my main concern. Providing this is done in a way that doesn't impact performance, would you find this an acceptable

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-12 Thread markt
markt 2004/09/12 13:39:12 Modified:http11/src/java/org/apache/coyote/http11 Tag: TOMCAT_5_0 Http11Processor.java Log: Backport fix for bug 16254 Revision ChangesPath No revision No revision 1.100.2.2 +3 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-09-01 Thread remm
remm2004/09/01 03:10:11 Modified:catalina/src/share/org/apache/catalina/valves RequestFilterValve.java http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Use the JDK 1.4 regexp API, which is a

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread markt
markt 2004/08/23 12:29:35 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Fix bug 16254 - Server header appears twice after a call to response.setHeader() Revision ChangesPath 1.105 +3 -1

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: markt 2004/08/23 12:29:35 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Fix bug 16254 - Server header appears twice after a call to response.setHeader() I don't see any use for this. IMO, the server

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Monday, August 23, 2004 1:01 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java [EMAIL PROTECTED] wrote: markt

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Mark Thomas
The reporter of the bug was trying to use a filter to override the contents of the server header and set it to no name. They didn't say so, but I am guessing there was a security motive behind their actions. Mark -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Remy Maucherat
Mark Thomas wrote: The reporter of the bug was trying to use a filter to override the contents of the server header and set it to no name. They didn't say so, but I am guessing there was a security motive behind their actions. Well, that's not very convincing. Can't they recompile if they want

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Mark Thomas
From: Bill Barker [mailto:[EMAIL PROTECTED] - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Monday, August 23, 2004 1:01 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Mark Thomas wrote: The reporter of the bug was trying to use a filter to override the contents of the server header and set it to no name. They didn't say so, but I am guessing there was a security motive behind their actions. Well,

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-20 Thread billbarker
billbarker2004/08/20 19:51:37 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Check that the browser actually sent a user-agent header before using it. Fix for Bug #30770 Reported By: Elmar Haneke [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2004/07/27 17:43:44 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Fixed Bugtraq 6152759 (Default charset not included in Content-Type response header if no char encoding was specified). According

Re: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Service Client Fnac.com
Chère Cliente, Cher Client, Merci de nous avoir contactés. Vous venez d'envoyer un message à une adresse ne permettant pas de recevoir d'e-mail. Pour trouver les réponses à vos questions sur vos commandes, sur les produits, sur le site, consultez nos pages d'aide en ligne en cliquant sur :

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Henri Gomez
Service Client Fnac.com wrote: Chère Cliente, Cher Client, Merci de nous avoir contactés. Vous venez d'envoyer un message à une adresse ne permettant pas de recevoir d'e-mail. Pour trouver les réponses à vos questions sur vos commandes, sur les produits, sur le site, consultez nos pages d'aide en

Re: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Service Client Fnac.com
Chère Cliente, Cher Client, Merci de nous avoir contactés. Vous venez d'envoyer un message à une adresse ne permettant pas de recevoir d'e-mail. Pour trouver les réponses à vos questions sur vos commandes, sur les produits, sur le site, consultez nos pages d'aide en ligne en cliquant sur :

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Remy Maucherat
Henri Gomez wrote: Service Client Fnac.com wrote: Chère Cliente, Cher Client, Merci de nous avoir contactés. Vous venez d'envoyer un message à une adresse ne permettant pas de recevoir d'e-mail. Pour trouver les réponses à vos questions sur vos commandes, sur les produits, sur le site, consultez

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Remy Maucherat
Remy Maucherat wrote: Cool. So after all the efforts I'm doing to optimize, you casually add GC, because the servlet API is completely stupid ? So -1 for your patch: you need to rework it. I also didn't read all that funny stuff in the specification, so where does it come from ? ;) I thought

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Jan Luehe
Remy, Remy Maucherat wrote: Remy Maucherat wrote: Cool. So after all the efforts I'm doing to optimize, you casually add GC, because the servlet API is completely stupid ? So -1 for your patch: you need to rework it. I also didn't read all that funny stuff in the specification, so where does it

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread Remy Maucherat
Jan Luehe wrote: yes, sorry, I had forgotten about that case. Believe, I didn't commit yesterday's patch simply because I don't have anything better to do. It's come up as a compliance issue which had been masked by an unrelated problem that was fixed. I thought the issue caused enough trouble

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-28 Thread luehe
luehe 2004/07/28 11:52:17 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Reverted previous patch, because it would reintroduce the problem of sending image/gif; charset=iso-8859-1, which nobody can read. Revision Changes

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-07-27 Thread luehe
luehe 2004/07/27 17:43:44 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Fixed Bugtraq 6152759 (Default charset not included in Content-Type response header if no char encoding was specified). According to the Servlet 2.4

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java InternalInputBuffer.java

2004-06-01 Thread remm
remm2004/06/01 07:34:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java InternalInputBuffer.java Log: - Bug 29166: Tweak expectation handling so that if the expectation isn't satisfied, we don't attempt to swallow the request's

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-03-30 Thread hgomez
hgomez 2004/03/30 13:50:11 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: gzip compression could also be used in HTTP 1.0 Revision ChangesPath 1.99 +5 -2

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-02-29 Thread remm
remm2004/02/29 14:51:56 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Make sure HexUtils is accessed before some output is made. - Ugly fix for bug 27299, until a better one is found. Doing a PA on write is not a good

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-02-04 Thread remm
remm2004/02/04 08:32:50 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Make sure a filter is always added in all cases. Likely the case where there was an error wasn't handled well. Bug 26662. Revision Changes

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2004-01-22 Thread remm
remm2004/01/22 10:26:53 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Log: - Allow configuring the header size (for most use cases, it was too big, and since it represents 75% of the memory allocated by

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-01-14 Thread remm
remm2004/01/14 03:12:50 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Correctly initialize arrays (Java is not C ;-) ). - Also add some logging. Revision ChangesPath 1.94 +33 -24

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-01-14 Thread Henri Gomez
[EMAIL PROTECTED] a écrit : remm2004/01/14 03:12:50 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Correctly initialize arrays (Java is not C ;-) ). Arg, my fault :)

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-01-14 Thread Remy Maucherat
Henri Gomez wrote: [EMAIL PROTECTED] a écrit : remm2004/01/14 03:12:50 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Correctly initialize arrays (Java is not C ;-) ). Arg, my fault :) The feature works very well. Very

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-01-14 Thread Henri Gomez
Remy Maucherat a écrit : Henri Gomez wrote: [EMAIL PROTECTED] a écrit : remm2004/01/14 03:12:50 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Correctly initialize arrays (Java is not C ;-) ). Arg, my fault :) The

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-01-08 Thread remm
remm2004/01/08 05:08:13 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Report an exception which occurred during a low level flush. Revision ChangesPath 1.93 +1 -0

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread jfarcand
jfarcand2003/12/02 08:27:11 Modified:coyote/src/java/org/apache/coyote Request.java ActionCode.java catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java http11/src/java/org/apache/coyote/http11

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Jeanfrancois Arcand
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/02 08:27:11 Modified:coyote/src/java/org/apache/coyote Request.java ActionCode.java catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java http11/src/java/org/apache/coyote/http11 Http11Processor.java Log:

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Remy Maucherat
Jeanfrancois Arcand wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/02 08:27:11 Modified:coyote/src/java/org/apache/coyote Request.java ActionCode.java catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java http11/src/java/org/apache/coyote/http11

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Hans Bergsten
Remy Maucherat wrote: [...] Now the big question is actually what the new getLocalPort call should return. If you need an extra localPort (and its friend getLocalName - did you notice the getLocalName() call was always returning whatever hostname was in the host header) field in the request

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, December 02, 2003 8:59 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java [EMAIL PROTECTED] wrote

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, December 02, 2003 9:47 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Jeanfrancois Arcand wrote

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Jeanfrancois Arcand
Hans Bergsten wrote: Remy Maucherat wrote: [...] Now the big question is actually what the new getLocalPort call should return. If you need an extra localPort (and its friend getLocalName - did you notice the getLocalName() call was always returning whatever hostname was in the host header)

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread jfarcand
jfarcand2003/12/02 15:01:01 Modified:coyote/src/java/org/apache/coyote Request.java ActionCode.java catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java http11/src/java/org/apache/coyote/http11

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-02 Thread Remy Maucherat
Hans Bergsten wrote: Remy Maucherat wrote: [...] Now the big question is actually what the new getLocalPort call should return. If you need an extra localPort (and its friend getLocalName - did you notice the getLocalName() call was always returning whatever hostname was in the host header)

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread jfarcand
jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of hardcoded value. HttpServletRequest.getLocalPort() is currently broken if the port are not the default one. Revision

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of hardcoded value. HttpServletRequest.getLocalPort() is currently broken if the port are not the default one. This looks wrong. I

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Jeanfrancois Arcand
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of hardcoded value. HttpServletRequest.getLocalPort() is currently broken if the port are not the default

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Remy Maucherat
Jeanfrancois Arcand wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of hardcoded value. HttpServletRequest.getLocalPort() is currently broken if the

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Jeanfrancois Arcand
Remy Maucherat wrote: Jeanfrancois Arcand wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of hardcoded value. HttpServletRequest.getLocalPort()

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Remy Maucherat
Jeanfrancois Arcand wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of hardcoded value.

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Jeanfrancois Arcand
Remy Maucherat wrote: Jeanfrancois Arcand wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Use the socket info instead of

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread jfarcand
jfarcand2003/12/01 15:58:53 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Revert my last commit based on Remy's feedback. Revision ChangesPath 1.90 +4 -4

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-12-01 Thread Bill Barker
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, December 01, 2003 12:44 PM Subject: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java jfarcand2003/12/01 12:44:14 Modified:http11/src/java/org

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-11-21 Thread amyroh
amyroh 2003/11/21 13:10:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Fix NPE - was thrown from org.apache.coyote.RequestInfo.getRemoteAddr when getting remoteAddr via JMX. Revision ChangesPath 1.88 +18 -9

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-11-05 Thread remm
remm2003/11/05 03:38:47 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Fix bug 24428: no continue if not HTTP/1.1. Revision ChangesPath 1.86 +1 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-10-01 Thread hgomez
hgomez 2003/10/01 00:54:09 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: More setters for gzip compression support. Fix problems with getRemoteAddr, getRemoteHost. Tested with TC 3.3.2-dev Revision Changes

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-10-01 Thread Henri Gomez
[EMAIL PROTECTED] a écrit : hgomez 2003/10/01 00:54:09 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: More setters for gzip compression support. Here is the correction for getRemoteAddr(), getRemoteHost(), getRemotePort(). I

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-10-01 Thread Remy Maucherat
Henri Gomez wrote: [EMAIL PROTECTED] a écrit : hgomez 2003/10/01 00:54:09 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: More setters for gzip compression support. Here is the correction for getRemoteAddr(), getRemoteHost(),

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-10-01 Thread Henri Gomez
Remy Maucherat a écrit : Henri Gomez wrote: [EMAIL PROTECTED] a écrit : hgomez 2003/10/01 00:54:09 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: More setters for gzip compression support. Here is the correction for

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-10-01 Thread hgomez
hgomez 2003/10/01 03:22:15 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Replace Tabs by Space (I forgot about Tab Police :) Revision ChangesPath 1.81 +98 -98

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-09-07 Thread remm
remm2003/09/07 11:04:58 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Make the update of the stats an explicit call (I believe it is valid to call recycle multiple times, and it is hard to avoid with HTTP keepalive).

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-08-30 Thread billbarker
billbarker2003/08/29 19:38:06 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Make certain that we are still in an https session before looking for certs. Submitted By: Mark Thomas [EMAIL PROTECTED] Revision Changes

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-08-30 Thread billbarker
billbarker2003/08/29 19:45:02 Modified:http11/src/java/org/apache/coyote/http11 Tag: coyote_10 Http11Processor.java Log: Port patch. Submitted by: Mark Thomas [EMAIL PROTECTED] Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-08-19 Thread remm
remm2003/08/19 09:15:21 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Avoid a NPE if requesting the remote address between requests or before processing any request. Revision ChangesPath 1.75 +1 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-08-17 Thread remm
remm2003/08/17 07:52:30 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Use less aggressive socket timout reduction. - Fix calculation of a request processing time (it must not include the time waiting for data in

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-08-14 Thread remm
remm2003/08/05 05:26:54 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Fix bug 9351: parsing IPv6 hostnames (in IP form, obviously). - Submitted by Masashi Yamaguchi. Thanks ! Revision ChangesPath 1.73 +9

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-29 Thread remm
remm2003/07/29 11:53:20 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Reduce timeout and disable keepalive when the server starts running out or processors (of course, if servlet processing times are too long, or is

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-13 Thread billbarker
billbarker2003/07/13 14:52:06 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: It seems I need to learn the difference between true and false :(. Revision ChangesPath 1.71 +1 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-13 Thread billbarker
billbarker2003/07/13 14:53:07 Modified:http11/src/java/org/apache/coyote/http11 Tag: coyote_10 Http11Processor.java Log: Porting patch. Revision ChangesPath No revision No revision 1.55.2.3 +1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-06 Thread billbarker
billbarker2003/07/05 23:16:00 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Re-activate dropping the connection on serious protocol errors. Also adding Remy's suggestion to check the exception, as well as checking the status

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-06 Thread billbarker
billbarker2003/07/05 23:23:40 Modified:http11/src/java/org/apache/coyote/http11 Tag: coyote_10 Http11Processor.java Log: Port Patch for closing connections on bad requests. Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-04 Thread billbarker
billbarker2003/07/04 01:17:37 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Drop connections on high HTTP errors. Fix for bug #21219 Reported By: [EMAIL PROTECTED] Revision ChangesPath 1.68 +3 -0

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-07-04 Thread billbarker
billbarker2003/07/04 18:39:42 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Reverting previous patch. I included the code that httpd actually uses, in case somebody else likes the idea. However, I left it commented out, so

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2003-06-06 Thread luehe
luehe 2003/06/05 09:42:48 Modified:coyote/src/java/org/apache/coyote Request.java http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Log: Removed setSocket() method from org.apache.catalina.Request, since it

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2003-06-06 Thread Bill Barker
the deprecated Http11Connector. - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, June 05, 2003 9:42 AM Subject: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java luehe 2003/06

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2003-06-06 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, June 05, 2003 10:54 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Bill

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-06-06 Thread luehe
luehe 2003/06/05 12:46:49 Modified:coyote/src/java/org/apache/coyote Request.java http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Undid previous changes Revision ChangesPath 1.22 +0 -20

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-03-23 Thread remm
remm2003/03/23 00:50:16 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Also set the state in the request info. Revision ChangesPath 1.61 +8 -0

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-03-23 Thread remm
remm2003/03/23 08:08:48 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Make a difference between keepalive and ended. Revision ChangesPath 1.62 +5 -1

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-03-23 Thread remm
remm2003/03/23 10:58:29 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Set the state as ended when going out of the loop (otherwise, threads get reported as keepalive). Revision ChangesPath 1.63 +4 -5

  1   2   >