Re: [Toybox] [Patches] - Some more static analysis fixes

2014-10-09 Thread Rob Landley
On 10/07/14 00:50, Ashwini Sharma wrote: Hi Rob, List, Attached are few more static analysis fixes. This includes issues like resource leaks, logical dead codes etc... chgrp.c: Issue is in case when CFG_FREE and verbose mode enabled. Garbage output was there. comm.c: loop error You

Re: [Toybox] [Patches] - Some more static analysis fixes

2014-10-09 Thread David Seikel
On Thu, 09 Oct 2014 23:43:25 -0500 Rob Landley r...@landley.net wrote: --- getty.c.patch: I actually have a pending cleanup to getty I haven't checked in for ages because I haven't got a serial port setup lying around to test. It redoes the speed calculatons to look like: Er, serial port