Re: [Toybox] [PATCH] losetup: fix the race.

2019-08-09 Thread Rob Landley
On 8/9/19 5:45 AM, Rob Landley wrote: > So it's not /etc/passwd we're clashing on, it's two calls to /dev/loop-control > returning the same loop device and one of them claiming it, and the other > getting -EBUSY. And THAT means what we need to do is detect EBUSY and loop > back > around to

Re: [Toybox] [PATCH] losetup: fix the race.

2019-08-09 Thread Rob Landley
On 8/5/19 8:43 PM, enh via Toybox wrote: > ah, i haven't reproduced that one. > > this patch fixes an issue that was easily reproduced with: First time I looked at this I got distracted by the unrelated: - if (0 <= (i = ioctl(cfd, 0x4C82))) { // LOOP_CTL_GET_FREE + if (0 <= (i =

Re: [Toybox] Toybox in Devuan / Debian. Was: [PATCH] losetup: fix the race.

2019-08-09 Thread David Seikel
On Thu, 8 Aug 2019 21:55:02 -0500 Rob Landley said : > On 8/8/19 9:00 AM, David Seikel wrote: > > Now that you mention it Devuan has a busybox package, via Debian, > > but no toybox package. If we want to do something about that the > > question becomes - do we push it into Debian, or push it