Re: [Toybox] Lots of libc's.

2022-08-31 Thread David Seikel
I guess the real question I want an answer to is which is the best libc? Rob obviously has his opinions, and I'd like to hear them. No doubt others on this list have their useful opinions to. For my purposes small, fast, high quality, pick three. Working across multiple operating systems would

Re: [Toybox] "bad xform" not very helpful

2022-08-31 Thread David Seikel
On 2022-08-31 18:18:15, enh via Toybox wrote: >it does by default. that's what i turned off as a workaround for this bug. Um how does one using toybox as the foundation for something else actually call any random toy directly? Is there a vararg calltoy() function I missed? >On Wed, Aug

Re: [Toybox] "bad xform" not very helpful

2022-08-31 Thread enh via Toybox
it does by default. that's what i turned off as a workaround for this bug. On Wed, Aug 31, 2022, 18:15 David Seikel wrote: > On 2022-08-31 14:55:24, enh via Toybox wrote: > >On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > > > >

Re: [Toybox] "bad xform" not very helpful

2022-08-31 Thread David Seikel
On 2022-08-31 14:55:24, enh via Toybox wrote: >On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > >On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: > > On 8/15/22 18:50, enh via Toybox wrote: > > and here's their

Re: [Toybox] "bad xform" not very helpful

2022-08-31 Thread enh via Toybox
On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > >> >> >> On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: >> >>> On 8/15/22 18:50, enh via Toybox wrote: >>> > and here's their minimized repro case: >>> > >>> > echo > /tmp/foo.txt; echo

Re: [Toybox] [PATCH] getfattr.c: fix overlayfs merged dir stuck

2022-08-31 Thread Rob Landley
On 8/31/22 12:00, Weizhao Ouyang wrote: > On 2022/8/31 18:48, Rob Landley wrote: >> On 8/31/22 05:35, Rob Landley wrote: >>> On 8/30/22 10:31, Weizhao Ouyang wrote: When getfattx reading overlayfs merged dirs, listxattr will got different keys_len with zero size and determined size, then

Re: [Toybox] New diff.c

2022-08-31 Thread Rob Landley
On 8/13/22 17:36, Ray Gardner wrote: > Rob, I don't know if you've done much work on diff.c since your Aug. 8 > post that had attachment.c, but I tried that program and it apparently > gets into an infinite loop with a certain pair of files. I can send > them to you or attach them to a post here

[Toybox] New diff.c

2022-08-31 Thread Ray Gardner
Rob, I don't know if you've done much work on diff.c since your Aug. 8 post that had attachment.c, but I tried that program and it apparently gets into an infinite loop with a certain pair of files. I can send them to you or attach them to a post here if you like.

[Toybox] [PATCH] getfattx.c: fix overlayfs merged dir stuck

2022-08-31 Thread Weizhao Ouyang
When getfattx reading overlayfs merged dirs, listxattr will got different keys_len with zero size and determined size, then it will stuck in this while scope. Update the keys_len after the second listxattr call to fix it. Signed-off-by: Weizhao Ouyang --- toys/pending/getfattr.c | 19

Re: [Toybox] [PATCH] getfattr.c: fix overlayfs merged dir stuck

2022-08-31 Thread Weizhao Ouyang
On 2022/8/31 18:48, Rob Landley wrote: > On 8/31/22 05:35, Rob Landley wrote: >> On 8/30/22 10:31, Weizhao Ouyang wrote: >>> When getfattx reading overlayfs merged dirs, listxattr will got >>> different keys_len with zero size and determined size, then it will >>> stuck in this while scope.

[Toybox] [PATCH] portability: Add some FreeBSD cases

2022-08-31 Thread Ed Maste
From: Ed Maste Use existing Apple or OpenBSD implementations. --- lib/portability.c | 12 ++-- lib/portability.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/portability.c b/lib/portability.c index 58ef384b..6fac2c36 100644 --- a/lib/portability.c +++

Re: [Toybox] [PATCH] tests.tar: fix tests for macOS.

2022-08-31 Thread enh via Toybox
On Tue, Aug 30, 2022 at 4:20 AM Rob Landley wrote: > On 8/29/22 19:22, enh via Toybox wrote: > > ping? i saw you added another tar test, but let me know your thoughts on > this > > before i rebase and fix the new test... > > Sorry, under the weather all weekend (and today). Pascal's Apology

Re: [Toybox] [PATCH] getfattr.c: fix overlayfs merged dir stuck

2022-08-31 Thread enh via Toybox
On Wed, Aug 31, 2022 at 3:27 AM Rob Landley wrote: > On 8/30/22 10:31, Weizhao Ouyang wrote: > > When getfattx reading overlayfs merged dirs, listxattr will got > > different keys_len with zero size and determined size, then it will > > stuck in this while scope. Update the keys_len after the

Re: [Toybox] [PATCH] getfattr.c: fix overlayfs merged dir stuck

2022-08-31 Thread Rob Landley
On 8/31/22 05:35, Rob Landley wrote: > On 8/30/22 10:31, Weizhao Ouyang wrote: >> When getfattx reading overlayfs merged dirs, listxattr will got >> different keys_len with zero size and determined size, then it will >> stuck in this while scope. Update the keys_len after the second >> listxattr

Re: [Toybox] [PATCH] getfattr.c: fix overlayfs merged dir stuck

2022-08-31 Thread Rob Landley
On 8/30/22 10:31, Weizhao Ouyang wrote: > When getfattx reading overlayfs merged dirs, listxattr will got > different keys_len with zero size and determined size, then it will > stuck in this while scope. Update the keys_len after the second > listxattr to fix it. Do you have a test case I can