Re: [Toybox] [PATCH] clear.c: Clear scrollback buffer on non-vte (gnome based) terminals

2024-03-08 Thread Oliver Webb via Toybox
Forgot to mention some things, A Erratum so I don't sound stupid. On Friday, March 8th, 2024 at 19:47, Oliver Webb via Toybox wrote: > On Friday, March 8th, 2024 at 19:15, Rob Landley r...@landley.net wrote: [..] > > > The nommu stuff seems to have only > > > been done on 2.4/2.6 kernels from

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-08 Thread Oliver Webb via Toybox
TL;DR: Rant about sh.c's variable names I forgot to include in main email, I have a patch to start fixing it but it conflicts with other stuff and I have to re-do it Reading through sh.c, most of the variable names are 2 letters long (repeating the same letter), for short functions (<20 lines)

Re: [Toybox] [PATCH] clear.c: Clear scrollback buffer on non-vte (gnome based) terminals

2024-03-08 Thread Oliver Webb via Toybox
On Friday, March 8th, 2024 at 19:15, Rob Landley wrote: > On 3/8/24 00:02, Oliver Webb wrote: > > > On Wednesday, March 6th, 2024 at 01:22, Rob Landley r...@landley.net wrote: > > > > > It's actually "reset" that should yank the tty out of cooked mode, which I > > > believe it does now. > > >

Re: [Toybox] [PATCH] toysh: Shut up TEST_HOST, correct 3 test cases

2024-03-08 Thread Rob Landley
On 3/7/24 19:39, Oliver Webb via Toybox wrote: > Looking at toysh again since the toybox test suite should run under it > (in mkroot or under a chroot) A problem seems to be that there is no > return command, which breaks runtest.sh to it's core. Dont know how to add > one in yet > > On my

Re: [Toybox] [PATCH] watch: flush the buffer each round.

2024-03-08 Thread Rob Landley
I remember when the xprintf() family would do a flush and check for errors each write. That's why code like: dprintf(1, "%c", padctimelen ? 0 : width-1)); if (yy>=3) dprintf(1, "\r\n"); Was allowable. I also remember when we had an xflush() that would catch errors if stdout

Re: [Toybox] [PATCH] clear.c: Clear scrollback buffer on non-vte (gnome based) terminals

2024-03-08 Thread Rob Landley
On 3/8/24 00:02, Oliver Webb wrote: > On Wednesday, March 6th, 2024 at 01:22, Rob Landley wrote: > >> It's actually "reset" that should yank the tty out of cooked mode, which I >> believe it does now. >> >> Why we have both "clear" and "reset", I couldn't tell you. > > reset sets tty settings

[Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-08 Thread Oliver Webb via Toybox
This patch fixes a use after free warning in the select statement processing Since my patch for the test suite did not modify sh.c this patch and the last one I submitted do not conflict - Oliver Webb From b99d35655ce9c0fb9120c9a09bb05472d620bc80 Mon Sep 17 00:00:00 2001 From: Oliver Webb

[Toybox] [PATCH] ping: opt in to line buffering.

2024-03-08 Thread enh via Toybox
--- toys/net/ping.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 0001-ping-opt-in-to-line-buffering.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

[Toybox] [PATCH] watch: flush the buffer each round.

2024-03-08 Thread enh via Toybox
--- toys/other/watch.c | 1 + 1 file changed, 1 insertion(+) 0001-watch-flush-the-buffer-each-round.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] vi.c: Backspace to merge lines when at beginning, get_endline is no more, cleanup

2024-03-08 Thread David Seikel
On 2024-03-08 10:47:10, Jarno Mäkipää wrote: > I was not that interested on ex, and I think Rob said ex is obsolete > and not on his roadmap. But yes some of ex commands are just vi normal > mode commands, with special addressing. If someone needs them, I think > first thing to do is implement

Re: [Toybox] [PATCH] vi.c: Backspace to merge lines when at beginning, get_endline is no more, cleanup

2024-03-08 Thread Jarno Mäkipää
On Fri, Mar 8, 2024 at 3:07 AM Oliver Webb wrote: > > On Thursday, March 7th, 2024 at 14:23, Jarno Mäkipää > wrote: > [...] > > Feel free to fix it up, some other features are simpler since you can > > just read the man page and make it behave accordingly, but backspace > > is maybe not very