Re: [Toybox] "bad xform" not very helpful

On 9/7/22 23:54, enh wrote: > I just checked in some more test tweaking, which hopefully lets me park > that for > a bit. (I still need to fix the chattr tests, which are skipped because > root and > last worked who KNOWS when, > > remember that Android's CI typically tests as root

Re: [Toybox] "bad xform" not very helpful

On Wed, Sep 7, 2022 at 1:56 PM Rob Landley wrote: > On 9/6/22 18:16, enh wrote: > > and to the surprise of absolutely no-one ... > > > > they got back to me with a test script to repro this with (which i > assume will > > work in any kernel tree, and isn't specific to ACK)... > > ``` > >

Re: [Toybox] "bad xform" not very helpful

On 9/6/22 18:16, enh wrote: > and to the surprise of absolutely no-one ... > > they got back to me with a test script to repro this with (which i assume will > work in any kernel tree, and isn't specific to ACK)... > ``` > #!/bin/bash > > set -x > > run () { >   start_time=$(date +%s) > >  

Re: [Toybox] "bad xform" not very helpful

and to the surprise of absolutely no-one ... they got back to me with a test script to repro this with (which i assume will work in any kernel tree, and isn't specific to ACK)... ``` #!/bin/bash set -x run () { start_time=$(date +%s) find /usr/include/linux/ -name *.h -print0 | \

Re: [Toybox] "bad xform" not very helpful

On Fri, Sep 2, 2022 at 5:55 AM Rob Landley wrote: > On 9/1/22 15:49, enh wrote: > > The downside of doing that is it would require TOYBOX sed. > > > > meh, _i_ don't care about that :-) > > > > (and, more seriously, does _anyone_ care about using a mixture of toybox > and > > non-toybox? > >

Re: [Toybox] "bad xform" not very helpful

On 9/1/22 15:49, enh wrote: > The downside of doing that is it would require TOYBOX sed. > > meh, _i_ don't care about that :-) > > (and, more seriously, does _anyone_ care about using a mixture of toybox and > non-toybox? At the command level, sure. On macos and bsd you're still using the

Re: [Toybox] "bad xform" not very helpful

On Wed, Aug 31, 2022 at 11:37 PM Rob Landley wrote: > On 8/31/22 16:55, enh wrote: > > and if i `CONFIG_TOYBOX_NORECURSE=y`, it calls sed and works... > > > > ...though this might be about to come back and bite me. i'm hearing > as-yet > > unconfirmed reports that toybox `tar czf` is a lot

Re: [Toybox] "bad xform" not very helpful

On 2022-09-01 04:35:24, Rob Landley wrote: > On 8/30/22 03:59, David Seikel wrote: > > I'm good at reading code, but I know you are not. > > As demonstrated below. Well I had already cobbled together something that works for me, copying stuff from other parts of toybox, that largely did what you

Re: [Toybox] "bad xform" not very helpful

On 8/30/22 03:59, David Seikel wrote: > I'm good at reading code, but I know you are not. As demonstrated below. On 8/31/22 20:33, David Seikel wrote: > On 2022-08-31 18:18:15, enh via Toybox wrote: >>it does by default. that's what i turned off as a workaround for this bug. > > Um how does

Re: [Toybox] "bad xform" not very helpful

On 8/31/22 16:55, enh wrote: > and if i `CONFIG_TOYBOX_NORECURSE=y`, it calls sed and works... > > ...though this might be about to come back and bite me. i'm hearing as-yet > unconfirmed reports that toybox `tar czf` is a lot slower than gnu tar, and -- > given that they're using

Re: [Toybox] "bad xform" not very helpful

On 2022-08-31 18:18:15, enh via Toybox wrote: >it does by default. that's what i turned off as a workaround for this bug. Um how does one using toybox as the foundation for something else actually call any random toy directly? Is there a vararg calltoy() function I missed? >On Wed, Aug

Re: [Toybox] "bad xform" not very helpful

it does by default. that's what i turned off as a workaround for this bug. On Wed, Aug 31, 2022, 18:15 David Seikel wrote: > On 2022-08-31 14:55:24, enh via Toybox wrote: > >On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > > > >

Re: [Toybox] "bad xform" not very helpful

On 2022-08-31 14:55:24, enh via Toybox wrote: >On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > >On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: > > On 8/15/22 18:50, enh via Toybox wrote: > > and here's their

Re: [Toybox] "bad xform" not very helpful

On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > >> >> >> On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: >> >>> On 8/15/22 18:50, enh via Toybox wrote: >>> > and here's their minimized repro case: >>> > >>> > echo > /tmp/foo.txt; echo

Re: [Toybox] "bad xform" not very helpful

On 8/18/22 11:24, enh wrote: > On Thu, Aug 18, 2022 at 3:45 AM Rob Landley > wrote: > > On 8/17/22 16:25, enh wrote: > >     Alright, let me try it in the android checkout directory... Still > had > to run > >     oldconfig... And it ran fine for me. >

Re: [Toybox] "bad xform" not very helpful

On Thu, Aug 18, 2022 at 3:45 AM Rob Landley wrote: > On 8/17/22 16:25, enh wrote: > > Alright, let me try it in the android checkout directory... Still > had to run > > oldconfig... And it ran fine for me. > > > > Something different about the build environment. > > > > but it's

Re: [Toybox] "bad xform" not very helpful

On 8/17/22 16:25, enh wrote: > Alright, let me try it in the android checkout directory... Still had to > run > oldconfig... And it ran fine for me. > > Something different about the build environment. > > but it's consistent across multiple users on multiple OSes, so i think it's >

Re: [Toybox] "bad xform" not very helpful

On Wed, Aug 17, 2022 at 1:58 PM Rob Landley wrote: > > > On 8/16/22 14:36, enh wrote: > > > > > > On Tue, Aug 16, 2022 at 12:22 PM enh e...@google.com>> wrote: > > > > > > > > On Tue, Aug 16, 2022 at 10:28 AM enh > > wrote: > > > > > > > > On Tue, Aug

Re: [Toybox] "bad xform" not very helpful

On 8/16/22 14:36, enh wrote: > > > On Tue, Aug 16, 2022 at 12:22 PM enh > wrote: > > > > On Tue, Aug 16, 2022 at 10:28 AM enh > wrote: > > > > On Tue, Aug 16, 2022 at 1:43 AM Rob Landley >

Re: [Toybox] "bad xform" not very helpful

On Tue, Aug 16, 2022 at 12:22 PM enh wrote: > > > On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > >> >> >> On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: >> >>> On 8/15/22 18:50, enh via Toybox wrote: >>> > and here's their minimized repro case: >>> > >>> > echo > /tmp/foo.txt; echo

Re: [Toybox] "bad xform" not very helpful

On Tue, Aug 16, 2022 at 10:28 AM enh wrote: > > > On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: > >> On 8/15/22 18:50, enh via Toybox wrote: >> > and here's their minimized repro case: >> > >> > echo > /tmp/foo.txt; echo /tmp/foo.txt > /tmp/find.txt >> > >> > cat /tmp/find.txt |

Re: [Toybox] "bad xform" not very helpful

On Tue, Aug 16, 2022 at 1:43 AM Rob Landley wrote: > On 8/15/22 18:50, enh via Toybox wrote: > > and here's their minimized repro case: > > > > echo > /tmp/foo.txt; echo /tmp/foo.txt > /tmp/find.txt > > > > cat /tmp/find.txt | prebuilts/build-tools/path/linux-x86/tar czf > /tmp/out.tar.gz \ > >

Re: [Toybox] "bad xform" not very helpful

On Mon, Aug 15, 2022 at 11:33 PM Rob Landley wrote: > On 8/15/22 15:52, enh via Toybox wrote: > > the kernel folks are trying to use `tar --transform` and getting the > "bad xform" > > error that's not really helping them much. it seems like it would be > hard to > > list the _relevant_ sed

Re: [Toybox] "bad xform" not very helpful

On 8/15/22 18:50, enh via Toybox wrote: > and here's their minimized repro case: > > echo > /tmp/foo.txt; echo /tmp/foo.txt > /tmp/find.txt > > cat /tmp/find.txt | prebuilts/build-tools/path/linux-x86/tar czf > /tmp/out.tar.gz \ >   --absolute-names \ >   --transform 's,^/,,' -T - > > This

Re: [Toybox] "bad xform" not very helpful

On 8/15/22 15:52, enh via Toybox wrote: > the kernel folks are trying to use `tar --transform` and getting the "bad > xform" > error that's not really helping them much. it seems like it would be hard to > list the _relevant_ sed expression(s), so perhaps just showing the specific > filename we

Re: [Toybox] "bad xform" not very helpful

and here's their minimized repro case: echo > /tmp/foo.txt; echo /tmp/foo.txt > /tmp/find.txt cat /tmp/find.txt | prebuilts/build-tools/path/linux-x86/tar czf /tmp/out.tar.gz \ --absolute-names \ --transform 's,^/,,' -T - This fails with tar: bad xform However, if the file names are fed

[Toybox] "bad xform" not very helpful

the kernel folks are trying to use `tar --transform` and getting the "bad xform" error that's not really helping them much. it seems like it would be hard to list the _relevant_ sed expression(s), so perhaps just showing the specific filename we tried that failed is a better choice? context here: