Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread Rob Landley
On 2/28/24 13:49, Rob Landley wrote: > I need to track "git log" from the last known "upstream" version to see what > they _changed_ and apply interesting fixes (like arm64 support, apparently). > Promoting the command should add that step to the toybox release checklist. > But > first I need to

Re: [Toybox] buffer sizes

2024-02-28 Thread David Seikel
On 2024-02-28 15:41:06, Rob Landley wrote: > I can see arguing that you might need 8k there to avoid screen flicker with > the > large terminal sizes some people tend to use. I might be one of those people, with my 256 x 140 terminal. -- A big old stinking pile of genius that no one wants coz

Re: [Toybox] buffer sizes

2024-02-28 Thread enh via Toybox
On Wed, Feb 28, 2024 at 1:33 PM Rob Landley wrote: > > On 2/28/24 13:14, enh via Toybox wrote: > > just fyi if you don't follow the coreutils list, > > Sadly, I am still subscribed to that because: > > https://lists.gnu.org/archive/html/coreutils/2023-08/msg00100.html > > STILL hasn't been

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread Rob Landley
On 2/28/24 13:03, enh wrote: > On Wed, Feb 28, 2024 at 10:28 AM Rob Landley wrote: >> >> On 2/28/24 11:13, enh wrote: >> > On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: >> >> > static size_t bcj_x86(struct xz_dec_bcj *s, char *buf, size_t size) >> >> > @@ -639,6 +640,20 @@ enum xz_ret

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread enh via Toybox
On Wed, Feb 28, 2024 at 10:28 AM Rob Landley wrote: > > On 2/28/24 11:13, enh wrote: > > On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: > >> > static size_t bcj_x86(struct xz_dec_bcj *s, char *buf, size_t size) > >> > @@ -639,6 +640,20 @@ enum xz_ret xz_dec_bcj_run(struct xz_dec_bcj *s, >

[Toybox] buffer sizes

2024-02-28 Thread enh via Toybox
just fyi if you don't follow the coreutils list, i see that they're looking at moving up from 128KiB to 256KiB buffers (but without saying how _much_ "more performance" that gets them, nor what exactly "modern hardware" means). (don't get me wrong --- this is definitely a tricky one. bionic and

Re: [Toybox] buffer sizes

2024-02-28 Thread Rob Landley
On 2/28/24 13:14, enh via Toybox wrote: > just fyi if you don't follow the coreutils list, Sadly, I am still subscribed to that because: https://lists.gnu.org/archive/html/coreutils/2023-08/msg00100.html STILL hasn't been addressed. (How many reminders is too many? Are they being passive

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread enh via Toybox
On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: > > On 2/27/24 21:27, Oliver Webb wrote: > > 2 are help text, do_xzcat was due to replacing the case statement for error > > handling with a array > > If I had to guess, xz_dec_run or xz_dec_bcj_reset > > > > It was the case statement I stripped

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread Rob Landley
On 2/28/24 11:13, enh wrote: > On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: >> > static size_t bcj_x86(struct xz_dec_bcj *s, char *buf, size_t size) >> > @@ -639,6 +640,20 @@ enum xz_ret xz_dec_bcj_run(struct xz_dec_bcj *s, >> > struct xz_dec_lzma2 *lzma2, >> > */ >> > enum xz_ret

[Toybox] Can we remove 'catv' from the status page next release

2024-02-28 Thread Oliver Webb via Toybox
In the status page, catv is under "not started yet", catv was a command that existed in toybox since 2006 (commit 1521a9e, Slightly older then oneit). And ended up being removed in 2022 because no one uses it. Since the next release of toybox is coming some time in the future, could we make

[Toybox] [PATCH] Minor formatting and cleanup in getopt.c

2024-02-28 Thread Oliver Webb via Toybox
I've been looking at some of the other pending commands, And found a getopt implementation from 2017 by AOSP. Looking at the source code, it doesn't seem unclean, nor overly large (about 100 lines). It does use getopt_long_only, a GNU extension of glibc, but musl has that so it will work on

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread Oliver Webb via Toybox
On Wednesday, February 28th, 2024 at 13:51, Rob Landley wrote: > On 2/28/24 13:49, Rob Landley wrote: > > > I need to track "git log" from the last known "upstream" version to see what > > they changed and apply interesting fixes (like arm64 support, apparently). > > Promoting the command should