Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-14 Thread Rob Landley
On 3/13/24 18:19, Oliver Webb wrote: >> If you want to complain, I do tend to have "s", "ss", and "sss" as an > > I did complain about that in the email. I noticed. >> You're basically complaining there was an "i" variable that wasn't a loop >> index. > > That IS a problem, Not "I have a

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-14 Thread enh via Toybox
at a high level, it does seem like many/most people interpret "pending" as "almost done" (he says, being part of the problem himself, having several pending things building and shipping on all Android devices) whereas in actual fact it can mean anything from "yeah, actually pretty much done" to

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-14 Thread Oliver Webb via Toybox
> Not "I have a problem", but "it IS a problem". Well it's good that you're here > to define objective reality. Without such a universal arbiter we would all be > lost a world of opinion and nuance. It is if you are trying to audit it to understand what it is doing so you can fix 80 broken test

[Toybox] [PATCH] readelf: fix -n for x86-64 ibt/shstk notes.

2024-03-14 Thread enh via Toybox
I couldn't work out how to get gcc to actually produce such a thing, but /bin/dbxtool on my debian box right now has them. The big mistake here is that GNU property notes' data is always 8-byte aligned, so we needed to skip that. That lets us get rid of the existing loop termination hack to skip

[Toybox] hexdump tests.

2024-03-14 Thread Rob Landley
Following up on commit cab0b6653827, the hexdump test suite is weird. For example, the first test has "simple\\n" when it means "simple\n" (which nevertheless somehow works for reasons I am loathe to examine at the moment, and I have a todo item to convert the various test arguments needing

[Toybox] xzcat.c: What do we want from upstream?

2024-03-14 Thread Oliver Webb via Toybox
Slightly more then 2 weeks ago (Feb 28th), I posted a requested evaluation of upstream changes (http://lists.landley.net/pipermail/toybox-landley.net/2024-February/030095.html) For the xz decompressor we are using. Of these, the most important commits (from my evaluation) are: (I truncated the