Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.

2017-04-26 Thread enh
On Wed, Apr 26, 2017 at 2:43 PM, Rob Landley wrote: > On 04/24/2017 03:43 PM, enh wrote: > > Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for > > another day, > > Blah, I should take this one. > > I have deflate decompression side implemented already

Re: [Toybox] Test design issue.

2017-04-26 Thread enh
On Wed, Apr 26, 2017 at 2:41 PM, Rob Landley wrote: > On 04/25/2017 12:28 PM, enh wrote: > > note that the existing SKIP_HOST mechanism is very error prone. iirc > > none of the sed tests actually run because one near the top needs > > SKIP_HOST and it never gets unset. > > I

Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.

2017-04-26 Thread Rob Landley
On 04/24/2017 03:43 PM, enh wrote: > Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for > another day, Blah, I should take this one. I have deflate decompression side implemented already (and working at one point, although I just tested "make zcat" and got a bad crc

Re: [Toybox] Test design issue.

2017-04-26 Thread Rob Landley
On 04/25/2017 12:28 PM, enh wrote: > note that the existing SKIP_HOST mechanism is very error prone. iirc > none of the sed tests actually run because one near the top needs > SKIP_HOST and it never gets unset. I thought that "VARIABLE=value command" worked the same for shell functions as it does