Re: [Toybox] test.sh: Don't override "C" command path in TEST_HOST if it's set

2024-03-24 Thread Rob Landley
On 3/24/24 18:40, Rob Landley wrote: >> Also, different command names, there's a dozen different vi implementations >> and >> only a few have the name "vi". This is true for some other commands as well > > I've been doing: > > mkdir sub > ln -s $(which potato) sub/vi >

[Toybox] [PATCH] more.c: More stuff, down cursor key scrolls down. Also stuff about less

2024-03-24 Thread Ray Gardner
In-Reply-To: <0b868804-e677-2a6f-ea50-5ecaf46d3...@landley.net> References: <0b1ae828-4610-c637-7377-a429d8fc0...@landley.net> <0b868804-e677-2a6f-ea50-5ecaf46d3...@landley.net> On Sun, 24 Mar 2024 02:22:17 -0500 rob at landley.net (Rob Landley) wrote: > The thing about vi is it's the

Re: [Toybox] test.sh: Don't override "C" command path in TEST_HOST if it's set

2024-03-24 Thread Rob Landley
On 3/22/24 16:10, Oliver Webb wrote: >> On 3/21/24 21:38, Oliver Webb via Toybox wrote: >> >> > A mildly annoying issue of you are trying to test with different >> > implementations of commands >> > such as plan9 ones or sbase or busybox ones, things with different >> > conflicting

Re: [Toybox] hexdump tests.

2024-03-24 Thread Rob Landley
On 3/22/24 15:02, enh wrote: >> > CANONICALIZE_SPACE_IF_RUNNING_HOST_VERSION=1? so we trust ourselves but >> > no-one >> > else? :-) >> >> I _don't_ trust myself, and I'm not special. (That's policy.) > > yeah, but that's why i suggested > CANONICALIZE_SPACE_IF_RUNNING_HOST_VERSION --- that way

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-24 Thread Rob Landley
On 3/24/24 01:00, Oliver Webb wrote: > I've done some research on this too, we have no "select" statements in any of > our config symbols, for a definition of "we" that is "I have intentionally not merged any", since I review and approve all the kconfig command sections in the headers and have

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-24 Thread Rob Landley
On 3/22/24 10:26, enh wrote: > On Fri, Mar 22, 2024 at 8:24 AM enh wrote: >> (tbh, just merging "lsb" into "other" would be a step forwards. wtf >> is/was "lsb" anyway? and while i can _usually_ guess "POSIX or not?" >> correctly, "lsb or other" is impossible by virtue of being >> meaningless.) >

Re: [Toybox] [PATCH] more.c: More stuff, down cursor key scrolls down. Also stuff about less

2024-03-24 Thread Rob Landley
On 3/21/24 06:52, Jarno Mäkipää wrote: > On Thu, Mar 21, 2024 at 1:08 AM Rob Landley wrote: >> >> > There is also a testing problem. vi.c doesn't do TEST_HOST because it >> >> > needs a -s option >> >> > to pass in scripts to test with. >> >> >> >> Which is an issue I need to figure out how to

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-24 Thread Oliver Webb via Toybox
On Saturday, March 23rd, 2024 at 20:41, Rob Landley wrote: > On 3/21/24 23:59, Oliver Webb wrote: > > On Thursday, March 21st, 2024 at 22:45, Rob Landley r...@landley.net wrote: > > > On 3/17/24 14:52, Oliver Webb wrote: > > > > > > > Same here, I can remember the posix commands. > > > > > > Can

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-24 Thread Rob Landley
On 3/22/24 10:24, enh wrote: > On Thu, Mar 21, 2024 at 8:45 PM Rob Landley wrote: >> Anyway, toys/android basically meant (to me), "commands that come from and >> are >> maintained by Elliott which I can't even test because they don't apply to a >> vanilla linux system that isn't running the

Re: [Toybox] Poke about the bc.c cleanup patches I submitted a while ago

2024-03-24 Thread Oliver Webb via Toybox
(Forgot to CC the list, sorry) On Sunday, March 24th, 2024 at 01:25, Oliver Webb wrote: About a month ago I submitted two patches that started to cleaup bc.c (http://lists.landley.net/pipermail/toybox-landley.net/2024-February/030067.html and

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-24 Thread Oliver Webb via Toybox
On Sunday, March 24th, 2024 at 04:09, Rob Landley wrote: > On 3/24/24 01:00, Oliver Webb wrote: > This isn't the hard part. To me, the hard part is wanting to share lib/.c code > with this new binary, which implies it would live in toys/example/.c, which > means in the NEW design it would be a