allocated on the "unsafe" stack.
(2) does not seem to have any advantage over (1). Would (1) be acceptable?
On Mon, May 9, 2016 at 2:23 PM, Evgenii Stepanov <euge...@google.com> wrote:
> Does https://android-review.googlesource.com/#/c/223875/ look OK?
> It disables the stack dep
Sorry, I did not look at the problem hard enough.
The real issue is interaction of this code with safestack
(http://clang.llvm.org/docs/SafeStack.html), which splits the stack in
2 disjoint memory regions. If the two variables are allocated on
different stacks, the comparison result is truly
t was because we were
> potentially doing an in-place basename where we might copy the filename
> after the / over the earlier path components, and that might overlap.
> But the source is ptb->str plus either ptb->offset[3] or ptb->offset[4],
> and even when ptb _is_ pointing to tb
