Re: [Toybox] Test design issue.

2017-04-27 Thread Rob Landley
On 04/26/2017 04:56 PM, enh wrote: > On Wed, Apr 26, 2017 at 2:41 PM, Rob Landley > wrote: > > On 04/25/2017 12:28 PM, enh wrote: > > note that the existing SKIP_HOST mechanism is very error prone. iirc > > none of the sed tests actually

Re: [Toybox] Test design issue.

2017-04-26 Thread enh
On Wed, Apr 26, 2017 at 2:41 PM, Rob Landley wrote: > On 04/25/2017 12:28 PM, enh wrote: > > note that the existing SKIP_HOST mechanism is very error prone. iirc > > none of the sed tests actually run because one near the top needs > > SKIP_HOST and it never gets unset. > > I

Re: [Toybox] Test design issue.

2017-04-26 Thread Rob Landley
On 04/25/2017 12:28 PM, enh wrote: > note that the existing SKIP_HOST mechanism is very error prone. iirc > none of the sed tests actually run because one near the top needs > SKIP_HOST and it never gets unset. I thought that "VARIABLE=value command" worked the same for shell functions as it does

Re: [Toybox] Test design issue.

2017-04-25 Thread enh
note that the existing SKIP_HOST mechanism is very error prone. iirc none of the sed tests actually run because one near the top needs SKIP_HOST and it never gets unset. SKIP_HOST is also not very intention-revealing. i'd prefer to explicitly distinguish "host tool is just plain broken" from "we