Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-05 Thread Geoffrey Winn
Excellent. Thank you. I've applied that patch. On 04/01/07, Yang ZHONG [EMAIL PROTECTED] wrote: xmlCanonicPath and comment have been attached as http://issues.apache.org/jira/secure/attachment/12348285/WindowsPath.support On 1/4/07, Caroline Maynard [EMAIL PROTECTED] wrote: On 04/01/07,

Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-04 Thread Geoffrey Winn
I have a couple of comments. 1. In the patch XSDHelperImpl.990 you _must_ add comments to explain what the code is doing and why. 2. Regarding xmlCanonicPath, performance is not an issue. This section of code won't be called often enough to matter, whereas reliability and clarity (for people

Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-04 Thread Caroline Maynard
On 04/01/07, Geoffrey Winn [EMAIL PROTECTED] wrote: I have a couple of comments. 1. In the patch XSDHelperImpl.990 you _must_ add comments to explain what the code is doing and why. 2. Regarding xmlCanonicPath, performance is not an issue. This section of code won't be called often enough to

Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-04 Thread Yang ZHONG
xmlCanonicPath and comment have been attached as http://issues.apache.org/jira/secure/attachment/12348285/WindowsPath.support On 1/4/07, Caroline Maynard [EMAIL PROTECTED] wrote: On 04/01/07, Geoffrey Winn [EMAIL PROTECTED] wrote: I have a couple of comments. 1. In the patch

[jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-03 Thread Geoff Winn (JIRA)
[ https://issues.apache.org/jira/browse/TUSCANY-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoff Winn resolved TUSCANY-990. Resolution: Fixed Fix Version/s: Cpp-current Patch applied. The standard tests now

Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-03 Thread Yang ZHONG
Are you using C:\path\to\the.xsd as schemaLocation for include/import? According to XSD spec, it should have been a URI as defined by [RFC 2396], as amended by [RFC 2732]. Both RFC 2396 and RFC 2732 have specified \ unwise. Or are you using C:\path\to\the.xsd for XSDHelper#defineFile? Neither

Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-03 Thread Caroline Maynard
I posted the traceback to show that it's XSDHelperImpl::defineFile(). The file spec is being passed in from the user, and I do think that Windows users normally expect to specify file specs in this way, and I see no reason to regress this behaviour in your fix. Especially not with an

Re: [jira] Resolved: (TUSCANY-990) Avoid duplicated/infinite loading

2007-01-03 Thread Yang ZHONG
I've tried http://issues.apache.org/jira/secure/attachment/12348221/XSDHelperImpl.990 and I think it supports Windows path on Windows (only). Let me know if your case still fails. On 1/3/07, Caroline Maynard [EMAIL PROTECTED] wrote: I posted the traceback to show that it's