Java assertion related test case failures

2006-07-20 Thread Raymond Feng
Hi, I ran into some test case failures with the trunk code in both Eclipse and Maven (reported by my continumm build) related to the usage of java assertions. For example, in test case org.apache.tuscany.spi.extension.ReferenceTestCase, we have the following test: public void

Re: Java assertion related test case failures

2006-07-20 Thread Raymond Feng
, assertions should not alter normal program execution. I think I buy what the author says. Thanks, Raymond - Original Message - From: Yang ZHONG [EMAIL PROTECTED] To: tuscany-dev@ws.apache.org Sent: Thursday, July 20, 2006 3:11 PM Subject: Re: Java assertion related test case failures I

Re: Java assertion related test case failures

2006-07-20 Thread Jeremy Boynes
@ws.apache.org Sent: Thursday, July 20, 2006 3:11 PM Subject: Re: Java assertion related test case failures I hope our code are not designated to run in some specifically configured JVM. Since JVMs may turn assertion on or off, I'm not sure AssertionError should be an expected behavior

Re: Java assertion related test case failures

2006-07-20 Thread Raymond Feng
to be launched with -ea. Making sense? Thanks, Raymond - Original Message - From: Jeremy Boynes [EMAIL PROTECTED] To: tuscany-dev@ws.apache.org Sent: Thursday, July 20, 2006 4:00 PM Subject: Re: Java assertion related test case failures We covered assertions a little in the exception

Re: Java assertion related test case failures

2006-07-20 Thread Yang ZHONG
assertion related test case failures I hope our code are not designated to run in some specifically configured JVM. Since JVMs may turn assertion on or off, I'm not sure AssertionError should be an expected behavior in general. Dedicated exceptions and errors are much better protocol, e.g

Re: Java assertion related test case failures

2006-07-20 Thread Raymond Feng
If you like my previous proposal, here's the patch I tried. Thanks, Raymond - Original Message - From: Raymond Feng [EMAIL PROTECTED] To: tuscany-dev@ws.apache.org Sent: Thursday, July 20, 2006 4:14 PM Subject: Re: Java assertion related test case failures If the purpose of the test

Re: Java assertion related test case failures

2006-07-20 Thread Raymond Feng
: Jeremy Boynes [EMAIL PROTECTED] To: tuscany-dev@ws.apache.org Sent: Thursday, July 20, 2006 4:37 PM Subject: Re: Java assertion related test case failures On Jul 20, 2006, at 4:14 PM, Raymond Feng wrote: If the purpose of the test case is to verify the assert, I suggest that we use

Re: Java assertion related test case failures

2006-07-20 Thread Jim Marino
-dev@ws.apache.org Sent: Thursday, July 20, 2006 4:37 PM Subject: Re: Java assertion related test case failures On Jul 20, 2006, at 4:14 PM, Raymond Feng wrote: If the purpose of the test case is to verify the assert, I suggest that we use ClassLoader.setClassAssertionStatus (targetClassName