Re: [PATCH v3 07/11] phy: phy-imx8m-pcie: Add support for i.MX8M{M/P} PCIe PHY

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: Add initial support for i.MX8M{M/P} PCIe PHY. On i.MX8M{M/P} SoCs PCIe PHY initialization moved to this standalone PHY driver. Inspired from counterpart Linux kernel v6.8-rc3 driver: drivers/phy/freescale/phy-fsl-imx8m-pcie.c. Use last Linux kernel driver

Re: [PATCH v3 08/11] pci: Add DW PCIe controller support for iMX8MP SoC

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: pcie_imx doesn't seem to share any useful code for iMX8 SoC and it is tied to quite old port of pcie_designware driver from Linux which suffices only iMX6 specific needs. But currently we have the common DWC specific bits which alligns pretty well with DW

Re: [PATCH v3 06/11] imx8mp: power-domain: Expose high performance PLL clock

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: Expose the high performance PLL as a regular Linux clock ... as clock framework clock ... , so the PCIe PHY can use it when there is no external refclock provided. Inspired from counterpart Linux kernel v6.8-rc3 driver:

Re: [PATCH v3 05/11] imx8mp: power-domain: Add PCIe support

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: Add support for GPCv2 power domains and clock handling for PCIe and PCIe PHY. Tested-by: Tim Harvey #imx8mp-venice* Tested-by: Adam Ford #imx8mp-beacon-kit Signed-off-by: Sumit Garg Reviewed-by: Marek Vasut

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: power_domain_on/off() isn't refcounted and power domain bus shouldn't be turned off for a single peripheral domain as it would negatively affect other peripheral domains. So lets just skip turning off bus power domain. What exactly is the issue and how did

Re: [PATCH v3 03/11] reset: imx: Add support for i.MX8MP reset controller

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: Add support for i.MX8MP reset controller, it has same reset IP inside as the other iMX7 and iMX8 variants but with different module layout. iMX8M , iMX8 is a different SoC . Inspired from counterpart Linux kernel v6.8-rc3 driver:

Re: [PATCH v3 02/11] reset: imx: Refactor driver to simplify function names

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: imx7_reset_{deassert/assert}_imx* are a bit more confusing when compared with imx*_reset_{deassert/assert}. So refactor driver to use function names easier to understand. This shouldn't affect the functionality though. Suggested-by: Marek Vasut

Re: [PATCH v3 01/11] clk: imx8mp: Add support for PCIe clocks

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: Add support for PCIe clocks required to enable PCIe support on iMX8MP SoC. Tested-by: Tim Harvey #imx8mp-venice* Tested-by: Adam Ford #imx8mp-beacon-kit Signed-off-by: Sumit Garg Reviewed-by: Marek Vasut

Re: [PATCH v2 15/15] rockchip: rk3328-orangepi-r1-plus: Enable boot from SPI NOR flash

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Add Kconfig options to enable support for booting from SPI NOR flash on Orange Pi R1 Plus boards. The generated bootable u-boot-rockchip-spi.bin can be written to 0x0 of SPI NOR flash. The FIT image is loaded from 0x6, same as on RK35xx boards.

Re: [PATCH v2 14/15] rockchip: rk3328-rock64: Enable boot from SPI NOR flash

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Add Kconfig options to enable support for booting from SPI NOR flash on Pine64 Rock64. The generated bootable u-boot-rockchip-spi.bin can be written to 0x0 of SPI NOR flash. The FIT image is loaded from 0x6, same as on RK35xx boards. => sf

Re: [PATCH v2 13/15] rockchip: rk3328: Add support to build bootable SPI image

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Similar to RK35xx the BootRom in RK3328 can read all data and look for idbloader at 0x8000, same as it does for SD and eMMC. Use the rksd format and modify the mkimage offset to generate a bootable u-boot-rockchip-spi.bin that can be written to 0x0 of

Re: [PATCH v2 12/15] Revert "rockchip: Allow booting from SPI"

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: This reverts commit 3523c07867b403d5b3b68812aebac8a5afa5be4c. Booting from SPI was already allowed before this commit was first introduced. A few lines further down the exact same code already existed and still does. Signed-off-by: Jonas Karlman

Re: [PATCH v2 11/15] rockchip: rk3328: Sync device tree from linux v6.8-rc1

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Sync rk3328 device tree from linux v6.8-rc1. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - No change --- arch/arm/dts/rk3328-evb.dts | 1 + arch/arm/dts/rk3328-nanopi-r2s.dts | 3 +-

Re: [PATCH v2 10/15] rng: rockchip: Use same compatible as linux

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Replace the rockchip,cryptov1-rng compatible with compatibles used in the linux device tree for RK3288, RK3328 and RK3399 to ease sync of SoC device tree from linux. Signed-off-by: Jonas Karlman Reviewed-by: Heinrich Schuchardt Reviewed-by: Kever

Re: [PATCH v2 08/15] rockchip: rk3328: Fix loading FIT from SD-card when booting from eMMC

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: When RK3328 boards run SPL from eMMC and fail to load FIT from eMMC due to it being missing or checksum validation fails there is a fallback to read FIT from SD-card. However, without proper pinctrl configuration reading FIT from SD-card will fail:

Re: [PATCH v2 09/15] gpio: rockchip: Use gpio alias id as gpio bank id

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: The U-Boot driver try to base the gpio bank id on the gpio-ranges prop and fall back to base the bank id on the node name. However, the linux driver try to base the bank id on the gpio alias id and fall back on node order. This can cause issues when

Re: [PATCH v2 07/15] rockchip: rk3328-orangepi-r1-plus: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-orangepi-r1-plus boards with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if

Re: [PATCH v2 05/15] rockchip: rk3328-rock-pi-e: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-rock-pi-e with new defaults. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an

Re: [PATCH v2 06/15] rockchip: rk3328-nanopi-r2: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-nanopi-r2* boards with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is

Re: [PATCH v2 04/15] rockchip: rk3328-roc-cc: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-roc-cc with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue

Re: [PATCH v2 05/15] rockchip: rk3328-rock-pi-e: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-rock-pi-e with new defaults. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an

Re: [PATCH v2 03/15] rockchip: rk3328-rock64: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-rock64 with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue

Re: [PATCH v2 02/15] rockchip: rk3328-evb: Update defconfig

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Update defconfig for rk3328-evb with new defaults. Add DM_RESET=y to support using reset signals. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT

Re: [PATCH v2 01/15] rockchip: rk3328: Update default u-boot,spl-boot-order prop

2024-03-13 Thread Kever Yang
On 2024/2/17 08:22, Jonas Karlman wrote: Change to use a common FIT load order, same-as-spl > SD-card > eMMC on RK3328 boards. Only EVB and Radxa ROCK Pi E is affected by this change. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v2:

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-03-13 Thread Simon Glass
Hi Miquel, On Wed, 13 Mar 2024 at 20:35, Miquel Raynal wrote: > > Hi Simon, > > s...@chromium.org wrote on Wed, 13 Mar 2024 11:25:42 +1300: > > > Hi Miquel, > > > > On Fri, 8 Mar 2024 at 20:42, Miquel Raynal > > wrote: > > > > > > Hi Simon, > > > > > > s...@chromium.org wrote on Fri, 8 Mar

Re: [PATCH v3 2/7] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-13 Thread Tom Rini
On Wed, Mar 13, 2024 at 04:57:57PM -0600, Sam Edwards wrote: [snip] > Still really excited for this to land! I'm going to have to blow the dust > off of my Clang/LLD support series here soon. :) Please tell me that includes updates to the Clang support in general copied over from the Linux

Re: [PATCH v3 3/3] cli: compile history code if and only if history config is selected

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 03:37:37PM +0800, Hanyuan Zhao wrote: > This commit allows user to determine whether to have history recording > in command-line. Previously to this commit, the CMD_HISTORY only sets > the compiling of cmd/history.c, and the history code in cli_readline.c > is always

Re: [PATCH v2] test: dm: add button_cmd test

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 02:51:03PM +, Caleb Connolly wrote: > Add a test for the button_cmd feature. This validates that commands can > be mapped to two buttons, that the correct command runs based on which > button is pressed, that only 1 command is run, and that no command runs > if

Re: [PATCH] stv0991: Remove stv0991 board and architecture code

2024-03-13 Thread Tom Rini
On Fri, Mar 08, 2024 at 02:38:13PM -0500, Tom Rini wrote: > This architecture and related board are unmaintained currently and have > been for a long time. Remove them. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] Makefile: Improve generated_defconfig file handling

2024-03-13 Thread Tom Rini
On Thu, Mar 07, 2024 at 09:38:22PM -0600, Sam Protsenko wrote: > Commit 2027e99e61aa ("Makefile: Run defconfig files through the C > preprocessor") adds `generated_defconfig' file, but fails to clean that > up. It might be useful to have that file around after `make' is done, > but it's better to

Re: [PATCH v5] cmd: add FDT setup for bootelf by flag

2024-03-13 Thread Tom Rini
On Fri, Mar 08, 2024 at 12:29:14AM +0300, Maxim Moskalets wrote: > From: Maxim Moskalets > > Added the ability to use FDT for ELF applications, required to run some > OS. To make FDT setup, you need to set the -d fdt_addr_r cmd option for > bootelf command. Enable by selecting

Re: [PATCH] board: developerbox: fix mem_map setup timing

2024-03-13 Thread Tom Rini
On Wed, Mar 06, 2024 at 03:11:10PM +0900, Masahisa Kojima wrote: > The setup of global variable mem_map was moved into enable_caches() > by commit a70c75cabae1 ("board: developerbox: move mem_map setup later") > since U-Boot was directly booted from NOR flash in XIP > and bss is not yet available

Re: [PATCH v2] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 10:19:37AM -0600, Andrew Davis wrote: > Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that > are now available in dts/upstream. Update the appended files based on > version of latest OF_UPSTREAM sync point (v6.7-rc7). > > Signed-off-by: Andrew Davis

Re: [PATCH v2] initcall: break loop immediately on failure

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 02:55:13PM +, Caleb Connolly wrote: > The current ordering always results in func pointing to the next > function in the init_sequence. e.g. if fdtdec_setup() fails, ret will > be set to the error code, then func will be updated to point to > initf_malloc(), only then

Re: [PATCH] boards: Remove empty BOARD_SPECIFIC_OPTIONS

2024-03-13 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:26:17AM -0500, Tom Rini wrote: > While there are currently uses for a stanza of "config BOARD_SPECIFIC_OPTIONS" > followed by "def_bool y" and a series of select/imply statements, having > this option set followed by nothing else doesn't provide anything. > Remove these

Re: [PATCH v3 2/3] cli: allow users to determine history buffer allocation method

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 03:37:35PM +0800, Hanyuan Zhao wrote: > This commit allows users to choose the appropriate memory > allocation method between static allocated and dynamically > calloc. The previous static-array way will not obviously > contribute to the final binary size since it is

Re: [PATCH v3 1/3] cli: panic when failed to allocate memory for the history buffer

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 03:37:33PM +0800, Hanyuan Zhao wrote: > This commit simply modifies the history initialize function, > replacing the return value by panic with reasons. The calling > chains of hist_init don't have steps explicitly throwing or > dealing with the ENOMEM error, and once the

Re: [PATCH v4 3/3] cmd: rng: Add rng list command

2024-03-13 Thread Tom Rini
On Mon, Mar 04, 2024 at 02:42:42PM +, Weizhao Ouyang wrote: > The 'rng list' command probes all RNG devices and list those devices > that are successfully probed. Also update the help info. > > Reviewed-by: Heinrich Schuchardt > Signed-off-by: Weizhao Ouyang Applied to u-boot/next,

Re: [PATCH v4 2/3] driver: rng: Fix SMCCC TRNG crash

2024-03-13 Thread Tom Rini
On Mon, Mar 04, 2024 at 02:42:41PM +, Weizhao Ouyang wrote: > Fix a SMCCC TRNG null pointer crash due to a failed smccc feature > binding. > > Fixes: 53355bb86c25 ("drivers: rng: add smccc trng driver") > Reviewed-by: Heinrich Schuchardt > Signed-off-by: Weizhao Ouyang Applied to

Re: [PATCH v4 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-03-13 Thread Tom Rini
On Mon, Mar 04, 2024 at 02:42:40PM +, Weizhao Ouyang wrote: > According to PSCI specification DEN0022F, PSCI_FEATURES is used to check > whether the SMCCC is implemented by discovering SMCCC_VERSION. > > Signed-off-by: Weizhao Ouyang Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH v2 2/2] arm64: Enable CONFIG_64BIT for static analysis

2024-03-13 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:04:29AM +0300, Dan Carpenter wrote: > In the Makefile there is a line that says this: > > # the checker needs the correct machine size > CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32) > > Set CONFIG_64BIT for ARM64 so that we pass -m64 to the static checkers >

Re: [PATCH v2 1/2] Kconfig: move CONFIG_32/64BIT to arch/Kconfig

2024-03-13 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:04:15AM +0300, Dan Carpenter wrote: > These configs are used in multiple places so put them in a shared > Kconfig file. > > Signed-off-by: Dan Carpenter > Reviewed-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] fdt: Fix bootm_low handling

2024-03-13 Thread Tom Rini
On Sat, Mar 02, 2024 at 11:54:02PM +0100, Marek Vasut wrote: > According to README CFG_SYS_BOOTMAPSZ section, in case both "bootm_low" and > "bootm_size" variables are defined, "bootm_mapsize" variable is not defined > and CFG_SYS_BOOTMAPSZ macro is not defined, all data for the Linux kernel >

Re: [PATCH 2/2] sandbox: select CONFIG_64BIT for X86_64

2024-03-13 Thread Tom Rini
On Tue, Mar 05, 2024 at 06:16:29PM +0300, Dan Carpenter wrote: > Select CONFIG_64BIT so that we pass the -m64 option (instead of -m32) to > static analysis tools. > > Signed-off-by: Dan Carpenter For v2 of this series, the subject on this one is wrong as it's x86 and not sandbox. -- Tom

Re: [PATCH v3 05/16] power: rk8xx: add support for RK806

2024-03-13 Thread Kever Yang
Hi Quentin,     This patch build fail in CI: Building current source for 1 boards (1 thread, 32 jobs per thread)    sandbox:  +   sandbox64 +drivers/power/pmic/rk8xx.c:141:10: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1

Pull request efi-2024-04-rc5

2024-03-13 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit f3c979dd0053c082d2df170446923e7ce5edbc2d: Prepare v2024.04-rc4 (2024-03-11 13:11:46 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2024-04-rc5 for you to fetch changes up to

Re: [PATCH v3 2/7] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-13 Thread Sam Edwards
On 3/13/24 10:23, Ilias Apalodimas wrote: commit 3ebd1cbc49f0 ("arm: make __bss_start and __bss_end__ compiler-generated") and commit f84a7b8f54db ("ARM: Fix __bss_start and __bss_end in linker scripts") were moving the bss_start/end on c generated variables that were injected in their own

Re: [PATCH v3 2/7] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-13 Thread Richard Henderson
On 3/13/24 11:43, Ilias Apalodimas wrote: Hi Richard, On Wed, 13 Mar 2024 at 22:19, Richard Henderson wrote: On 3/13/24 06:23, Ilias Apalodimas wrote: +++ b/arch/arm/cpu/armv8/u-boot-spl.lds @@ -63,18 +63,11 @@ SECTIONS _image_binary_end = .; - .bss_start (NOLOAD) : { -

Re: [PATCH v3 2/7] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-13 Thread Ilias Apalodimas
Hi Richard, On Wed, 13 Mar 2024 at 22:19, Richard Henderson wrote: > > On 3/13/24 06:23, Ilias Apalodimas wrote: > > +++ b/arch/arm/cpu/armv8/u-boot-spl.lds > > @@ -63,18 +63,11 @@ SECTIONS > > > > _image_binary_end = .; > > > > - .bss_start (NOLOAD) : { > > - . = ALIGN(8);

[PULL] u-boot-mips fixes for v2024.04

2024-03-13 Thread Daniel Schwierzeck
Hi Tom, please pull two bugfixes for MIPS, thanks. CI: https://source.denx.de/u-boot/custodians/u-boot-mips/-/pipelines/19933 The following changes since commit f3c979dd0053c082d2df170446923e7ce5edbc2d: Prepare v2024.04-rc4 (2024-03-11 13:11:46 -0400) are available in the Git repository at:

Re: [PATCH v3 7/7] arm: remove redundant section alignments

2024-03-13 Thread Richard Henderson
On 3/13/24 06:23, Ilias Apalodimas wrote: Previous patches cleaning up linker symbols, also merged any explicit . = ALIGN(x); into section definitions -- e.g .bss ALIGN(x) : instead of . = ALIGN(x); . bss : {...} However, if the output address is not specified then one will be chosen for the

Re: [PATCH v3 2/7] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-13 Thread Richard Henderson
On 3/13/24 06:23, Ilias Apalodimas wrote: +++ b/arch/arm/cpu/armv8/u-boot-spl.lds @@ -63,18 +63,11 @@ SECTIONS _image_binary_end = .; - .bss_start (NOLOAD) : { - . = ALIGN(8); - KEEP(*(.__bss_start)); - } >.sdram - - .bss (NOLOAD) : { +

Re: [PATCH] starfive: visionfive2: switch to standard boot

2024-03-13 Thread Milan P . Stanić
On Wed, 2024-02-21 at 13:00, Nam Cao wrote: > Distro boot scripts are deprecated. Use standard boot instead. I had to enable 'CONFIG_CMD_SYSBOOT=y' in configs/starfive_visionfive2_defconfig because it doesn't boot without it. With this option it boots fine with this patch. Tested on u-boot version

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-03-13 Thread Caleb Connolly
Hi Marek, On 06/02/2024 20:36, Marek Vasut wrote: > On 1/31/24 15:57, Caleb Connolly wrote: >> The Qualcomm specific dwc3 wrapper isn't hugely complicated, implemented >> the missing initialisation for host and gadget mode. >> >> Signed-off-by: Caleb Connolly >> --- >>  

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-13 Thread Igor Opaniuk
Hi Colin, On Tue, Mar 12, 2024 at 4:19 PM Mattijs Korpershoek < mkorpersh...@baylibre.com> wrote: > Hi Colin, > > Thank you for the patch. > > On mar., mars 12, 2024 at 07:57, Colin McAllister > wrote: > > Sam also gave his review here: > >

Re: [PATCH v4 1/2] android_ab: Add missing semicolon

2024-03-13 Thread Igor Opaniuk
Hi Colin, On Tue, Mar 12, 2024 at 1:57 PM Colin McAllister wrote: > From: Colin McAllister > > Found a missing semicolon in code protected by a #if that will never > evaluate to true due to a separate issue. Fixing this issue before > addressing the #if. > > Fixes: 3430f24bc6 ("android_ab: Try

Re: [PATCH v3 3/4] clk: qcom: add support for power domains uclass

2024-03-13 Thread Caleb Connolly
On 11/03/2024 21:33, Volodymyr Babchuk wrote: > Now sub-drivers for particular SoCs can register them as power domain > drivers. This is needed for upcoming SM8150 support, because it needs > to power up the Ethernet module. > > Signed-off-by: Volodymyr Babchuk > > --- > Caleb suggested to

Re: [PATCH v3 3/4] clk: qcom: add support for power domains uclass

2024-03-13 Thread Caleb Connolly
Hi Volodymyr, On 11/03/2024 21:33, Volodymyr Babchuk wrote: > Now sub-drivers for particular SoCs can register them as power domain > drivers. This is needed for upcoming SM8150 support, because it needs > to power up the Ethernet module. > Thanks again for working on this. I've been trying to

Help: Marvell Armada 3720 board verified boot function as non-verified

2024-03-13 Thread Lev Olshvang
Hi List Our project already several years develop for Marvell Armada 3720 board Recently we decided to implement verified boot. I modified uboot configuration to support FIT image format and verify signature kernel . I compiled uboot and added public key to u-boot.bin I also created signed

[PATCH] gpio: mcp230xx: Add support for models with SPI interface.

2024-03-13 Thread Piotr Wojtaszczyk
Signed-off-by: Piotr Wojtaszczyk --- drivers/gpio/Kconfig | 3 + drivers/gpio/Makefile| 2 +- drivers/gpio/mcp230xx_gpio.c | 144 ++- 3 files changed, 144 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig

Re: [PATCH] imx8m*_venice: move venice to OF_UPSTREAM

2024-03-13 Thread Tim Harvey
On Wed, Mar 13, 2024 at 6:20 AM Sumit Garg wrote: > > On Wed, 13 Mar 2024 at 06:46, Fabio Estevam wrote: > > > > Hi Tim, > > > > On Tue, Mar 12, 2024 at 4:05 PM Tim Harvey wrote: > > > > > > Move to imx8m{m,n,p}-venice to OF_UPSTREAM: > > > - replace the non-upstream generic

Re: [PATCH] colibri-imx8x: Fix sc_misc_otp_fuse_read() error check

2024-03-13 Thread Hiago De Franco
On 13.03.2024 08:09, Marcel Ziswiler wrote: > Hi Fabio > > Thanks! > > On Tue, 2024-03-12 at 21:36 -0300, Fabio Estevam wrote: > > Commit aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage") > > made an incorrect logic change in the error code check of > > sc_misc_otp_fuse_read():

[PATCH v3 7/7] arm: remove redundant section alignments

2024-03-13 Thread Ilias Apalodimas
Previous patches cleaning up linker symbols, also merged any explicit . = ALIGN(x); into section definitions -- e.g .bss ALIGN(x) : instead of . = ALIGN(x); . bss : {...} However, if the output address is not specified then one will be chosen for the section. This address will be adjusted to fit

[PATCH v3 6/7] arm: move image_copy_start/end to linker symbols

2024-03-13 Thread Ilias Apalodimas
image_copy_start/end are defined as c variables in order to force the compiler emit relative references. However, defining those within a section definition will do the same thing since [0]. So let's remove the special sections from the linker scripts, the variable definitions from sections.c and

[PATCH v3 5/7] arm: fix __efi_runtime_start/end definitions

2024-03-13 Thread Ilias Apalodimas
__efi_runtime_start/end are defined as c variables for arm7 only in order to force the compiler emit relative references. However, defining those within a section definition will do the same thing since [0]. On top of that the v8 linker scripts define it as a symbol. So let's remove the special

[PATCH v3 4/7] arm: clean up v7 and v8 linker scripts for __rel_dyn_start/end

2024-03-13 Thread Ilias Apalodimas
commit 47bd65ef057f ("arm: make __rel_dyn_{start, end} compiler-generated") were moving the __rel_dyn_start/end on c generated variables that were injected in their own sections. The reason was that we needed relative relocations for position independent code and linker bugs back then prevented us

[PATCH v3 3/7] arm: fix __efi_runtime_rel_start/end definitions

2024-03-13 Thread Ilias Apalodimas
__efi_runtime_rel_start/end are defined as c variables for arm7 only in order to force the compiler emit relative references. However, defining those within a section definition will do the same thing since [0]. On top of that the v8 linker scripts define it as a symbol. So let's remove the

[PATCH v3 2/7] arm: clean up v7 and v8 linker scripts for bss_start/end

2024-03-13 Thread Ilias Apalodimas
commit 3ebd1cbc49f0 ("arm: make __bss_start and __bss_end__ compiler-generated") and commit f84a7b8f54db ("ARM: Fix __bss_start and __bss_end in linker scripts") were moving the bss_start/end on c generated variables that were injected in their own sections. The reason was that we needed relative

[PATCH v3 1/7] arm: baltos: remove custom linker script

2024-03-13 Thread Ilias Apalodimas
commit 3d74a0977f514 ("ti: am335x: Remove unused linker script") removed the linker script for the TI variant. This linker script doesn't seem to do anything special and on top of that, has no definitions for the EFI runtime sections. So let's get rid of it and use the generic linker script which

[PATCH v3 0/7] Clean up arm linker scripts

2024-03-13 Thread Ilias Apalodimas
The arm linker scripts had a mix of symbols and C defined variables in an effort to emit relative references instead of absolute ones e.g [0]. A linker bug prevented us from doing so [1] -- fixed since 2016. This has led to confusion over the years, ending up with mixed section definitions. Some

Re: [PATCH v2 4/4] rockchip: Migrate to use DM_USB_GADGET on RK3328

2024-03-13 Thread Jonas Karlman
Hi Kever, On 2024-03-13 11:45, Kever Yang wrote: > Hi Jonas, > > Again, not able to apply changes for rk3328 defconfig. As mentioned in the cover letter, this series depends on the "rockchip: rk3328: Update defconfigs, DTs and enable boot from SPI" [1] series for a clean apply. That series

Re: [PATCH v2 3/5] rockchip: rk3328: regenerate defconfigs

2024-03-13 Thread Jonas Karlman
Hi Kever and Chen-Yu, On 2024-03-13 15:43, Chen-Yu Tsai wrote: > Hi, > > On Wed, Mar 13, 2024 at 6:29 PM Kever Yang wrote: >> >> Hi Chen-Yu, >> >> On 2024/2/12 21:51, Chen-Yu Tsai wrote: >> >> From: Chen-Yu Tsai >> >> Regenerate RK3328 defconfigs after adding imply statements. >> >>

Re: [PATCH v2 3/5] rockchip: rk3328: regenerate defconfigs

2024-03-13 Thread Chen-Yu Tsai
Hi, On Wed, Mar 13, 2024 at 6:29 PM Kever Yang wrote: > > Hi Chen-Yu, > > On 2024/2/12 21:51, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > Regenerate RK3328 defconfigs after adding imply statements. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Christopher Obbard > Reviewed-by: Dragan

Re: [PATCH] imx8m*_venice: move venice to OF_UPSTREAM

2024-03-13 Thread Sumit Garg
On Wed, 13 Mar 2024 at 06:46, Fabio Estevam wrote: > > Hi Tim, > > On Tue, Mar 12, 2024 at 4:05 PM Tim Harvey wrote: > > > > Move to imx8m{m,n,p}-venice to OF_UPSTREAM: > > - replace the non-upstream generic imx8m{m,n,p}-venice dt with one of the > >dt's from the OF_LIST > > - handle the

Re: [PATCH v2 5/5] board: add support for Schneider HMIBSC board

2024-03-13 Thread Sumit Garg
On Wed, 13 Mar 2024 at 16:59, Stephan Gerhold wrote: > > On Wed, Mar 13, 2024 at 12:08:58PM +0530, Sumit Garg wrote: > > On Mon, 11 Mar 2024 at 20:07, Stephan Gerhold wrote: > > > On Mon, Mar 11, 2024 at 04:40:26PM +0530, Sumit Garg wrote: > > > > Support for Schneider Electric HMIBSC. Features:

Re: [PATCH v2 5/5] board: add support for Schneider HMIBSC board

2024-03-13 Thread Stephan Gerhold
On Wed, Mar 13, 2024 at 12:08:58PM +0530, Sumit Garg wrote: > On Mon, 11 Mar 2024 at 20:07, Stephan Gerhold wrote: > > On Mon, Mar 11, 2024 at 04:40:26PM +0530, Sumit Garg wrote: > > > Support for Schneider Electric HMIBSC. Features: > > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53,

[PATCH next v1 1/1] arm: dts: ast2600-x4tf: Add new dts for ASUS X4TF

2024-03-13 Thread Kelly Hung
This is the new bmc dts for ASUS X4TF server. Signed-off-by: Kelly Hung --- V1: Add a new bmc dts for ASUS X4TF server. --- arch/arm/dts/Makefile | 4 +- arch/arm/dts/ast2600-x4tf.dts | 161 ++ 2 files changed, 164 insertions(+), 1 deletion(-) create

[PATCH next v1 0/1] Add new bmc dts for ASUS X4TF server

2024-03-13 Thread Kelly Hung
Add bmc dts to ASUS X4TF server, we also submitted dts to linux place. Please refer to here, https://lore.kernel.org/lkml/?q=x4tf. Kelly Hung (1): arm: dts: ast2600-x4tf: Add new dts for ASUS X4TF arch/arm/dts/Makefile | 4 +- arch/arm/dts/ast2600-x4tf.dts | 161

[PATCH v1 1/1] arm: dts: ast2600-x4tf: Add new dts for ASUS X4TF

2024-03-13 Thread Kelly Hung
This is the new bmc dts for ASUS X4TF server. Signed-off-by: Kelly Hung --- V1: Add a new bmc dts for ASUS X4TF server. --- arch/arm/dts/Makefile | 4 +- arch/arm/dts/ast2600-x4tf.dts | 161 ++ 2 files changed, 164 insertions(+), 1 deletion(-) create

[PATCH v1 0/1] Add new bmc dts for ASUS X4TF server

2024-03-13 Thread Kelly Hung
Add bmc dts to ASUS X4TF server, we also submitted dts to linux place. Please refer to here, https://lore.kernel.org/lkml/?q=x4tf. Kelly Hung (1): arm: dts: ast2600-x4tf: Add new dts for ASUS X4TF arch/arm/dts/Makefile | 4 +- arch/arm/dts/ast2600-x4tf.dts | 161

[PATCH-V2] arm:suniv:complete the serial port configuration of Suniv

2024-03-13 Thread lhdjply
From: lhdjply Due to the different serial ports used by each board, the serial IO configuration needs to be improved. Signed-off-by: lhdjply --- arch/arm/mach-sunxi/board.c | 4 ++-- include/sunxi_gpio.h| 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH] arm:suniv:complete the serial port configuration of Suniv

2024-03-13 Thread lhdjply
From: lhdjply 111 Signed-off-by: lhdjply --- arch/arm/mach-sunxi/board.c | 4 ++-- include/sunxi_gpio.h| 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-sunxi/board.c b/arch/arm/mach-sunxi/board.c index f4dbb2a740..b91c9629e4 100644 ---

Re: [PATCH v2 4/4] rockchip: Migrate to use DM_USB_GADGET on RK3328

2024-03-13 Thread Kever Yang
Hi Jonas, Again, not able to apply changes for rk3328 defconfig. Thanks, - Kever On 2024/3/11 02:51, Jonas Karlman wrote: USB gadget is not working fully as expected on RK3328, it uses a board_usb_init() function to initialize the DWC2 OTG port. The board_usb_init() function does not

Re: [PATCH v2 1/4] rockchip: Update the default USB Product ID value

2024-03-13 Thread Kever Yang
On 2024/3/11 02:50, Jonas Karlman wrote: RK3036 is using the USB product id normally used by RK3066B, and RK3328 is using the product id normally used by RK3368. Fix this and update the default USB_GADGET_PRODUCT_NUM Kconfig option for remaining supported Rockchip SoCs to match the product id

Re: [PATCH v4] board: rockchip: add Rockchip Toybrick TB-RK3588X board

2024-03-13 Thread Kever Yang
On 2024/3/11 11:57, Elon Zhang wrote: TB-RK3588X board is a Rockchip Toybrick RK3588 based development board. Specification: Rockchip Rk3588 SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 8/16GB Memory LPDDR4x Mali G610MC4 GPU 2× MIPI-CSI0 Connector

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-13 Thread Kever Yang
On 2024/2/27 07:08, Jonas Karlman wrote: RK3036 is using the USB product id normally used by RK3066B, and RK3328 is using the product id normally used by RK3368. Fix this and update the default USB_GADGET_PRODUCT_NUM Kconfig option for remaining supported Rockchip SoCs to match the product id

Re: [PATCH v3 3/6] rockchip: Use common bss and stack addresses on RK3328

2024-03-13 Thread Kever Yang
Hi Jonas,     This patch does not able to apply on next, could you help to take a look. And also add document of memory layout in rockchip.rst if possible. Thanks, - Kever On 2024/3/3 03:16, Jonas Karlman wrote: With the stack and text base used by U-Boot SPL and proper on RK3328 there

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-13 Thread Kever Yang
On 2024/2/26 06:10, Jonas Karlman wrote: The USB2PHY regs already contain working default reset values for RK3328 and RK35xx as evidenced by the fact that this driver never has changed a single value for these SoCs. Reduce to only configure utmi_suspend_n and utmi_sel bits similar to what is

Re: [PATCH v3 01/16] rockchip: spi: rk_spi: do not write bytes when in read-only mode

2024-03-13 Thread Kever Yang
On 2024/3/4 19:29, Quentin Schulz wrote: From: Quentin Schulz The read-only mode is currently supported but only for 16b-aligned buffers. For unaligned buffers, the last byte will be read in RW mode right now, which isn't what is desired. Instead, let's put the controller back into RO mode

Re: [PATCH v2 3/5] rockchip: rk3328: regenerate defconfigs

2024-03-13 Thread Kever Yang
Hi Chen-Yu, On 2024/2/12 21:51, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Regenerate RK3328 defconfigs after adding imply statements. Signed-off-by: Chen-Yu Tsai Reviewed-by: Christopher Obbard Reviewed-by: Dragan Simic --- configs/evb-rk3328_defconfig | 3 ---

Re: [PATCH v2 12/12] rockchip: board: Move gpt_capsule_update_setup() call

2024-03-13 Thread Kever Yang
On 2024/3/13 07:36, Jonas Karlman wrote: Move the call to gpt_capsule_update_setup() from the weak function rk_board_late_init() into the main board_late_init() function. Also change to use IS_ENABLED() instead for defined(). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, -

Re: [PATCH v2 01/12] board: rockchip: rk3399: Add device tree files to MAINTAINERS

2024-03-13 Thread Kever Yang
On 2024/3/13 07:36, Jonas Karlman wrote: Update MAINTAINERS files for RK3399 boards to include related device tree files. Also correct a few filenames. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - Use glob pattern where appropriate ---

Re: [PATCH 01/19] spi: cadence_qspi: Add support for DDR PHY mode

2024-03-13 Thread Dan Carpenter
> diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c > index faf02c7778..5895b5de09 100644 > --- a/drivers/mtd/spi/spi-nor-core.c > +++ b/drivers/mtd/spi/spi-nor-core.c > @@ -1511,8 +1511,10 @@ static const struct flash_info *spi_nor_read_id(struct > spi_nor *nor) >

Re: [PATCH] colibri-imx8x: Fix sc_misc_otp_fuse_read() error check

2024-03-13 Thread Marcel Ziswiler
Hi Fabio Thanks! On Tue, 2024-03-12 at 21:36 -0300, Fabio Estevam wrote: > Commit aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage") > made an incorrect logic change in the error code check of > sc_misc_otp_fuse_read(): > > -   if (sc_err == SC_ERR_NONE) { > +   if

Re: [PATCH] apalis-imx8: Fix sc_misc_otp_fuse_read() error check

2024-03-13 Thread Marcel Ziswiler
Hi Fabio Thanks! On Tue, 2024-03-12 at 21:59 -0300, Fabio Estevam wrote: > Commit bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") > made an incorrect logic change in the error code check of > sc_misc_otp_fuse_read(): > > -   if (scierr == SC_ERR_NONE) { > +   if

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-03-13 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Wed, 13 Mar 2024 11:25:42 +1300: > Hi Miquel, > > On Fri, 8 Mar 2024 at 20:42, Miquel Raynal wrote: > > > > Hi Simon, > > > > s...@chromium.org wrote on Fri, 8 Mar 2024 15:44:25 +1300: > > > > > Hi Miquel, > > > > > > On Tue, 6 Feb 2024 at 01:17, Miquel

Re: [PATCH v2] cmd: mtd: OTP access support

2024-03-13 Thread Arseniy Krasnov
On 13.03.2024 09:48, Michael Nazzareno Trimarchi wrote: > Hi > > On Wed, Mar 13, 2024 at 7:43 AM Arseniy Krasnov > wrote: >> >> Sorry, please ping >> >> Thanks, Arseniy >> >> >> On 11.02.2024 02:16, Arseniy Krasnov wrote: >>> Sorry, pls ping >>> >>> Thanks, Arseniy >>> >>> On 08.01.2024

[PATCH v3] cmd: mtd: OTP access support

2024-03-13 Thread Arseniy Krasnov
Add access to OTP region. It supports info, dump, write and lock operations. Usage example: 'mtd otpread nand0 u 0 1024' - dump 1024 bytes of user area starting from offset 0 of device 'nand0'. 'mtd otpwrite nand0 10 11223344' - write binary data 0x11, 0x22, 0x33, 0x44 to offset 10 to user

Re: [PATCH 7/7 v2] arm: remove redundant section alignments

2024-03-13 Thread Ilias Apalodimas
Hi Richard, Pasting some of the discussions we had over IRC for completeness. On Tue, 12 Mar 2024 at 19:00, Richard Henderson wrote: > > On 3/12/24 04:08, Ilias Apalodimas wrote: > > index 33f4624b561d..ccdd1966cfbc 100644 > > --- a/arch/arm/cpu/armv8/u-boot.lds > > +++

Re: [PATCH] arm64: zynqmp: Do not describe u-boot.itb if SPL is disabled

2024-03-13 Thread Ilias Apalodimas
On Wed, 13 Mar 2024 at 08:42, Michal Simek wrote: > > > > On 3/12/24 20:12, Ilias Apalodimas wrote: > > On Tue, 12 Mar 2024 at 17:55, Michal Simek wrote: > >> > >> > >> > >> On 3/12/24 07:14, Ilias Apalodimas wrote: > >>> Hi Michal > >>> > >>> Apologies for the late reply > >>> > >>> On Wed, 6

  1   2   >