On 07/01/2013 12:51 PM, Wolfgang Denk wrote:
Dear Mike Dunn,
In message 51d1c455.9010...@newsguy.com you wrote:
But there's a good motivation for wanting to turn off optimization.
I disagree here. If you are hunting down a problem, you want to be as
close at the original code
On 07/01/2013 04:37 AM, Wolfgang Denk wrote:
Dear tiger...@viatech.com.cn,
please do not top post / full quote.
In message fe7aded5c2218b4786c09cd97dc4c49f940...@exchbj02.viatech.com.bj
you wrote:
During debug u-boot with JTAG tools, maybe turning off optimizations was
recommended.
Newer gcc versions warn about unused variables. This patch corrects a few of
those warnings that popped up in a build for the palmtreo680 board.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/mtd/nand/docg4_spl.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions
Newer gcc versions warn about unused variables. This patch corrects a few of
those warnings that popped up in a build for the palmtreo680 board.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/usb/gadget/pxa27x_udc.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions
Newer gcc versions warn about unused variables. This patch corrects a few of
those warnings that popped up in a pxa build.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/mtd/nand/docg4_spl.c| 15 +++
drivers/usb/gadget/pxa27x_udc.c | 14 +-
2 files changed
On 06/23/2013 03:13 AM, Albert ARIBAUD wrote:
Hi Marek,
FYI, I am using the ARM cross-toolchain available in my Ubuntu 13.04.
For some reason, I feel the linaro ones were always stuffed with
experimental
and semi-broken stuff :-(
Maybe they were; all I can say is, the Ubuntu/Linaro
in the git repository at:
git://git.denx.de/u-boot-pxa.git master
for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:
pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28
+0200)
Mike
On the xscale, the icache must be invalidated and the write buffers drained
after writing code over the data bus, even if the caches are disabled. Tested
on the pxa270.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
arch/arm/lib/relocate.S |9 +
1 files changed, 9 insertions
operations
are performed before jumping to the relocated code.
Whether other cores need a similiar operation after code relocation remains an
open question.
Thanks Albert.
Mike Dunn (2):
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation
arch/arm/cpu
Pass '-mcpu=xscale' to the compiler instead of march and mtune. This will cause
gcc to define the __XSCALE__ macro.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
arch/arm/cpu/pxa/config.mk |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/pxa/config.mk b
On 06/20/2013 06:56 AM, Marek Vasut wrote:
Dear Mike Dunn,
On the xscale, the icache must be invalidated and the write buffers drained
after writing code over the data bus, even if the caches are disabled.
After rebasing with the main git repository, u-boot began crashing in odd
places
On 06/17/2013 03:29 PM, Scott Wood wrote:
On 06/17/2013 12:44:55 PM, Mike Dunn wrote:
Commit dfe64e2c89731a3f9950d7acd8681b68df2bae03:
mtd: resync with Linux-3.7.1
broke the docg4 driver. Specifically:
- some of the prototypes of the ecc methods changed
- the NAND_NO_AUTOINCR flag
display the auto-boot progress nicely.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v6: mv doc/README.palmtreo680 board/palmtreo680/README
v5: do not use a custom linker script for spl build
v4:
- use CONFIG_MACH_TYPE instead of MACH_TYPE_TREO680 to initialize
ago, but I must have been mistaken. Sorry.
I would have labeled these patches RESEND, but since I submitted v5 I learned
that README files now go into the board/ directory, so I made that change and
called it v6. Each patch contains its full changelog.
Thanks!
Mike Dunn (2):
pxa: add support
.
- The integrated flash controller's reliable mode is used, requiring that
alternate 2k regions (4 pages) are skipped when writing.
For these reasons, a u-boot image can not be written using nandwrite from
mtd-utils.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v6: no change
v5
on the docg4 on my palmtre680 board.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/mtd/nand/docg4.c | 26 ++
1 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
index 7dd9953..09f01c8 100644
--- a/drivers
The comment in the low-level initialization function cpu_init_crit() says that
the caches are being disabled, but (oddly) the icache is actually turned on.
This is probably not a good idea prior to relocating code, so this patch turns
it off. Tested on the pxa270.
Signed-off-by: Mike Dunn miked
ran. This patch
fixes it. Cache coherency problems are often hit-and-miss (ha ha), and this
latent problem didn't rear its ugly head until now. Tested on the pxa270.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
I realize that __ARM_ARCH_5TE__ does not necessarily mean xscale. But how else
I just piled work onto you ;-)
It's OK. I have plans to do this anyway.
CCing Mike Dunn, you two should coordinate.
Thanks Marek. Was following this on the ML. Will take a look when I get a
chance.
___
U-Boot mailing list
U-Boot@lists.denx.de
On 04/20/2013 03:25 AM, Marek Vasut wrote:
Dear Mike Dunn,
[...]
I fixed the calloc() semantics and applied, thanks. Please repost whatever is
still missing in u-boot-pxa/master and I'll then roll pullRQ for mainline.
Thanks Marek. Now I see your point regarding calloc() semantics. Only
On the pxa270, if the udc device is not disabled before jumping to linux, the
device fails to initialize in linux because it was left in a running state, and
the linux driver assumes that it is in a disabled state.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Arguably, this is a bug
On 04/20/2013 03:25 AM, Marek Vasut wrote:
Dear Mike Dunn,
I fixed the calloc() semantics and applied, thanks. Please repost whatever is
still missing in u-boot-pxa/master and I'll then roll pullRQ for mainline.
Oops, the board support patch is not in your tree either. Will repost
On 04/20/2013 11:01 AM, Marek Vasut wrote:
Dear Mike Dunn,
On 04/20/2013 03:25 AM, Marek Vasut wrote:
Dear Mike Dunn,
I fixed the calloc() semantics and applied, thanks. Please repost
whatever is still missing in u-boot-pxa/master and I'll then roll pullRQ
for mainline.
Oops, the board
-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v5: do not use a custom linker script for spl build
v4:
- use CONFIG_MACH_TYPE instead of MACH_TYPE_TREO680 to initialize
bi_arch_number
- use offset from CONFIG_SYS_DRAM_BASE to initialize bi_boot_params,
instead of hard-coding
.
- The integrated flash controller's reliable mode is used, requiring that
alternate 2k regions (4 pages) are skipped when writing.
For these reasons, a u-boot image can not be written using nandwrite from
mtd-utils.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v5: on error, return
On 04/18/2013 06:54 AM, Marek Vasut wrote:
Dear Mike Dunn,
[...]
+if (argc != 3) {
+printf(usage: %s image file mtd dev node\n, argv[0]);
btw is this /dev/mtdX or /dev/mtdblockX ?
/dev/mtdx You must have defined a partition that starts at the offset at which
you
-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v4:
- use CONFIG_MACH_TYPE instead of MACH_TYPE_TREO680 to initialize
bi_arch_number
- use offset from CONFIG_SYS_DRAM_BASE to initialize bi_boot_params,
instead of hard-coding an absolute address
- use shift operator to set one
Thanks again Marek. A question below...
On 04/14/2013 10:38 AM, Marek Vasut wrote:
[...]
+
+if (argc != 3) {
+printf(usage: %s image file mtd dev node\n, argv[0]);
+exit(-1);
Use proper errno and return as you're returning from main() anyway.
Agreed
.
- The integrated flash controller's reliable mode is used, requiring that
alternate 2k regions (4 pages) are skipped when writing.
For these reasons, a u-boot image can not be written using nandwrite from
mtd-utils.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v4:
- use return
On 04/14/2013 10:34 AM, Marek Vasut wrote:
Dear Mike Dunn,
[...]
+int board_init(void)
+{
+/* We have RAM, disable cache */
+dcache_disable();
+icache_disable();
+
+gd-bd-bi_arch_number = MACH_TYPE_TREO680;
This is not needed, just define CONFIG_MACH_TYPE in treo680
On 04/15/2013 11:33 AM, Marek Vasut wrote:
Dear Mike Dunn,
[...]
+#ifdef CONFIG_SPL_BUILD
+void *memcpy(void *dest, const void *src, size_t count)
+{
CONFIG_SPL_LIBCOMMON_SUPPORT shall give you memcpy.
This does not appear to be the case. Unless I'm mistaken, memcpy
On 04/14/2013 10:44 AM, Marek Vasut wrote:
Hi Mike,
Hi,
This patchset adds support for the Palm Treo 680 smartphone. I had to make
some minor tweaks to u-boot to get things working. Most of these changes
are small, and most only touch the pxa arch.
Thanks for looking.
I pushed what
On 04/11/2013 12:19 PM, Marek Vasut wrote:
Dear Mike Dunn,
This patch adds the bitrev library from the linux kernel. This is a simple
algorithm that uses an 8 bit look-up table to reverse the bits in data
types of 8, 16, or 32 bit widths. The docg4 nand flash driver uses it.
[port from
On 04/11/2013 12:20 PM, Marek Vasut wrote:
Dear Mike Dunn,
A quick overview of u-boot implementation on the treo 680...
The treo 680 has a Diskonchip G4 nand flash chip. This device has a 2k
region that maps to the system bus at the reset vector in a NOR-like
fashion so that it can
On 04/11/2013 02:00 PM, Scott Wood wrote:
On 04/10/2013 07:45:27 PM, Mike Dunn wrote:
This patch adds a driver for the diskonchip G4 nand flash device. It is
based
on the driver from the linux kernel.
This also includes a separate SPL driver. A separate SPL driver is used
because
This adds the definitions required to support the LCD device on the Palm Treo
680.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: no change
v2: no change
drivers/video/pxa_lcd.c | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff
runs after the driver initialization
- userland utility for programming u-boot to flash moved to tools/palmtreo680
- commit message for patches that add bitrev library and docg4 driver contain
the commit and linux version for when the code was added to linux
Mike Dunn (8):
pxa_lcd: add
. It is invoked no
where else in the code.
While I was at it, I noticed that two other function prototypes in the same
header file are also neither implemented nor invoked anywhere, so I removed them
as well.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: no change
v2: no change
Make lcd_init() a weak pointer so that boards can overload it if necessary. The
palmtreo680 board needs to wiggle some gpios and configure the pwm controller in
order to get the lcd and its backlight working.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: no change
v2:
- use
]
[originally added: v2.6.20 by commit a5cfc1ec58a07074dacb6aa8c79eff864c966d12]
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: no change
v2: remove 'extern' from function prototypes in bitrev.h
include/linux/bitrev.h | 23 ++
lib/Makefile |1
On the pxa270, if the udc device is not disabled before jumping to linux, the
device fails to initialize in linux because it was left in a running state, and
the linux driver assumes that it is in a disabled state.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: no change
v2
.
- The integrated flash controller's reliable mode is used, requiring that
alternate 2k regions (4 pages) are skipped when writing.
For these reasons, a u-boot image can not be written using nandwrite from
mtd-utils.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: new patch; split off
3.4 commit 570469f3bde7f71cc1ece07a18d54a05b6a8775d]
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: replace dbg macro with MTDDEBUG
v2: remove commented-out code
drivers/mtd/nand/Makefile|2 +
drivers/mtd/nand/docg4.c | 1028
-by: Mike Dunn miked...@newsguy.com
---
Changelog:
v3: flash_u-boot utility split into separate patch
v2:
- tabs removed in #defines in palmtreo680.h
- utility for programming u-boot to flash moved to tools/palmtreo680
CREDITS |4 +
MAINTAINERS
On 04/10/2013 06:43 PM, Rob Herring wrote:
On Wed, Apr 10, 2013 at 8:12 AM, Suriyan Ramasami suriya...@gmail.com wrote:
Initialize usb and ide.
Scan through the usb for storage and boot capable partitions.
Scan through the ide interface for boot capable partitions.
Present such bootable
the driver initialization
- userland utility for programming u-boot to flash moved to tools/palmtreo680
- commit message for patches that add bitrev library and docg4 driver contain
the commit and linux version for when the code was added to linux
Mike Dunn (7):
pxa_lcd: add
This adds the definitions required to support the LCD device on the Palm Treo
680.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/video/pxa_lcd.c | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/drivers/video/pxa_lcd.c b/drivers
Make lcd_init() a weak pointer so that boards can overload it if necessary. The
palmtreo680 board needs to wiggle some gpios and configure the pwm controller in
order to get the lcd and its backlight working.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/video/pxa_lcd.c |2 +-
1
. It is invoked no
where else in the code.
While I was at it, I noticed that two other function prototypes in the same
header file are also neither implemented nor invoked anywhere, so I removed them
as well.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
arch/arm/include/asm/arch-pxa/hardware.h | 11
On the pxa270, if the udc device is not disabled before jumping to linux, the
device fails to initialize in linux because it was left in a running state, and
the linux driver assumes that it is in a disabled state.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Arguably, this is a bug
]
Signed-off-by: Mike Dunn miked...@newsguy.com
---
include/linux/bitrev.h | 23 ++
lib/Makefile |1 +
lib/bitrev.c | 59
3 files changed, 83 insertions(+), 0 deletions(-)
create mode 100644 include/linux
3.4 commit 570469f3bde7f71cc1ece07a18d54a05b6a8775d]
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/mtd/nand/Makefile|2 +
drivers/mtd/nand/docg4.c | 1035 ++
drivers/mtd/nand/docg4_spl.c | 222 +
include/linux/mtd/docg4.h
-by: Mike Dunn miked...@newsguy.com
---
CREDITS |4 +
MAINTAINERS |3 +
board/palmtreo680/Makefile| 34 ++
board/palmtreo680/palmtreo680.c | 179 +++
board/palmtreo680/palmtreo680_spl.lds | 51 +++
boards.cfg
On 04/08/2013 05:59 PM, Scott Wood wrote:
On 04/08/2013 01:25:01 AM, Marek Vasut wrote:
Dear Mike Dunn,
This patch adds a driver for the diskonchip G4 nand flash device. It is
based on the driver from the linux kernel.
This also includes a separate SPL driver. A separate SPL driver
On 04/07/2013 10:28 PM, Marek Vasut wrote:
Dear Mike Dunn,
This patch adds a config option CONFIG_SYS_LCD_PXA_NO_L_BIAS, which causes
the lcd controller initialization code to leave as an ordinary gpio the
line that is typically configured as the lcd L_BIAS alternate function
On 04/07/2013 11:23 PM, Marek Vasut wrote:
Dear Mike Dunn,
This patch adds the bitrev library from the linux kernel. This is a simple
algorithm that uses an 8 bit look-up table to reverse the bits in data
types of 8, 16, or 32 bit widths. The docg4 nand flash driver uses it.
Signed-off
On 04/07/2013 11:25 PM, Marek Vasut wrote:
[..]
Try #ifdef U_BOOT instead of #if 0, no?
Marek, can you clarify? Do you mean something like...
#define U_BOOT
...
#ifndef U_BOOT /* Currently u-boot does not have for_each_set_bit */
unsigned long bits = ~buf[i];
On 04/07/2013 12:08 PM, Fabio Estevam wrote:
On Sun, Apr 7, 2013 at 1:40 PM, Mike Dunn miked...@newsguy.com wrote:
+void lcd_enable(void)
+ __attribute__((weak, alias(__lcd_enable)));
What about declaring it as:
__weak void lcd_enable(void)
Yes, that works. And very
.
Thanks for looking.
Mike
Mike Dunn (8):
pxa_lcd: add the ACX544AKN lcd device
pxa_lcd: make lcd_enable() a weak pointer
pxa_lcd: allow L_BIAS line to be unused
pxa27x_udc: remove call to unimplemented set_GPIO_mode()
arm: bootm: call udc_disable() before booting linux
lib: import
Make lcd_init() a weak pointer aliased to the current (and currently empty)
lcd_init(), so that boards can overload it if necessary. The palmtreo680 board
needs to wiggle some gpios and configure the pwm controller in order to get the
lcd and its backlight working.
Signed-off-by: Mike Dunn miked
On the pxa270 (at least), if the udc device is not disabled before jumping to
linux, the device fails to initialize in linux because it was left in a running
state, and the linux driver assumes that it is in a disabled state.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
Arguably
This adds the definitions required to support the LCD device on the Palm Treo
680.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
drivers/video/pxa_lcd.c | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/drivers/video/pxa_lcd.c b/drivers
device on the palmtreo680
board does not use the L_BIAS line. PalmOS does not configure the gpio 77 line
for the L_BIAS alternate function, and if it is configured as such, the lcd does
not work.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
This is a little ugly, I know, but I didn't want
. It is invoked no
where else in the code.
While I was at it, I noticed that two other function prototypes in the same
header file are also neither implemented nor invoked anywhere, so I removed them
as well.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
arch/arm/include/asm/arch-pxa/hardware.h | 11
This patch adds the bitrev library from the linux kernel. This is a simple
algorithm that uses an 8 bit look-up table to reverse the bits in data types of
8, 16, or 32 bit widths. The docg4 nand flash driver uses it.
Signed-off-by: Mike Dunn miked...@newsguy.com
---
include/linux/bitrev.h
-by: Mike Dunn miked...@newsguy.com
---
CREDITS |4 +
MAINTAINERS |3 +
board/palmtreo680/Makefile| 47 +++
board/palmtreo680/flash_u-boot.c | 170 ++
board/palmtreo680/palmtreo680.c | 184 +++
board
ecc decoding algorithm (due to size constraints). Although the u-boot
SPL *could* use ecc, it operates like an IPL for the sake of simplicity and
uniformity, since the IPL and SPL share the task of loading the u-boot image.
As a side benefit, the SPL driver is very small.
Signed-off-by: Mike Dunn
67 matches
Mail list logo
