Re: [PATCH v6 09/18] video: tegra20: dc: fix printing of framebuffer address

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > Framebuffer address should not be a pointer. > > Signed-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dc.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v6 12/18] video: tegra20: dc: parameterize V- and H-sync polarities

2024-04-19 Thread Thierry Reding
UT_POLARITY1 0x307 */ > +#define LHS_OUTPUT_POLARITY_LOW BIT(30) > +#define LVS_OUTPUT_POLARITY_LOW BIT(28) > +#define LSC0_OUTPUT_POLARITY_LOW BIT(24) This definition seems to be unused, other than that: Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 04/18] video: tegra20: dc: pass DC id to internal devices

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 6:44 PM CEST, Svyatoslav Ryhel wrote: > пт, 19 квіт. 2024 р. о 19:38 Thierry Reding пише: > > > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > > Tegra SoC has 2 independent display controllers called DC_A and > > > D

Re: [PATCH v6 07/18] video: tegra20: dc: add powergate

2024-04-19 Thread Thierry Reding
correct: Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 11/18] video: tegra20: dc: clean framebuffer memory block

2024-04-19 Thread Thierry Reding
+++ > 1 file changed, 5 insertions(+) Makes sense: Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 15/18] video: tegra20: dsi: add reset support

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Implement reset use to discard any changes which could have been > applied to DSI before and can interfere with current configuration. > > Tested-by: Ion Agorria # HTC One X > Tested-by: Svyatoslav Ryhel # Nvidia Tegratab T114 >

Re: [PATCH v6 05/18] video: tegra20: dc: add PLLD2 parent support

2024-04-19 Thread Thierry Reding
as Westman Dorcsak # ASUS Grouper E1565 > Tested-by: Ion Agorria # HTC One X > Tested-by: Svyatoslav Ryhel # Nvidia Tegratab T114 > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dc.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Thierry Redi

Re: [PATCH v6 08/18] video: tegra20: dc: configure behavior if PLLD/D2 is used

2024-04-19 Thread Thierry Reding
| 1 + > drivers/video/tegra20/tegra-dsi.c | 14 + > 3 files changed, 36 insertions(+), 13 deletions(-) I'm not very familiar with these clocks, but seeing that this was extensively tested, I guess this is okay, so: Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 06/18] video: tegra20: dc: add reset support

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 6:37 PM CEST, Svyatoslav Ryhel wrote: > пт, 19 квіт. 2024 р. о 19:05 Thierry Reding пише: > > > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > > Implement reset use to discard any changes which could have been > > > appli

Re: [PATCH v6 16/18] video: tegra20: dsi: remove pre-configuration

2024-04-19 Thread Thierry Reding
d-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dsi.c | 2 -- > 1 file changed, 2 deletions(-) Yeah, this seems completely unnecessary. Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 04/18] video: tegra20: dc: pass DC id to internal devices

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Tegra SoC has 2 independent display controllers called DC_A and > DC_B, they are handled differently by internal video devices like > DSI and HDMI controllers so it is important for last to know > which display controller is used to

Re: [PATCH v6 10/18] video: tegra20: dc: enable backlight after DC is configured

2024-04-19 Thread Thierry Reding
> drivers/video/tegra20/tegra-dc.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 01/18] video: tegra20: dc: diverge DC per-SOC

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 6:26 PM CEST, Thierry Reding wrote: > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > [...] > > diff --git a/arch/arm/include/asm/arch-tegra114/display.h > > b/arch/arm/include/asm/arch-tegra114/display.h > > new file mode 100

Re: [PATCH v6 02/18] video: tegra20: dc: fix image shift on rotated panels

2024-04-19 Thread Thierry Reding
> 1 file changed, 2 insertions(+), 2 deletions(-) Yeah, looks like we have that same fixup in Linux: Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 17/18] video: tegra20: dsi: set correct fifo depth

2024-04-19 Thread Thierry Reding
h of the video FIFO is 1920 *words* no *bytes* > > Tested-by: Ion Agorria # HTC One X > Tested-by: Svyatoslav Ryhel # Nvidia Tegratab T114 > Signed-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dsi.c | 2 +- > 1 file changed,

Re: [PATCH v6 14/18] video: tegra20: dsi: add T114 support

2024-04-19 Thread Thierry Reding
ons(-) > rename arch/arm/include/asm/arch-tegra30/dsi.h => > drivers/video/tegra20/tegra-dsi.h (90%) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 01/18] video: tegra20: dc: diverge DC per-SOC

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: [...] > diff --git a/arch/arm/include/asm/arch-tegra114/display.h > b/arch/arm/include/asm/arch-tegra114/display.h > new file mode 100644 > index 00..9411525799 > --- /dev/null > +++ b/arch/arm/include/asm/arch-tegra114/display.h

Re: [PATCH v6 13/18] video: tegra20: add MIPI calibration driver

2024-04-19 Thread Thierry Reding
have in the Linux kernel. It's slightly suboptimal because most of the register values are hard- coded for Tegra114, but I guess that can always be improved later on. Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 06/18] video: tegra20: dc: add reset support

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Implement reset use to discard any changes which could have been > applied to DC before and can interfere with current configuration. > > Tested-by: Agneli # Toshiba AC100 T20 > Tested-by: Robert Eckelmann # ASUS TF101 > Tested-by:

Re: [PATCH v6 18/18] video: tegra20: dsi: use set_backlight for backlight only

2024-04-19 Thread Thierry Reding
. That said, I'm not familiar with panel_set_backlight(), so perhaps it always only sets the brightness and the power may already be on earlier? Ah... nevermind... I see that panel_enable_backlight() is called prior to panel_set_backlight(), so this looks like it should be fine. Reviewed-by: Thierry Reding

Re: [PATCH v6 03/18] video: tegra20: consolidate DC header

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Consolidate HD headers and place the result into video/tegra20 Was this supposed to be "DC" headers like in the subject? Other than that this makes sense, so: Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v1 0/8] Convert Tegra pinctrl to DM

2023-12-13 Thread Thierry Reding
On Wed, Dec 13, 2023 at 11:46:58AM +0200, Svyatoslav Ryhel wrote: > > > 9 грудня 2023 р. 16:14:06 GMT+02:00, Tom Rini > написав(-ла): > >On Mon, Dec 04, 2023 at 04:45:38PM +0200, Svyatoslav Ryhel wrote: > >> пн, 4 груд. 2023 р. о 12:26 Thierry Reding пише: > &g

Re: [PATCH v1 0/5] Convert recently merged T30 boards to use DM PMIC

2023-12-13 Thread Thierry Reding
On Wed, Dec 13, 2023 at 11:42:45AM +0200, Svyatoslav Ryhel wrote: > > > 15 листопада 2023 р. 21:11:49 GMT+02:00, Tom Rini > написав(-ла): > >On Wed, Nov 15, 2023 at 04:51:08PM +0100, Thierry Reding wrote: > >> On Mon, Nov 06, 2023 at 04:04:07PM -0500, Tom Rini w

Re: [PATCH v1 0/5] Convert recently merged T30 boards to use DM PMIC

2023-12-11 Thread Thierry Reding
On Wed, Nov 15, 2023 at 02:11:49PM -0500, Tom Rini wrote: > On Wed, Nov 15, 2023 at 04:51:08PM +0100, Thierry Reding wrote: > > On Mon, Nov 06, 2023 at 04:04:07PM -0500, Tom Rini wrote: > > > On Mon, Nov 06, 2023 at 02:11:16PM +, Peter Robinson wrote: > > > >

Re: [PATCH v1 0/8] Convert Tegra pinctrl to DM

2023-12-04 Thread Thierry Reding
On Mon, Dec 04, 2023 at 10:20:46AM +0200, Svyatoslav Ryhel wrote: > Create a DM supported wrapper arround existing Tegra pinmux logic. > This implementation is backwards compatible with all existing board > setups and early stages of setup. All new boards must be device tree > based. Linux dts

Re: [PATCH v1 0/5] Convert recently merged T30 boards to use DM PMIC

2023-11-15 Thread Thierry Reding
On Mon, Nov 06, 2023 at 04:04:07PM -0500, Tom Rini wrote: > On Mon, Nov 06, 2023 at 02:11:16PM +, Peter Robinson wrote: > > On Mon, Nov 6, 2023 at 1:28 PM Svyatoslav Ryhel wrote: > > > > > > пн, 6 лист. 2023 р. о 15:13 Peter Robinson пише: > > > > > > > > On Mon, Nov 6, 2023 at 11:58 AM

Re: [PATCH v1 0/5] Convert recently merged T30 boards to use DM PMIC

2023-11-15 Thread Thierry Reding
On Mon, Nov 13, 2023 at 04:52:22PM +, Peter Robinson wrote: > > > > > > > > Since the proposed PMIC patches have been accepted, I see the > > > > > > > > need > > > > > > > > to convert boards which I maintain to use DM drivers instead of > > > > > > > > board hacks. > > > > > > > > > > > >

Re: [PATCH v2 0/2] tegra_mmc: get tap and trim from dts

2023-10-13 Thread Thierry Reding
From: Thierry Reding On Thu, 24 Aug 2023 21:53:30 +0300, Svyatoslav Ryhel wrote: > Default-tap and default-trim values are used for eMMC setup > mostly on T114+ devices. As for now, those values are hardcoded > for T210 and ignored for all other Tegra generations. Fix this > by

Re: [PATCH v2 00/16] General tegra and board improvements

2023-10-13 Thread Thierry Reding
From: Thierry Reding On Thu, 24 Aug 2023 22:25:47 +0300, Svyatoslav Ryhel wrote: > This patchset follows Transformers, Grouper, LG X3 and Endeavoru > bringup and contains changes from v9 of previous patchset and > some new improvenets. > > List of changes: > - separated

Re: [PATCH v1 17/19] ARM: tegra: dt-setup: convert TrustZone remove into config

2023-08-24 Thread Thierry Reding
On Wed, Aug 23, 2023 at 02:47:11PM +0300, Svyatoslav Ryhel wrote: > > > 23 серпня 2023 р. 14:17:37 GMT+03:00, Thierry Reding > написав(-ла): > >On Tue, Aug 22, 2023 at 02:22:15PM +0300, Svyatoslav Ryhel wrote: > >> Remove of TrustZone nodes is required by many

Re: [PATCH v1 1/1] mmc: tegra: get default-tap and default-trim from device tree

2023-08-24 Thread Thierry Reding
On Wed, Aug 23, 2023 at 03:02:42PM +0300, Svyatoslav Ryhel wrote: > > > 23 серпня 2023 р. 14:03:25 GMT+03:00, Thierry Reding > написав(-ла): > >On Sat, Aug 19, 2023 at 06:35:01PM +0300, Svyatoslav Ryhel wrote: > >> Default-tap and default-trim values are used for eMM

Re: [PATCH v1 1/1] mmc: tegra: get default-tap and default-trim from device tree

2023-08-24 Thread Thierry Reding
On Wed, Aug 23, 2023 at 02:38:48PM +0300, Svyatoslav Ryhel wrote: > > > 23 серпня 2023 р. 14:03:25 GMT+03:00, Thierry Reding > написав(-ла): > >On Sat, Aug 19, 2023 at 06:35:01PM +0300, Svyatoslav Ryhel wrote: > >> Default-tap and default-trim values are used for eMM

Re: [PATCH v1 0/1] tegra_mmc: get tap and trim from dts

2023-08-24 Thread Thierry Reding
On Wed, Aug 23, 2023 at 02:30:48PM +0300, Svyatoslav Ryhel wrote: > > > 23 серпня 2023 р. 13:53:26 GMT+03:00, Thierry Reding > написав(-ла): > >On Sat, Aug 19, 2023 at 06:35:00PM +0300, Svyatoslav Ryhel wrote: > >> Default-tap and default-trim values are used for eMM

Re: [PATCH v1 17/19] ARM: tegra: dt-setup: convert TrustZone remove into config

2023-08-23 Thread Thierry Reding
On Tue, Aug 22, 2023 at 02:22:15PM +0300, Svyatoslav Ryhel wrote: > Remove of TrustZone nodes is required by many product devices > which require repetable calls of same function from device board. > To simplify this, TZ remove is converted into Kconfig option. > > Signed-off-by: Svyatoslav Ryhel

Re: [PATCH v1 15/19] ARM: tegra: board2: add generic late init

2023-08-23 Thread Thierry Reding
On Tue, Aug 22, 2023 at 02:22:13PM +0300, Svyatoslav Ryhel wrote: > Board specific late init allows vendors to set up different device > or board specific env variables (like serial number, platform name). > In case this information is missing, u-boot will lack info regards > serial or platform. >

Re: [PATCH v1 1/1] mmc: tegra: get default-tap and default-trim from device tree

2023-08-23 Thread Thierry Reding
On Sat, Aug 19, 2023 at 06:35:01PM +0300, Svyatoslav Ryhel wrote: > Default-tap and default-trim values are used for eMMC setup > mostly on T114+ devices. As for now, those values are hardcoded > for T210 and ignored for all other Tegra generations. Fix this > by passing tap and trim values from

Re: [PATCH v1 0/1] tegra_mmc: get tap and trim from dts

2023-08-23 Thread Thierry Reding
On Sat, Aug 19, 2023 at 06:35:00PM +0300, Svyatoslav Ryhel wrote: > Default-tap and default-trim values are used for eMMC setup > mostly on T114+ devices. As for now, those values are hardcoded > for T210 and ignored for all other Tegra generations. Fix this > by passing tap and trim values from

Re: [PATCH v1 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-23 Thread Thierry Reding
On Sun, Aug 20, 2023 at 09:10:17PM +0200, Marek Vasut wrote: > On 8/20/23 20:32, Svyatoslav Ryhel wrote: > > 20 серпня 2023 р. 21:14:15 GMT+03:00, Marek Vasut > > написав(-ла): > > > On 8/20/23 09:13, Svyatoslav Ryhel wrote: > > > > 20 серпня 2023 р. 05:23:14 GMT+03:00, Marek Vasut > > > >

Re: [GIT PULL] ARM: tegra: Changes for v2023.10-rc1

2023-08-22 Thread Thierry Reding
:49:43 GMT+03:00, Tom Rini > >> написав(-ла): > >> >On Fri, Aug 18, 2023 at 03:39:22PM +0200, Thierry Reding wrote: > >> > > >> >> From: Thierry Reding > >> >> > >> >> Hi Tom, > >> >> > >> >>

Re: [GIT PULL] ARM: tegra: Changes for v2023.10-rc1

2023-08-21 Thread Thierry Reding
On Fri, Aug 18, 2023 at 08:02:30PM +0300, Svyatoslav Ryhel wrote: > > > 18 серпня 2023 р. 19:49:43 GMT+03:00, Tom Rini > написав(-ла): > >On Fri, Aug 18, 2023 at 03:39:22PM +0200, Thierry Reding wrote: > > > >> From: Thierry Reding > >> > >

Re: [GIT PULL] ARM: tegra: Changes for v2023.10-rc1

2023-08-21 Thread Thierry Reding
On Fri, Aug 18, 2023 at 12:49:43PM -0400, Tom Rini wrote: > On Fri, Aug 18, 2023 at 03:39:22PM +0200, Thierry Reding wrote: > > > From: Thierry Reding > > > > Hi Tom, > > > > The following changes since commit 68c07fc5fdf34f0926cf06fc0c4ebd6f2f3afe19: >

[GIT PULL] ARM: tegra: Changes for v2023.10-rc1

2023-08-18 Thread Thierry Reding
From: Thierry Reding Hi Tom, The following changes since commit 68c07fc5fdf34f0926cf06fc0c4ebd6f2f3afe19: Merge https://source.denx.de/u-boot/custodians/u-boot-usb (2023-06-21 14:42:50 -0400) are available in the Git repository at: g...@source.denx.de:u-boot/custodians/u-boot-tegra.git

Re: [PATCH v8 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support

2023-08-14 Thread Thierry Reding
On Mon, Aug 07, 2023 at 09:49:07AM -0400, Tom Rini wrote: > On Mon, Jul 31, 2023 at 11:29:19AM -0400, Tom Rini wrote: > > On Mon, Jul 31, 2023 at 03:19:08PM +0300, Svyatoslav Ryhel wrote: > > > Hello! > > > > > > It has been a month since the last patchset was sent. Should I re-send > > > them?

Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-23 Thread Thierry Reding
On Fri, Jun 23, 2023 at 05:19:09PM +0300, Svyatoslav Ryhel wrote: > > > 23 червня 2023 р. 17:11:35 GMT+03:00, Thierry Reding > написав(-ла): > >On Fri, Jun 23, 2023 at 02:51:54PM +0300, Svyatoslav Ryhel wrote: > >> > >> > >> 23 червня 2023 р. 14:3

Re: [PATCH v7 3/7] ARM: tegra: add SoC UID calculation function

2023-06-23 Thread Thierry Reding
On Fri, Jun 23, 2023 at 02:46:54PM +0300, Svyatoslav Ryhel wrote: > > > 23 червня 2023 р. 14:24:37 GMT+03:00, Thierry Reding > написав(-ла): > >On Fri, Jun 23, 2023 at 08:55:56AM +0300, Svyatoslav Ryhel wrote: > >> This is a small tool for calculation of SoC UID b

Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-23 Thread Thierry Reding
On Fri, Jun 23, 2023 at 02:51:54PM +0300, Svyatoslav Ryhel wrote: > > > 23 червня 2023 р. 14:32:30 GMT+03:00, Thierry Reding > написав(-ла): > >On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: > >[...] > >> diff --git a/board/asus/transforme

Re: [PATCH v7 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-23 Thread Thierry Reding
On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: [...] > diff --git a/board/asus/transformer-t30/pinmux-config-transformer.h > b/board/asus/transformer-t30/pinmux-config-transformer.h > new file mode 100644 > index 00..96ff45d375 > --- /dev/null > +++

Re: [PATCH v7 3/7] ARM: tegra: add SoC UID calculation function

2023-06-23 Thread Thierry Reding
On Fri, Jun 23, 2023 at 08:55:56AM +0300, Svyatoslav Ryhel wrote: > This is a small tool for calculation of SoC UID based on the same > Linux function. It can be further used for generation of device > unique data like mac address or exposing it as serial number. It's a very bad idea to use the

Re: [PATCH v3 00/16] General Tegra improvements

2023-02-14 Thread Thierry Reding
4 board/nvidia/beaver/beaver-spl.c > create mode 100644 board/nvidia/cardhu/cardhu-spl.c > delete mode 100644 board/nvidia/venice2/as3722_init.h > delete mode 100644 board/toradex/apalis-tk1/as3722_init.h > create mode 100644 board/toradex/apalis_t30/apalis_t30-spl.c > create mode 100644 board/toradex/colibri_t30/colibri_t30-spl.c > create mode 100644 doc/usage/cmd/ebtupdate.rst I haven't tested this exhaustively, just merely made sure that it can PXE boot into Linux. Seems to work fine on Beaver and Jetson TK1, so: Tested-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v8 0/3] Timer support for ARM Tegra

2023-02-02 Thread Thierry Reding
+++-- > include/configs/tegra-common.h | 6 -- > 15 files changed, 275 insertions(+), 79 deletions(-) > create mode 100644 drivers/timer/tegra-timer.c This works fine on Beaver (Tegra30), Jetson TK1 (Tegra124), Jetson TX1 (Tegra210) and Jetson TX2 (Tegra186), so: Tested-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v7 0/3] Timer support for ARM Tegra

2023-01-31 Thread Thierry Reding
On Fri, Jan 27, 2023 at 10:27:57PM +0200, Svyatoslav R. wrote: > On 1/27/23 19:15, Thierry Reding wrote: > > On Fri, Jan 27, 2023 at 09:13:09AM +0200, Svyatoslav Ryhel wrote: > > > - ARM: tegra: remap clock_osc_freq for all Tegra family > > > Enum clock_osc_freq was de

[PATCH 2/2] ARM: tegra: Enable poweroff command on Jetson TX2

2023-01-31 Thread Thierry Reding
From: Thierry Reding This command is useful to power off the system from within U-Boot. Signed-off-by: Thierry Reding --- configs/p2771--000_defconfig | 1 + configs/p2771--500_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/p2771--000_defconfig b/configs

[PATCH 1/2] ARM: tegra: Enable poweroff command on Jetson TX1 and Jetson Nano

2023-01-31 Thread Thierry Reding
From: Thierry Reding This command is useful to power off the system from within U-Boot. Signed-off-by: Thierry Reding --- configs/p2371-2180_defconfig | 1 + configs/p3450-_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/p2371-2180_defconfig b/configs/p2371

Re: [PATCH v7 0/3] Timer support for ARM Tegra

2023-01-27 Thread Thierry Reding
On Fri, Jan 27, 2023 at 09:13:09AM +0200, Svyatoslav Ryhel wrote: > - ARM: tegra: remap clock_osc_freq for all Tegra family > Enum clock_osc_freq was designed to use only with T20. > This patch remaps it to use additional frequencies, added in > T30+ SoC while maintaining backwards compatibility

Re: [PATCH v6 0/3] Timer support for ARM Tegra

2023-01-26 Thread Thierry Reding
On Thu, Jan 26, 2023 at 07:12:34PM +0200, Svyatoslav Ryhel wrote: > I may implement changes of Thierry Reding in a proper form as a > separate patch or include in existing (depends on his choice). I think it's ultimately better if this is properly integrated into the series because the

Re: [PATCH v6 0/3] Timer support for ARM Tegra

2023-01-26 Thread Thierry Reding
On Thu, Jan 26, 2023 at 07:08:54PM +0200, Svyatoslav Ryhel wrote: > чт, 26 січ. 2023 р. о 12:35 Thierry Reding пише: > > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: >

Re: [PATCH v6 0/3] Timer support for ARM Tegra

2023-01-26 Thread Thierry Reding
On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > - ARM: tegra: remap clock_osc_freq for all Tegra family > &g

Re: [PATCH v6 0/3] Timer support for ARM Tegra

2023-01-26 Thread Thierry Reding
On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > - ARM: tegra: remap clock_osc_freq for all Tegra family > > Enum clock_osc_freq was designed to use only with T20. > > This patch remaps

Re: [PATCH v6 0/3] Timer support for ARM Tegra

2023-01-25 Thread Thierry Reding
On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > - ARM: tegra: remap clock_osc_freq for all Tegra family > Enum clock_osc_freq was designed to use only with T20. > This patch remaps it to use additional frequencies, added in > T30+ SoC while maintaining backwards compatibility

[PATCH 8/9] ARM: tegra: Refactor DT update helpers

2021-09-03 Thread Thierry Reding
From: Thierry Reding Rather than duplicate the Ethernet MAC address and carveout updating code for each board, move it to a common location and make it more reusable. Signed-off-by: Thierry Reding --- arch/arm/include/asm/arch-tegra/board.h | 10 ++ arch/arm/mach-tegra/dt-setup.c

[PATCH 5/9] fdtdec: Support reserved-memory flags

2021-09-03 Thread Thierry Reding
From: Thierry Reding Reserved memory nodes can have additional flags. Support reading and writing these flags to ensure that reserved memory nodes can be properly parsed and emitted. This converts support for the existing "no-map" flag to avoid extending the arg

[PATCH 6/9] ARM: tegra: Support multiple reserved memory regions

2021-09-03 Thread Thierry Reding
From: Thierry Reding Support multiple reserved memory regions per device to support platforms that use both a framebuffer and color conversion lookup table for early boot display splash. While at it, also pass along the name, compatible strings and flags of the carveouts. Signed-off

[PATCH 9/9] ARM: tegra: Copy memory-region-names property

2021-09-03 Thread Thierry Reding
From: Thierry Reding If multiple entries are present in the memory-region property, this new memory-region-names property can be used to specify names for each of them so that they can be more easily distinguished. Signed-off-by: Thierry Reding --- arch/arm/mach-tegra/dt-setup.c | 31

[PATCH 7/9] ARM: tegra: Support EMC frequency tables on Tegra210

2021-09-03 Thread Thierry Reding
From: Thierry Reding The EMC frequency tables are created from a training sequence performed during early boot and passed in via a reserved memory region by nvtboot. Copy this table to the kernel DTB so that the kernel can use it to scale the EMC frequency at runtime. Note that early

[PATCH 3/9] fdtdec: Support compatible string list for reserved memory

2021-09-03 Thread Thierry Reding
From: Thierry Reding Reserved memory nodes can have a compatible string list to identify the type of reserved memory that they represent. Support specifying an optional compatible string list when creating these nodes. Signed-off-by: Thierry Reding --- arch/arm/cpu/armv8/fsl-layerscape/soc.c

[PATCH 4/9] fdtdec: Reorder fdtdec_set_carveout() parameters for consistency

2021-09-03 Thread Thierry Reding
From: Thierry Reding The fdtdec_set_carveout() function's parameters are inconsistent with the parameters passed to fdtdec_add_reserved_memory(). Fix up the order to make it more consistent. Signed-off-by: Thierry Reding --- board/nvidia/p2371-2180/p2371-2180.c | 4 ++-- board/nvidia/p2771

[PATCH 2/9] fdtdec: Support retrieving the name of a carveout

2021-09-03 Thread Thierry Reding
From: Thierry Reding When retrieving a given carveout for a device, allow callers to query the name. This helps differentiating between carveouts when there are more than one. This is also useful when copying carveouts to help assign a meaningful name that cannot always be guessed. Signed-off

[PATCH 1/9] fdtdec: Allow using fdtdec_get_carveout() in loops

2021-09-03 Thread Thierry Reding
From: Thierry Reding In order make it possible to use fdtdec_get_carveout() in loops, return FDT_ERR_NOTFOUND when the passed-in index exceeds the number of phandles present in the given property. Signed-off-by: Thierry Reding --- lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/9] ARM: tegra: Support EMC frequency tables on Tegra210

2021-09-03 Thread Thierry Reding
From: Thierry Reding Hi, The first handful of patches are preparatory work to make the fdtdec carveout helpers a bit more flexible and clean them up a little bit while the final 4 patches make use of the improved helpers to copy the EMC frequency tables that can be passed to U-Boot from earlier

Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT

2020-04-01 Thread Thierry Reding
On Wed, Apr 01, 2020 at 10:35:23PM +0200, Tom Warren wrote: > -Original Message- > From: Thierry Reding > Sent: Wednesday, April 1, 2020 8:20 AM > To: Tom Warren > Cc: Peter Robinson ; tomcwarren3...@gmail.com; > u-boot@lists.denx.de; Stephen Warren ; Jonathan Hunter

Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT

2020-04-01 Thread Thierry Reding
On Wed, Apr 01, 2020 at 02:03:09AM +0200, Tom Warren wrote: > -Original Message- > From: Peter Robinson > Sent: Tuesday, March 31, 2020 3:54 AM > To: tomcwarren3...@gmail.com > Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding > ; Jonathan Hunter ; Tom Warren

Re: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot

2020-03-19 Thread Thierry Reding
On Tue, Mar 17, 2020 at 01:07:15PM -0700, twar...@nvidia.com wrote: > From: Tom Warren > > This is a WAR for DHCP failure after rebooting from the L4T kernel. The > r8169.c kernel driver is setting bit 19 of the rt816x HW register 0xF0, > which goes by FuncEvent and MISC in various driver

[U-Boot] [PATCH] net: rtl8169: Support RTL-8168c/8111c

2019-09-11 Thread Thierry Reding
From: Thierry Reding This version of the RTL-8168 chip can be found on some add-in cards sold by CSL-Computer GmbH & Co. KG. The chip isn't special in any way, but it needs to have the ChipCmd register programmed after the DMA descriptors have been set up, so make sure that happens by ad

Re: [U-Boot] rtl8169: use dm_pci_map_bar

2019-06-14 Thread Thierry Reding
On Fri, Jun 14, 2019 at 01:16:32AM +0200, Patrick Wildt wrote: > On Thu, Jun 13, 2019 at 06:43:25PM +0200, Thierry Reding wrote: > > On Thu, Jun 13, 2019 at 03:16:10PM +0800, Bin Meng wrote: > > > Hi Stefan, > > > > > > On Thu, Jun 13, 2019 at 1:40 PM Stefan

Re: [U-Boot] rtl8169: use dm_pci_map_bar

2019-06-13 Thread Thierry Reding
On Thu, Jun 13, 2019 at 03:16:10PM +0800, Bin Meng wrote: > Hi Stefan, > > On Thu, Jun 13, 2019 at 1:40 PM Stefan Roese wrote: > > > > Added Bin, Joe and Thierry to Cc > > > > On 11.06.19 13:15, Patrick Wildt wrote: > > > Hi, > > > > > > I have an rtl8169 on a macchiatobin and that card has a

Re: [U-Boot] [PATCH v4 2/2] net: eth-uclass: Support device tree MAC addresses

2019-05-28 Thread Thierry Reding
On Mon, May 20, 2019 at 05:59:57PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Add the standard Ethernet device tree bindings (imported from v5.0 of > the Linux kernel) and implement support for reading the MAC address for > Ethernet devices in the Ethernet ucla

Re: [U-Boot] [PATCH 1/2] fdtdec: test: Fix memory leak

2019-05-21 Thread Thierry Reding
On Mon, May 20, 2019 at 02:51:08PM -0600, Simon Glass wrote: > Hi Thierry, > > On Mon, 20 May 2019 at 10:05, Thierry Reding wrote: > > > > From: Thierry Reding > > > > Free the memory allocated to store the test FDT upon test completion to > > avoid leaki

[U-Boot] [PATCH 2/2] fdtdec: Remove fdt_{addr,size}_unpack()

2019-05-20 Thread Thierry Reding
From: Thierry Reding U-Boot already defines the {upper,lower}_32_bits() macros that have the same purpose. Use the existing macros instead of defining new APIs. Signed-off-by: Thierry Reding --- include/fdtdec.h | 24 lib/fdtdec.c | 8 ++-- lib

[U-Boot] [PATCH 1/2] fdtdec: test: Fix memory leak

2019-05-20 Thread Thierry Reding
From: Thierry Reding Free the memory allocated to store the test FDT upon test completion to avoid leaking the memory. We don't bother cleaning up on test failure since the code is broken in that case and should be fixed, in which case the leak would also go away. Reported-by: Tom Rini

[U-Boot] [PATCH v4 2/2] net: eth-uclass: Support device tree MAC addresses

2019-05-20 Thread Thierry Reding
From: Thierry Reding Add the standard Ethernet device tree bindings (imported from v5.0 of the Linux kernel) and implement support for reading the MAC address for Ethernet devices in the Ethernet uclass. If the "mac-address" property exists, the MAC address will be p

[U-Boot] [PATCH v4 1/2] net: eth-uclass: Write MAC address to hardware after probe

2019-05-20 Thread Thierry Reding
From: Thierry Reding In order for the device to use the proper MAC address, which can have been configured in the environment prior to the device being registered, ensure that the MAC address is written after the device has been probed. For devices that are registered before the network stack

Re: [U-Boot] [PATCH v2 45/50] Revert "pci: Scale MAX_PCI_REGIONS based on CONFIG_NR_DRAM_BANKS"

2019-05-09 Thread Thierry Reding
On Tue, May 07, 2019 at 09:04:16PM -0600, Simon Glass wrote: > Hi Bin, > > On Tue, 7 May 2019 at 03:28, Bin Meng wrote: > > > > Hi Simon, Thierry, > > > > On Fri, May 3, 2019 at 12:22 AM Simon Glass wrote: > > > > > > Hi Thierry, > > &

Re: [U-Boot] [PATCH 2/2] fdtdec: Remove fdt_{addr,size}_unpack()

2019-05-07 Thread Thierry Reding
On Mon, May 06, 2019 at 09:52:02PM -0600, Simon Glass wrote: > Hi Thierry, > > On Fri, 26 Apr 2019 at 06:01, Thierry Reding wrote: > > > > On Mon, Apr 15, 2019 at 10:08:21AM +0200, Thierry Reding wrote: > > > From: Thierry Reding > > > > > >

Re: [U-Boot] [PATCH 1/2] fdtdec: Use fdt_setprop_u32() for fdtdec_set_phandle()

2019-05-07 Thread Thierry Reding
On Mon, May 06, 2019 at 09:52:00PM -0600, Simon Glass wrote: > Hi Thierry, > > On Thu, 25 Apr 2019 at 07:25, Thierry Reding wrote: > > > > On Mon, Apr 15, 2019 at 10:08:20AM +0200, Thierry Reding wrote: > > > From: Thierry Reding > > > > > >

Re: [U-Boot] [PATCH v2 45/50] Revert "pci: Scale MAX_PCI_REGIONS based on CONFIG_NR_DRAM_BANKS"

2019-05-02 Thread Thierry Reding
On Thu, May 02, 2019 at 12:09:49AM +0800, Bin Meng wrote: > +Thierry > > On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > > > This reverts commit aec4298ccb337106fd0115b91d846a022fdf301d. > > > > Unfortunately this has a dramatic impact on the pre-relocation memory > > used on x86

Re: [U-Boot] [PATCH 2/2] fdtdec: Remove fdt_{addr,size}_unpack()

2019-04-26 Thread Thierry Reding
On Mon, Apr 15, 2019 at 10:08:21AM +0200, Thierry Reding wrote: > From: Thierry Reding > > U-Boot already defines the {upper,lower}_32_bits() macros that have the > same purpose. Use the existing macros instead of defining new APIs. > > Signed-off-by: Thierry Reding > --

[U-Boot] [PATCH v3 2/2] net: eth-uclass: Support device tree MAC addresses

2019-04-25 Thread Thierry Reding
From: Thierry Reding Add the standard Ethernet device tree bindings (imported from v5.0 of the Linux kernel) and implement support for reading the MAC address for Ethernet devices in the Ethernet uclass. If the "mac-address" property exists, the MAC address will be p

[U-Boot] [PATCH v3 1/2] net: eth-uclass: Write MAC address to hardware after probe

2019-04-25 Thread Thierry Reding
From: Thierry Reding In order for the device to use the proper MAC address, which can have been configured in the environment prior to the device being registered, ensure that the MAC address is written after the device has been probed. For devices that are registered before the network stack

Re: [U-Boot] [PATCH v2 2/2] net: eth-uclass: Support device tree MAC addresses

2019-04-25 Thread Thierry Reding
On Thu, Apr 18, 2019 at 07:30:05PM +0300, Grygorii Strashko wrote: > > > On 17.04.19 18:03, Thierry Reding wrote: > > On Wed, Apr 17, 2019 at 02:49:22PM +0300, Grygorii Strashko wrote: > >> > >> > >> On 16.04.19 19:24, Thierry Reding wrote: &

Re: [U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

2019-04-25 Thread Thierry Reding
On Tue, Apr 16, 2019 at 04:36:16PM +, Joe Hershberger wrote: > On Tue, Apr 16, 2019 at 11:21 AM Thierry Reding > wrote: > > > > From: Thierry Reding > > > > Implement this callback that allows the MAC address to be set for the > > Ethernet card. This

Re: [U-Boot] [PATCH 1/2] fdtdec: Use fdt_setprop_u32() for fdtdec_set_phandle()

2019-04-25 Thread Thierry Reding
On Mon, Apr 15, 2019 at 10:08:20AM +0200, Thierry Reding wrote: > From: Thierry Reding > > The fdt_setprop_u32() function does everything that we need, so we > really only use the function as a convenience wrapper, in which case it > can simply be a static inline function.

Re: [U-Boot] [PATCH v2 2/2] net: eth-uclass: Support device tree MAC addresses

2019-04-25 Thread Thierry Reding
On Wed, Apr 17, 2019 at 09:32:26PM -0700, Simon Glass wrote: > Hi Thierry, > > On Wed, 17 Apr 2019 at 08:03, Thierry Reding > wrote: > > > On Wed, Apr 17, 2019 at 02:49:22PM +0300, Grygorii Strashko wrote: > > > > > > > > > On 16.04.19 19:24, Th

Re: [U-Boot] [PATCH v2 2/2] net: eth-uclass: Support device tree MAC addresses

2019-04-17 Thread Thierry Reding
On Wed, Apr 17, 2019 at 02:49:22PM +0300, Grygorii Strashko wrote: > > > On 16.04.19 19:24, Thierry Reding wrote: > > From: Thierry Reding > > > > Add the standard Ethernet device tree bindings (imported from v5.0 of > > the Linux kernel) and implement su

Re: [U-Boot] [PATCH 1/2] pci: Add boundary check for hose->regions

2019-04-16 Thread Thierry Reding
On Fri, Mar 15, 2019 at 04:32:32PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Make sure that we don't overflow the hose->regions array, otherwise we > would end up overwriting the hose->region_count field and cause mayhem > to ensue. Also print an er

[U-Boot] [PATCH v2 2/2] net: eth-uclass: Support device tree MAC addresses

2019-04-16 Thread Thierry Reding
From: Thierry Reding Add the standard Ethernet device tree bindings (imported from v5.0 of the Linux kernel) and implement support for reading the MAC address for Ethernet devices in the Ethernet uclass. If the "mac-address" property exists, the MAC address will be p

[U-Boot] [PATCH v2 1/2] net: eth-uclass: Write MAC address to hardware after probe

2019-04-16 Thread Thierry Reding
From: Thierry Reding In order for the device to use the proper MAC address, which can have been configured in the environment prior to the device being registered, ensure that the MAC address is written after the device has been probed. For devices that are registered before the network stack

[U-Boot] [RESEND PATCH 2/2] net: rtl8169: Support RTL-8168h/8111h

2019-04-16 Thread Thierry Reding
From: Thierry Reding This version of the RTL-8168 is present on some development boards and is compatible with this driver. Add support for identifying this version of the chip so that U-Boot won't complain about it being unknown. Signed-off-by: Thierry Reding --- drivers/net/rtl8169.c | 1

[U-Boot] [RESEND PATCH 1/2] net: rtl8169: Implement ->hwaddr_write() callback

2019-04-16 Thread Thierry Reding
From: Thierry Reding Implement this callback that allows the MAC address to be set for the Ethernet card. This is necessary in order for the device to be able to receive packets for the MAC address that U-Boot advertises. Signed-off-by: Thierry Reding --- drivers/net/rtl8169.c | 18

Re: [U-Boot] [PATCH 2/3] net: eth-uclass: Write MAC address to hardware after probe

2019-04-16 Thread Thierry Reding
On Mon, Apr 15, 2019 at 09:24:00PM +, Joe Hershberger wrote: > On Mon, Apr 15, 2019 at 4:11 AM Thierry Reding > wrote: > > > > From: Thierry Reding > > > > In order for the device to use the proper MAC address, which can have > > been configured in the e

Re: [U-Boot] [PATCH 1/3] dm: core: Add dev_read_bytes()

2019-04-16 Thread Thierry Reding
On Mon, Apr 15, 2019 at 09:21:45PM +, Joe Hershberger wrote: > On Mon, Apr 15, 2019 at 4:11 AM Thierry Reding > wrote: > > > > From: Thierry Reding > > > > This function can be used to read a binary property into a buffer. One > > example where this is

  1   2   3   4   5   6   7   8   >