[U-Boot] [PATCH] Fix build issues cause by LDFLAGS_FINAL changes

2011-03-31 Thread Wolfgang Denk
Commit 6dc1ece Introduce a new linker flag LDFLAGS_FINAL modified a number of Makefiles in a way that broke out-of-tree builds. The problem was that $(nandobj) was used before it got defined. Fix this. Signed-off-by: Wolfgang Denk w...@denx.de --- nand_spl/board/amcc/acadia/Makefile

Re: [U-Boot] [PATCH] Fix build issues cause by LDFLAGS_FINAL changes

2011-03-31 Thread Haiying Wang
Dear Wolfgang, On Thu, 2011-03-31 at 16:52 +0200, Wolfgang Denk wrote: Commit 6dc1ece Introduce a new linker flag LDFLAGS_FINAL modified a number of Makefiles in a way that broke out-of-tree builds. The problem was that $(nandobj) was used before it got defined. What is out-of-tree builds? Why

Re: [U-Boot] [PATCH] Fix build issues cause by LDFLAGS_FINAL changes

2011-03-31 Thread Wolfgang Denk
Dear Haiying Wang, In message 1301583985.1991.4.camel@haiying-laptop you wrote: What is out-of-tree builds? Why did LDFLAGS_FINAL patch break it? the out-of-tree building means that you store all build results in some other directory, outside of the source tree. See item 3 under Notes at

Re: [U-Boot] [PATCH] Fix build issues cause by LDFLAGS_FINAL changes

2011-03-31 Thread Haiying Wang
On Thu, 2011-03-31 at 17:37 +0200, Wolfgang Denk wrote: $(nandobj) was defined in those Makefiles in that way before applying LDFLAGS_FINAL patch. Why could the out-of-tree builds passed before applying LDFLAG_FINAL patch? Have a look at the changes introduced by your commit, and you

Re: [U-Boot] [PATCH] Fix build issues cause by LDFLAGS_FINAL changes

2011-03-31 Thread Scott Wood
On Thu, 31 Mar 2011 16:52:31 +0200 Wolfgang Denk w...@denx.de wrote: Commit 6dc1ece Introduce a new linker flag LDFLAGS_FINAL modified a number of Makefiles in a way that broke out-of-tree builds. The problem was that $(nandobj) was used before it got defined. Fix this. Signed-off-by: