Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-23 Thread Haavard Skinnemoen
Wolfgang Denk [EMAIL PROTECTED] wrote: Dear Stelian Pop, In message [EMAIL PROTECTED] you wrote: +#ifndef CONFIG_LCD_LOGO_TEXT1 +# define CONFIG_LCD_LOGO_TEXT1 (C) 2008 ATMEL Corp +#endif Wouldn't it be better if we move this text into include/configs/at91xxx.h for all the

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 20:36 Thu 23 Oct , Haavard Skinnemoen wrote: Wolfgang Denk [EMAIL PROTECTED] wrote: Dear Stelian Pop, In message [EMAIL PROTECTED] you wrote: +#ifndef CONFIG_LCD_LOGO_TEXT1 +# define CONFIG_LCD_LOGO_TEXT1 (C) 2008 ATMEL Corp +#endif Wouldn't it be better if we

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-23 Thread Haavard Skinnemoen
On Thu, 23 Oct 2008 20:53:37 +0200 Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED] wrote: I wish someone would bother looking at http://lists.denx.de/pipermail/u-boot/2008-September/039837.html I like It Great! Just one think it will be nice if we can merge lcd_printf withas

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-23 Thread Wolfgang Denk
Dear Haavard Skinnemoen, In message [EMAIL PROTECTED] you wrote: Anatolij, Jean-Christophe - who of you will be taking care of this? I wish someone would bother looking at http://lists.denx.de/pipermail/u-boot/2008-September/039837.html at some point so that we can stop filling

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:19 Thu 23 Oct , Wolfgang Denk wrote: Dear Haavard Skinnemoen, In message [EMAIL PROTECTED] you wrote: Anatolij, Jean-Christophe - who of you will be taking care of this? I wish someone would bother looking at

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-22 Thread Anatolij Gustschin
Jean-Christophe PLAGNIOL-VILLARD wrote: On 21:40 Tue 21 Oct , Wolfgang Denk wrote: Dear Stelian Pop, In message [EMAIL PROTECTED] you wrote: +#ifndef CONFIG_LCD_LOGO_TEXT1 +# define CONFIG_LCD_LOGO_TEXT1 (C) 2008 ATMEL Corp +#endif Wouldn't it be better if we move this text into

[U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-21 Thread Ilko Iliev
This patch allows to print custom strings on the LCD after the logo. Signed-off-by: Ilko Iliev [EMAIL PROTECTED] index d104b26..a94a4da 100644 --- a/common/lcd.c +++ b/common/lcd.c @@ -827,11 +827,19 @@ static void *lcd_logo (void) sprintf (info, %s, U_BOOT_VERSION);

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-21 Thread Ilko Iliev
Hello Stelian, Stelian Pop wrote: Le mardi 21 octobre 2008 à 15:10 +0200, Ilko Iliev a écrit : This patch allows to print custom strings on the LCD after the logo. Hi Ilko, Signed-off-by: Ilko Iliev [EMAIL PROTECTED] index d104b26..a94a4da 100644 --- a/common/lcd.c +++

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-21 Thread Stelian Pop
Le mardi 21 octobre 2008 à 18:43 +0200, Ilko Iliev a écrit : +#ifndef CONFIG_LCD_LOGO_TEXT1 +# define CONFIG_LCD_LOGO_TEXT1 (C) 2008 ATMEL Corp +#endif Wouldn't it be better if we move this text into include/configs/at91xxx.h for all the boards ? Yes, it will be better.

Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-21 Thread Wolfgang Denk
Dear Stelian Pop, In message [EMAIL PROTECTED] you wrote: +#ifndef CONFIG_LCD_LOGO_TEXT1 +# define CONFIG_LCD_LOGO_TEXT1 (C) 2008 ATMEL Corp +#endif Wouldn't it be better if we move this text into include/configs/at91xxx.h for all the boards ? Yes, please. Anatolij, Jean-Christophe -