Re: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-07 Thread Kumar Gala
On Mar 5, 2013, at 2:40 PM, Wolfgang Denk wrote: Dear Xu Lei-B33228, Please do not top post / full quote. Thanks. In message 8cb6a38adf9e994697ff8a45e96e0853388...@039-sn1mpn1-004.039d.mgd.msft.net you wrote: Thank you and I agree with you. It is a little ugly but because

Re: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-05 Thread xulei
Hello, Wolfgang Thank you and I agree with you. It is a little ugly but because these registers info are not publicly, so I did not use C struct to describe them, then for this case it it ok or other method such as define a struct but keep all other registers and bits in this register

Re: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-05 Thread xulei
Hello, Wolfgang Thank you, will modify it in the next version. Regards Lei On Monday, 2013-03-04 at 10:24 +0100, Wolfgang Denk wrote: Dear xulei, In message 1362368146-738-1-git-send-email-b33...@freescale.com you wrote: + /* On P204x/P304x/P50x0 Rev1.0, USB transmit will

Re: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-05 Thread Wolfgang Denk
Dear Xu Lei-B33228, Please do not top post / full quote. Thanks. In message 8cb6a38adf9e994697ff8a45e96e0853388...@039-sn1mpn1-004.039d.mgd.msft.net you wrote: Thank you and I agree with you. It is a little ugly but because these registers info are not publicly, so I did not use C

Re: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-04 Thread Wolfgang Denk
Dear xulei, In message 1362368146-738-1-git-send-email-b33...@freescale.com you wrote: + /* On P204x/P304x/P50x0 Rev1.0, USB transmit will result internal + * multi-bit ECC errors, which has impact on performance, so software + * should disable all ECC reporting from USB1 and

Re: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-04 Thread Wolfgang Denk
Dear xulei, In message 1362368146-738-1-git-send-email-b33...@freescale.com you wrote: On P204x/P304x/P50x0 Rev1.0, USB transmit will result in false internal multi-bit ECC errors, which has impact on performance, so software should disable all ECC reporting from USB1 and USB2 by setting bits

[U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)

2013-03-03 Thread xulei
On P204x/P304x/P50x0 Rev1.0, USB transmit will result in false internal multi-bit ECC errors, which has impact on performance, so software should disable all ECC reporting from USB1 and USB2 by setting bits 16 and 17 to 1 in the register at DCSRBASE + 0x0002_0520. In formal release document, the