Re: [U-Boot] [PATCH 1/2] net: Remove call of srand from eth_random_enetaddr()

2013-01-09 Thread Wolfgang Denk
Dear Christian Riesch, In message cabklobrl2bhkmjh9nccv1uq-cbfjisuidk8joe8dsaoekqi...@mail.gmail.com you wrote: I don't like this change. What exactly is wrong with using the timer here? It is probably much more random that the (so-called) un-initialized memory you suggest to use

[U-Boot] [PATCH 1/2] net: Remove call of srand from eth_random_enetaddr()

2013-01-08 Thread Christian Riesch
Currently eth_random_enetaddr() seeds the random number generator with get_timer(0). Some boards might want to use other sources for the seed, therefore move the call of srand() to the board specific code. Signed-off-by: Christian Riesch christian.rie...@omicron.at Cc: Michael Walle

Re: [U-Boot] [PATCH 1/2] net: Remove call of srand from eth_random_enetaddr()

2013-01-08 Thread Wolfgang Denk
Dear Christian Riesch, In message 419e5c6e-b2ef-44c2-a4c1-bb25c50fc...@mary.at.omicron.at you wrote: Currently eth_random_enetaddr() seeds the random number generator with get_timer(0). Some boards might want to use other sources for the seed, therefore move the call of srand() to the board

Re: [U-Boot] [PATCH 1/2] net: Remove call of srand from eth_random_enetaddr()

2013-01-08 Thread Christian Riesch
Hello Wolfgang, Thank you for your comments. On Tuesday, January 8, 2013, Wolfgang Denk wrote: Dear Christian Riesch, In message 419e5c6e-b2ef-44c2-a4c1-bb25c50fc...@mary.at.omicron.atjavascript:; you wrote: Currently eth_random_enetaddr() seeds the random number generator with