[U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Otavio Salvador
Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- board/freescale/mx6qsabresd/mx6qsabresd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/board/freescale/mx6qsabresd/mx6qsabresd.c b/board/freescale/mx6qsabresd/mx6qsabresd.c index 65c4a1a..3c00023 100644 ---

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Fabio Estevam
On Sat, Mar 2, 2013 at 6:49 PM, Otavio Salvador ota...@ossystems.com.br wrote: Please provide a commit log. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- board/freescale/mx6qsabresd/mx6qsabresd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Otavio Salvador
On Sat, Mar 2, 2013 at 7:11 PM, Fabio Estevam feste...@gmail.com wrote: On Sat, Mar 2, 2013 at 6:49 PM, Otavio Salvador ota...@ossystems.com.br wrote: Please provide a commit log. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- board/freescale/mx6qsabresd/mx6qsabresd.c | 4

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Fabio Estevam
On Sat, Mar 2, 2013 at 8:08 PM, Otavio Salvador ota...@ossystems.com.br wrote: } + + return 0; ,but why do we need this? Fail by default? No, just do like mx53loco and mx6qsabrelite, where we always 'return ret' ___ U-Boot mailing

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Otavio Salvador
On Sat, Mar 2, 2013 at 8:15 PM, Fabio Estevam feste...@gmail.com wrote: On Sat, Mar 2, 2013 at 8:08 PM, Otavio Salvador ota...@ossystems.com.br wrote: } + + return 0; ,but why do we need this? Fail by default? No, just do like mx53loco and mx6qsabrelite, where we always

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Otavio Salvador
On Sat, Mar 2, 2013 at 8:19 PM, Otavio Salvador ota...@ossystems.com.br wrote: On Sat, Mar 2, 2013 at 8:15 PM, Fabio Estevam feste...@gmail.com wrote: On Sat, Mar 2, 2013 at 8:08 PM, Otavio Salvador ota...@ossystems.com.br wrote: } + + return 0; ,but why do we need this?

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Fabio Estevam
On Sat, Mar 2, 2013 at 8:22 PM, Otavio Salvador ota...@ossystems.com.br wrote: Well, we don't have ret here. Yes, exactly. My suggestion is to add a return value, just like mx53loco and sabresd. ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 1/3] mx6qsabresd: Fix card detection for invalid card id case

2013-03-02 Thread Otavio Salvador
On Sat, Mar 2, 2013 at 8:24 PM, Fabio Estevam feste...@gmail.com wrote: On Sat, Mar 2, 2013 at 8:22 PM, Otavio Salvador ota...@ossystems.com.br wrote: Well, we don't have ret here. Yes, exactly. My suggestion is to add a return value, just like mx53loco and sabresd. Great; did it for v2.