Re: [U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)

2012-12-15 Thread Joe Hershberger
Hi Mike, On Sat, Nov 10, 2012 at 11:47 PM, Mike Frysinger vap...@gentoo.org wrote: When using open(), the O_CREAT flag must be given a mode, otherwise it uses random garbage from the stack. Also, it can fail to build: In file included from /usr/include/fcntl.h:290:0, from

Re: [U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)

2012-12-14 Thread Christian Riesch
Hi, On Sun, Nov 11, 2012 at 6:47 AM, Mike Frysinger vap...@gentoo.org wrote: When using open(), the O_CREAT flag must be given a mode, otherwise it uses random garbage from the stack. Also, it can fail to build: In file included from /usr/include/fcntl.h:290:0, from

[U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)

2012-11-10 Thread Mike Frysinger
When using open(), the O_CREAT flag must be given a mode, otherwise it uses random garbage from the stack. Also, it can fail to build: In file included from /usr/include/fcntl.h:290:0, from fw_env_main.c:42: In function 'open', inlined from 'main' at fw_env_main.c:97:9: