Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-12 Thread Sughosh Ganu
hi, On Wed Jul 10, 2013 at 11:56:30PM -0700, Simon Glass wrote: I have netbsd running on hawkboard, but i do not boot it using the bootm command, but use the go command instead. I will try to build a netbsd image with the u-boot header and give it a try with bootm. Need a day or two

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-12 Thread Simon Glass
Hi Sughosh, On Fri, Jul 12, 2013 at 1:21 AM, Sughosh Ganu urwithsugh...@gmail.comwrote: hi, On Wed Jul 10, 2013 at 11:56:30PM -0700, Simon Glass wrote: I have netbsd running on hawkboard, but i do not boot it using the bootm command, but use the go command instead. I will try to

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-11 Thread Sughosh Ganu
On Wed, Jul 10, 2013 at 3:21 PM, Sughosh Ganu urwithsugh...@gmail.comwrote: hi Tom, On Tue Jul 09, 2013 at 05:19:32PM -0400, Tom Rini wrote: snip Yes, I am not really comfortable with this. I will see if I can write some sandbox tests for the other image types today and post my

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-11 Thread Simon Glass
Hi, On Jul 10, 2013 11:04 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: On Wed, Jul 10, 2013 at 3:21 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Tom, On Tue Jul 09, 2013 at 05:19:32PM -0400, Tom Rini wrote: snip Yes, I am not really comfortable with this. I will see if

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-10 Thread Sughosh Ganu
hi Tom, On Tue Jul 09, 2013 at 05:19:32PM -0400, Tom Rini wrote: snip Yes, I am not really comfortable with this. I will see if I can write some sandbox tests for the other image types today and post my results. I guess this bootm code has built up over a long time and it is hard to know

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-10 Thread Simon Glass
Hi Sughosh, On Wed, Jul 10, 2013 at 2:51 AM, Sughosh Ganu urwithsugh...@gmail.comwrote: hi Tom, On Tue Jul 09, 2013 at 05:19:32PM -0400, Tom Rini wrote: snip Yes, I am not really comfortable with this. I will see if I can write some sandbox tests for the other image types today and

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-10 Thread Simon Glass
Hi Tom, On Tue, Jul 9, 2013 at 2:19 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 01:04:58PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 12:05 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 12:00:00PM -0700, Simon Glass wrote: Hi Tom, On

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-10 Thread Simon Glass
[snip] I will tidy up my tests and submit these also at some point. Coverage now includes FIT and legacy images, with bootm commands and subcommands. For the record there is still a lot of test code missing: (sorry, sent the last email by mistake - here is a list that I compiled when writing

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Tom Rini
On Mon, Jul 08, 2013 at 10:22:13AM -0400, Tom Rini wrote: On Mon, Jul 08, 2013 at 09:17:10AM -0500, Robert Nelson wrote: On Mon, Jul 8, 2013 at 9:13 AM, Tom Rini tr...@ti.com wrote: On Thu, Jul 04, 2013 at 01:26:11PM -0700, Simon Glass wrote: In the recent bootm refactor, the PREP stage

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Tom Rini
On Tue, Jul 09, 2013 at 12:00:00PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 10:01 AM, Tom Rini tr...@ti.com wrote: On Mon, Jul 08, 2013 at 10:22:13AM -0400, Tom Rini wrote: On Mon, Jul 08, 2013 at 09:17:10AM -0500, Robert Nelson wrote: On Mon, Jul 8, 2013 at 9:13

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Robert Nelson
On Tue, Jul 9, 2013 at 2:00 PM, Simon Glass s...@chromium.org wrote: Hi Tom, On Tue, Jul 9, 2013 at 10:01 AM, Tom Rini tr...@ti.com wrote: On Mon, Jul 08, 2013 at 10:22:13AM -0400, Tom Rini wrote: On Mon, Jul 08, 2013 at 09:17:10AM -0500, Robert Nelson wrote: On Mon, Jul 8, 2013 at

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Simon Glass
Hi Tom, On Tue, Jul 9, 2013 at 10:01 AM, Tom Rini tr...@ti.com wrote: On Mon, Jul 08, 2013 at 10:22:13AM -0400, Tom Rini wrote: On Mon, Jul 08, 2013 at 09:17:10AM -0500, Robert Nelson wrote: On Mon, Jul 8, 2013 at 9:13 AM, Tom Rini tr...@ti.com wrote: On Thu, Jul 04, 2013 at

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Simon Glass
Hi Tom, On Tue, Jul 9, 2013 at 12:05 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 12:00:00PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 10:01 AM, Tom Rini tr...@ti.com wrote: On Mon, Jul 08, 2013 at 10:22:13AM -0400, Tom Rini wrote: On Mon, Jul 08, 2013

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Tom Rini
On Tue, Jul 09, 2013 at 01:04:58PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 12:05 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 12:00:00PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 10:01 AM, Tom Rini tr...@ti.com wrote: On Mon, Jul

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Robert Nelson
On Tue, Jul 9, 2013 at 4:19 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 01:04:58PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 12:05 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 12:00:00PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Robert Nelson
Important, but I really want to see real-world booting in a case or two. Unfortunately I don't have any ARM boards that work out of the box with NetBSD. There 'seems' to be a pre-built freebsd arm port... https://wiki.freebsd.org/FreeBSD/arm/BeagleBone NM.. they are using the 'bootelf'

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-09 Thread Simon Glass
Hi Tom, On Tue, Jul 9, 2013 at 2:19 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 01:04:58PM -0700, Simon Glass wrote: Hi Tom, On Tue, Jul 9, 2013 at 12:05 PM, Tom Rini tr...@ti.com wrote: On Tue, Jul 09, 2013 at 12:00:00PM -0700, Simon Glass wrote: Hi Tom, On

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-08 Thread Tom Rini
On Thu, Jul 04, 2013 at 01:26:11PM -0700, Simon Glass wrote: In the recent bootm refactor, the PREP stage was missing in the bootz command. This causes unpredictable behaviour. The use of a local variable means that the reset of cmd_bootm.c does not in fact use the same image structure, so

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-08 Thread Robert Nelson
On Mon, Jul 8, 2013 at 9:13 AM, Tom Rini tr...@ti.com wrote: On Thu, Jul 04, 2013 at 01:26:11PM -0700, Simon Glass wrote: In the recent bootm refactor, the PREP stage was missing in the bootz command. This causes unpredictable behaviour. The use of a local variable means that the reset of

Re: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-08 Thread Tom Rini
On Mon, Jul 08, 2013 at 09:17:10AM -0500, Robert Nelson wrote: On Mon, Jul 8, 2013 at 9:13 AM, Tom Rini tr...@ti.com wrote: On Thu, Jul 04, 2013 at 01:26:11PM -0700, Simon Glass wrote: In the recent bootm refactor, the PREP stage was missing in the bootz command. This causes unpredictable

[U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling

2013-07-04 Thread Simon Glass
In the recent bootm refactor, the PREP stage was missing in the bootz command. This causes unpredictable behaviour. The use of a local variable means that the reset of cmd_bootm.c does not in fact use the same image structure, so remove this. Also manually set the OS type to Linux, since this is