Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-13 Thread Tom Rini
On Tue, Mar 12, 2013 at 11:07:46PM +0100, Albert ARIBAUD wrote: Hi Tom, On Tue, 12 Mar 2013 13:47:33 -0400, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/12/2013 01:19 PM, Albert ARIBAUD wrote: Hi Scott, On Tue, 12 Mar 2013 12:06:53

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Tom Rini
On Fri, Mar 08, 2013 at 06:35:04PM -0600, Scott Wood wrote: On 03/08/2013 02:59:47 PM, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/2013 03:34 PM, Scott Wood wrote: On 03/08/2013 02:27:48 PM, Tom Rini wrote: On Thu, Dec 20, 2012 at 11:51:05AM -, Scott Wood

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Scott Wood
On 03/12/2013 10:30:40 AM, Tom Rini wrote: On Fri, Mar 08, 2013 at 06:35:04PM -0600, Scott Wood wrote: Why would eliminating all individual callbacks cause start/end to go away? If that's the way the list mechanism works, the mechanism needs fixing. Yes, that's how the mechanism works.

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Tom Rini
On Tue, Mar 12, 2013 at 11:55:22AM -0500, Scott Wood wrote: On 03/12/2013 10:30:40 AM, Tom Rini wrote: On Fri, Mar 08, 2013 at 06:35:04PM -0600, Scott Wood wrote: Why would eliminating all individual callbacks cause start/end to go away? If that's the way the list mechanism works, the

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Scott Wood
On 03/12/2013 12:02:56 PM, Tom Rini wrote: On Tue, Mar 12, 2013 at 11:55:22AM -0500, Scott Wood wrote: On 03/12/2013 10:30:40 AM, Tom Rini wrote: On Fri, Mar 08, 2013 at 06:35:04PM -0600, Scott Wood wrote: Why would eliminating all individual callbacks cause start/end to go away? If

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Albert ARIBAUD
Hi Scott, On Tue, 12 Mar 2013 12:06:53 -0500, Scott Wood scottw...@freescale.com wrote: On 03/12/2013 12:02:56 PM, Tom Rini wrote: On Tue, Mar 12, 2013 at 11:55:22AM -0500, Scott Wood wrote: On 03/12/2013 10:30:40 AM, Tom Rini wrote: On Fri, Mar 08, 2013 at 06:35:04PM -0600, Scott Wood

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/12/2013 01:19 PM, Albert ARIBAUD wrote: Hi Scott, On Tue, 12 Mar 2013 12:06:53 -0500, Scott Wood scottw...@freescale.com wrote: On 03/12/2013 12:02:56 PM, Tom Rini wrote: On Tue, Mar 12, 2013 at 11:55:22AM -0500, Scott Wood wrote: On

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-12 Thread Albert ARIBAUD
Hi Tom, On Tue, 12 Mar 2013 13:47:33 -0400, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/12/2013 01:19 PM, Albert ARIBAUD wrote: Hi Scott, On Tue, 12 Mar 2013 12:06:53 -0500, Scott Wood scottw...@freescale.com wrote: On 03/12/2013 12:02:56

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-08 Thread Tom Rini
On Thu, Dec 20, 2012 at 11:51:05AM -, Scott Wood wrote: SPL doesn't write to the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to break due to size

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-08 Thread Scott Wood
On 03/08/2013 02:27:48 PM, Tom Rini wrote: On Thu, Dec 20, 2012 at 11:51:05AM -, Scott Wood wrote: SPL doesn't write to the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-08 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/2013 03:34 PM, Scott Wood wrote: On 03/08/2013 02:27:48 PM, Tom Rini wrote: On Thu, Dec 20, 2012 at 11:51:05AM -, Scott Wood wrote: SPL doesn't write to the environment. These list entries prevent the functions from being

Re: [U-Boot] [U-Boot, v2] env: don't generate callback list entries for SPL

2013-03-08 Thread Scott Wood
On 03/08/2013 02:59:47 PM, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/2013 03:34 PM, Scott Wood wrote: On 03/08/2013 02:27:48 PM, Tom Rini wrote: On Thu, Dec 20, 2012 at 11:51:05AM -, Scott Wood wrote: SPL doesn't write to the environment. These list entries