Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes [V2]

2008-10-29 Thread Markus Klotzbücher
On Wed, Oct 29, 2008 at 12:07:38AM +0100, Wolfgang Denk wrote: Dear Markus, In message [EMAIL PROTECTED] you wrote: Both patches passed my usual sequoia regression test, so I added both to the USB custodian repository. If nobody reports any regressions I intend to send Wolfgang a

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes [V2]

2008-10-28 Thread Wolfgang Denk
Dear Markus, In message [EMAIL PROTECTED] you wrote: Both patches passed my usual sequoia regression test, so I added both to the USB custodian repository. If nobody reports any regressions I intend to send Wolfgang a pull request in upcoming merge window. What's the state about this

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes [V2]

2008-10-14 Thread Markus Klotzbücher
Dear Remy, On Fri, Oct 10, 2008 at 10:23:20AM +0200, Remy Bohmer wrote: This is version 2 of these series! Only patch 1 of 2 has changed, some pedantic Coding Style issues updated that were not detected by Linux/scripts/checkpatch.pl. The USB OHCI init procedure sets the maximum message

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-10 Thread Remy Bohmer
Hello Stelian, This clock is required, but is usually _not_ configured by U-boot (for the AT91SAM series) but by the bootstrap code. You could check if the current settings for PLLB matches the settings done by Linux. Bingo ! The bootstrap code does appear to setup some wrong values for the

[U-Boot] [patch 0/2] Some more USB-OHCI bugfixes [V2]

2008-10-10 Thread Remy Bohmer
This is version 2 of these series! Only patch 1 of 2 has changed, some pedantic Coding Style issues updated that were not detected by Linux/scripts/checkpatch.pl. The USB OHCI init procedure sets the maximum message length the wrong way. A max of 64 bits should not be done by writing '64' in

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-09 Thread Stelian Pop
Le mercredi 08 octobre 2008 à 10:54 +0200, Remy Bohmer a écrit : I made it 2 seperate patches. The 1st of this series is fully tested and correct on at least the AT91SAM9261 cores. I hope it fixes the known problems on AT91SAM9263 (and other) cores also, maybe Stelian can verify this. If it

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-09 Thread Stelian Pop
Le jeudi 09 octobre 2008 à 11:51 +0200, Remy Bohmer a écrit : Looking at the logging, it seems that communication to the root hub itself is working properly, but everything to the bus fails. Are you sure that _all_ peripheral clocks are running? Are you sure that the 48MHz clock is running

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-09 Thread Remy Bohmer
Hello Stelian, It still doesn't help (on AT91SAM9263): grmbl... I believe this has to be debugged on this specific controller, since I do not have one here I cannot debug it myself... :-( At least we made a large step forward on many other cores, but apparently we are not there yet for all

[U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-08 Thread Remy Bohmer
The USB OHCI init procedure sets the maximum message length the wrong way. A max of 64 bits should not be done by writing '64' in maxpacketsize, but '3'. While fixing this problem it turned out that there is more wrong here in this code it turned out that the wrong bits were checked to determine

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-08 Thread Markus Klotzbücher
Hi Remy, On Wed, Oct 08, 2008 at 10:54:13AM +0200, Remy Bohmer wrote: The USB OHCI init procedure sets the maximum message length the wrong way. A max of 64 bits should not be done by writing '64' in maxpacketsize, but '3'. While fixing this problem it turned out that there is more wrong here

Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-08 Thread Stelian Pop
Le mercredi 08 octobre 2008 à 10:54 +0200, Remy Bohmer a écrit : I made it 2 seperate patches. The 1st of this series is fully tested and correct on at least the AT91SAM9261 cores. I hope it fixes the known problems on AT91SAM9263 (and other) cores also, maybe Stelian can verify this. If it