Re: [U-Boot] Bug in fdt_fixup_fman_firmware

2013-06-18 Thread Andy Fleming
--- a/arch/powerpc/cpu/mpc85xx/fdt.c +++ b/arch/powerpc/cpu/mpc85xx/fdt.c @@ -492,7 +492,7 @@ if (!p) return; - fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0); + fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16); if (!fmanfw) return; Could you submit this

[U-Boot] Bug in fdt_fixup_fman_firmware

2013-04-16 Thread Николай Пузанов
Hello! In my opinion I found a bug in the function 'fdt_fixup_fman_firmware' (arch/powerpc/cpu/mpc85xx/fdt.c): on line 495 function 'simple_strtul' takes an hex number without the prefix '0x' and considers it a decimal. Here are two variants for correcting this bug, but I do not know what will be

Re: [U-Boot] Bug in fdt_fixup_fman_firmware

2013-04-16 Thread Wolfgang Denk
Dear Николай Пузанов, In message cakj6i9ipzbmugxmyfghsquaoy3yz6pntd6ijxgpk-1ps3ok...@mail.gmail.com you wrote: In my opinion I found a bug in the function 'fdt_fixup_fman_firmware' (arch/powerpc/cpu/mpc85xx/fdt.c): on line 495 function 'simple_strtul' takes an hex number without the prefix